17237 Commits

Author SHA1 Message Date
Andy
f411164483
Simplify calculation of sourceFiles for getReferences (#24475) 2018-05-29 16:12:25 -07:00
Andy
e99be8c47d
Avoid duplicate import completions when a namespace is exported by two different modules (#24473) 2018-05-29 15:52:34 -07:00
csigs
98a4dc7604 LEGO: check in for master to temporary branch. 2018-05-29 22:11:04 +00:00
Nathan Shively-Sanders
36c580378f
Fix duplicate identifier error with module.exports (#24466)
A bug in checkSpecialAssignment added bogus duplicate identifier errors
when using module.exports assignment to export a class. This commit
fixes that.
2018-05-29 14:29:48 -07:00
Nathan Shively-Sanders
15bfaf1cf6
Skip IntrinsicAttributes elaboration in JSX errors (#24461)
* Skip IntrinsicAttributes elaboration in JSX errors

Do not issue an error message for a source type that comes from JSX
attributes and a target type that is an intersection containing
IntrinsicAttributes or IntrinsicClassAttributes. This will make error
messages simpler and less confusing.

Note:
1. There will always be elaboration under the skipped message, so this
won't elide errors completely.
2. Rarely (once in the tests) the intersection type will have more that
one non-Intrinsic* member. However, these additional members don't
provide useful information either, so it's fine to skip them.

* Add test of IntrinsicAttributes error

* Fix indentation in test
2018-05-29 14:00:26 -07:00
Ron Buckton
c1a5d9bb06
Merge pull request #24463 from Microsoft/fix24288
Fix return and throw propagation for yield*
2018-05-29 13:34:31 -07:00
Ron Buckton
6657df47f0 Fix return and throw propagation for yield* 2018-05-29 12:56:46 -07:00
Andy
8bc1932ed5
moduleSpecifiers: Don't return a relative path to node_modules (#24460) 2018-05-29 12:40:06 -07:00
Andy
160b667846
fixUnusedIdentifier: Don't remove parameter in override or non-last parameter in callback (#24306)
* fixUnusedIdentifier: Don't remove parameter in override or non-last parameter in callback

* Only allow removing last parameters; don't care about contextual type
2018-05-29 12:39:45 -07:00
Andy
816f1cee5a
Include '...' on doc comment for rest parameter (#24462) 2018-05-29 12:17:57 -07:00
Mohamed Hegazy
58f4c6fcbf
Merge pull request #24457 from Microsoft/fixBuild
Fix build
2018-05-29 09:41:16 -07:00
csigs
a839cbd710 LEGO: check in for master to temporary branch. 2018-05-29 16:10:37 +00:00
Mohamed Hegazy
94c455792a Remove unneeded assertions 2018-05-29 09:06:35 -07:00
csigs
d5163357d3 LEGO: check in for master to temporary branch. 2018-05-29 10:10:39 +00:00
csigs
91aa60ac00 LEGO: check in for master to temporary branch. 2018-05-28 22:10:39 +00:00
Mohamed Hegazy
a7a68d9591 Merge branch 'fix-es5-export-class-name-object' of https://github.com/Kingwl/TypeScript into Kingwl-fix-es5-export-class-name-object 2018-05-25 15:45:31 -07:00
Mohamed Hegazy
725dbcc7a5 Merge branch 'master' of https://github.com/Microsoft/TypeScript 2018-05-25 15:45:12 -07:00
csigs
35c0aaa84d LEGO: check in for master to temporary branch. 2018-05-25 22:10:40 +00:00
Mohamed Hegazy
832893e559 Revert "Check detected npm path is existing"
This reverts commit 1fda3a4165b83fb82b666bd15e601c73590b52ec.
2018-05-25 14:54:53 -07:00
csigs
5e848f6efb LEGO: check in for master to temporary branch. 2018-05-25 16:10:26 +00:00
csigs
4244c8e2b4 LEGO: check in for master to temporary branch. 2018-05-25 10:10:26 +00:00
王文璐
7f127de89e remove invalid check 2018-05-25 09:36:16 +08:00
Wesley Wigham
64642bb5c3
Dump fork output on unclean exit (#24394)
* Dump fork output on unclean exit

* Remember to clear timeout on process exit in case processes exit at very different times
2018-05-24 16:13:32 -07:00
Wesley Wigham
8f9c0861bc
Use external aliases in quickinfo and signature help return types (#24391)
* Dont include import types in quick info type names

* Add UseAliasDefinedOutsideCurrentScope flag to LS operations which were missing it
2018-05-24 15:19:57 -07:00
Nathan Shively-Sanders
e250942d6a
Disallow nested object param syntax in callback tag (#24392)
* Callback tag:Disallow nested-object-param syntax

Previously this caused a crash in parsing. If/when we want to support
this syntax, we will need to fix this crash.

* Update baselines
2018-05-24 15:11:33 -07:00
csigs
3502d35057 LEGO: check in for master to temporary branch. 2018-05-24 22:10:36 +00:00
Elizabeth Dinella
b745ea059e
Fix to issue 23326 for completions on new.target (#24342)
* Fix to issue 23326 for completions on new.target

* Fixed linting issues - whitespace in if statements

* Removed debug statement in test case and consolidated and cleaned up code in switch statement for completions

* Added support for import.meta completion
2018-05-24 14:12:33 -07:00
Elizabeth Dinella
13734e7d68
Fix for issue #6154 - overriding methods with properties in the derived class (#24343)
* Fix to issue 6154 - Overriding a method with a property in the derived class should not cause a compiler error

* new baselines

* fixed deleted baselines
2018-05-24 14:12:13 -07:00
Sheetal Nandi
51058b56e5 Do not trigger invalidation if emitted file is in declarationDir 2018-05-24 13:36:52 -07:00
Wesley Wigham
4be4e56579
Hoisted declarations should occur after prologue directives (#24386) 2018-05-24 12:49:02 -07:00
Wesley Wigham
a0b57808d0
Dont count duplicated errors in case-insensitive duped files in rwc (#24383) 2018-05-24 12:23:43 -07:00
Andy
16af96b006
moveToNewFile: Format the new file (#24379) 2018-05-24 11:08:32 -07:00
Andy
bc570cd85f
moveToNewFile: Respect UserPreferences#quote (#24365) 2018-05-24 09:36:37 -07:00
csigs
749f7bccf8 LEGO: check in for master to temporary branch. 2018-05-24 16:10:29 +00:00
Andy
ee8337d8e4
Minor cleanups in importFixes (#23995) 2018-05-24 07:46:39 -07:00
王文璐
d5239cdf6a fix ambient context 2018-05-24 18:20:54 +08:00
kingwl
cb2be44d02 fix export class declare with name object targeting es5 (#17494) 2018-05-24 18:16:38 +08:00
csigs
58bf08c7fc LEGO: check in for master to temporary branch. 2018-05-24 10:10:39 +00:00
Mohamed Hegazy
dd6dc5e27a
Merge pull request #24328 from Microsoft/getEditsForFileRename_oldFileStillPresent
getEditsForFileRename: Handle old file still being present
2018-05-23 16:16:00 -07:00
Andy
b61d4858d4
Simplify convertToMappedObjectType (#24360) 2018-05-23 16:01:52 -07:00
Mohamed Hegazy
10ac8b47e5
Merge pull request #22022 from Kingwl/enum-eval-div-zero
disallow nan and infinity in enum member
2018-05-23 15:32:35 -07:00
csigs
e9981b100b LEGO: check in for master to temporary branch. 2018-05-23 22:10:36 +00:00
Wenlu Wang
4606709672 add code fix convert to mapped object type (#24286)
* add code fix convert to mapped object type

* add support for type literal and improve test

* fix typo

* add support for heritageClauses

* only determine declaration is not class
2018-05-23 14:09:49 -07:00
csigs
e59559e24e LEGO: check in for master to temporary branch. 2018-05-23 17:55:46 +00:00
Andy
5983c45e24
Fix typo: seperate -> separate (#24338)
* Fix typo: seperate -> separate

* update tests
2018-05-23 09:36:17 -07:00
Andy
fb4caadaec
Support signature help for partially-filled-in type arguments f< (#24138)
* Support signature help for partially-filled-in type arguments `f<`

* Use `isPossiblyTypeArgumentPosition` and support new expressions
2018-05-23 08:28:09 -07:00
Sheetal Nandi
16d7f4c103
Merge pull request #24348 from Microsoft/findRefInJson
Fix getter of local symbol for export= when it is json module
2018-05-22 20:15:59 -07:00
Sheetal Nandi
a0d4e4f059 Fix getter of local symbol for export= when it is json module
Fixes #24341
2018-05-22 17:10:56 -07:00
Wesley Wigham
7e4b20e587
Use compare paths for comparing diagnostic paths, since the canonicalization of fileName and unitName differ (#24340) 2018-05-22 17:01:34 -07:00
Wesley Wigham
0102f8050c
Check for keyof constraint type instead of syntactic check (#24098)
* Check for keyof constraint type instead of syntactic check

* Readopt older candidateType check, even though it shouldnt really matter

* OK. Just use maybetypeOfKind

* Remove redundant boolean check
2018-05-22 16:58:31 -07:00