microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Dump fork output on unclean exit (#24394)

Browse Source 
* Dump fork output on unclean exit

* Remember to clear timeout on process exit in case processes exit at very different times
This commit is contained in:
Wesley Wigham 2018-05-24 16:13:32 -07:00 committed by GitHub
parent 8f9c0861bc
commit 64642bb5c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/harness/parallel/host.ts
View File

@ -13,6 +13,13 @@ namespace Harness.Parallel.Host {
on(event: "message", listener: (message: ParallelClientMessage) => void): this;
kill(signal?: string): void;
currentTasks?: {file: string}[]; // Custom monkeypatch onto child process handle
accumulatedOutput: string; // Custom monkeypatch with process output
stderr: PartialStream;
stdout: PartialStream;
}
interface PartialStream {
on(event: "data", listener: (chunk: Buffer) => void): this;
}
interface ProgressBarsOptions {
@ -151,7 +158,13 @@ namespace Harness.Parallel.Host {
const config: TestConfig = { light: lightMode, listenForWork: true, runUnitTests, stackTraceLimit };
const configPath = ts.combinePaths(taskConfigsFolder, `task-config${i}.json`);
IO.writeFile(configPath, JSON.stringify(config));
const child = fork(__filename, [`--config="${configPath}"`]);
const child = fork(__filename, [`--config="${configPath}"`], { stdio: ["pipe", "pipe", "pipe", "ipc"] });
child.accumulatedOutput = "";
const appendOutput = (d: Buffer) => {
child.accumulatedOutput += d.toString();
};
child.stderr.on("data", appendOutput);
child.stdout.on("data", appendOutput);
let currentTimeout = defaultTimeout;
const killChild = () => {
child.kill();
@ -166,8 +179,10 @@ namespace Harness.Parallel.Host {
return process.exit(2);
});
child.on("exit", (code, _signal) => {
clearTimeout(timer);
if (code !== 0) {
console.error("Test worker process exited with nonzero exit code!");
console.error(`Test worker process exited with nonzero exit code! Output:
${child.accumulatedOutput}`);
return process.exit(2);
}
});
@ -223,6 +238,7 @@ namespace Harness.Parallel.Host {
// No more tasks to distribute
child.send({ type: "close" });
closedWorkers++;
clearTimeout(timer);
if (closedWorkers === workerCount) {
outputFinalResult();
}