8684 Commits

Author SHA1 Message Date
Anders Hejlsberg
c52e5985b7
Merge pull request #29068 from Microsoft/noGenericEmptyObject
Generic types should never be considered empty objects
2018-12-17 15:59:42 -08:00
Wesley Wigham
d2885eab4a
Add regression test for #29047 (#29066) 2018-12-17 14:56:48 -08:00
Anders Hejlsberg
ab797df977 Add regression test 2018-12-17 14:14:54 -08:00
Daniel Rosenwasser
4d74f67325
Merge pull request #28888 from Microsoft/numericPropertyAccess
Avoid adding a dot when comment a property acccess's expression has trailing comments
2018-12-13 15:18:27 -08:00
Kerem
de4803658e Disable truncation for codefixes in signatureToMethodDeclaration. (#28188) 2018-12-13 11:21:36 -08:00
Wesley Wigham
5788446aa1
Use contextual parameter types over binding pattern initializer types (#28967)
* Use contextual parameter types over binding pattern initializer types

* Remove unneeded check
2018-12-12 15:39:32 -08:00
Anders Hejlsberg
fecbdb68bd
Merge pull request #28965 from Microsoft/simplifyIndexedAccess
Simplify indexed access types applied to mapped types
2018-12-11 17:56:03 -08:00
Daniel Rosenwasser
2999a1eb47 Merge remote-tracking branch 'origin/master' into numericPropertyAccess 2018-12-11 16:52:23 -08:00
Anders Hejlsberg
77d01ab332 Update tests 2018-12-11 15:12:47 -08:00
Anders Hejlsberg
2150a64f0c Add tests 2018-12-11 12:11:16 -08:00
Philip Pesca
e6aa992095 Fix error message when type argument arity is wrong (#28366)
* Fix error message when type argument arity is wrong

* Parenthesize 's' in plurals

* Update baseline

* Update baseline

* Use old error message

* Revert parantheses
2018-12-11 09:54:38 -08:00
Daniel Rosenwasser
2e9be8c05b Added more tests, including some in 'removeComments' mode. 2018-12-10 22:21:15 -08:00
Anders Hejlsberg
45411e525c Add tests 2018-12-10 16:30:30 -08:00
Daniel Rosenwasser
bc59582c7d
Merge pull request #28627 from ajafff/arrow-arguments
ArrowFunction has no own 'arguments'
2018-12-10 11:42:43 -08:00
Daniel Rosenwasser
3e6a666b5e
Merge pull request #28919 from a-tarasyuk/feature/28893-allow-trailing-comma-on-tuple-types
feature/28893 allow trailing comma on tuple types
2018-12-10 11:33:33 -08:00
Anders Hejlsberg
cd6d2fdc18
Merge pull request #28940 from Microsoft/explicitUnknownConstraint
Type parameter constrained to 'unknown' not assignable to '{}'
2018-12-10 10:29:06 -08:00
Anders Hejlsberg
d2cc282134 Add tests 2018-12-10 09:45:55 -08:00
Anders Hejlsberg
7a0779288f Add tests 2018-12-10 09:14:41 -08:00
Alexander
e219b17ff0 TupleType - add additional tests to handle error on extra comma 2018-12-08 20:50:09 +02:00
Anders Hejlsberg
34d9d4bc8c
Merge pull request #28870 from Microsoft/discriminatedUnionInference
Improved type inference for discriminated unions
2018-12-07 15:44:41 -08:00
Daniel Rosenwasser
8150169762
Merge pull request #28857 from JoshuaKGoldberg/identifiers-after-numeric-literals
Added error for IdentifierStart immediately after a NumericLiteral
2018-12-06 11:49:56 -08:00
Josh Goldberg
a211184347 Clarified error message; extended error to identifier end
Lengthening the reported error length to include all of the identifier necessitates scanning for all of the identifier. I also reset the `pos` after so other identifier scanning still happens.
2018-12-06 11:17:06 -08:00
Anders Hejlsberg
4ae0848bd4 Add tests 2018-12-05 15:20:21 -08:00
Daniel Rosenwasser
3fe72631ce Added test case for trivia preceding dot in numeric LHS in property accesses. 2018-12-05 15:02:00 -08:00
Anders Hejlsberg
07dbc56208
Merge pull request #28854 from Microsoft/fixExcessPropertyChecks
Improve excess property checks
2018-12-05 08:51:08 -08:00
Josh Goldberg
174816fc26 Added error for IdentifierStart immediately after a NumericLiteral
Fixes #4702.
2018-12-04 17:59:20 -08:00
Anders Hejlsberg
b34c73f7e8
Merge pull request #28851 from Microsoft/deferConditionalTypes
Defer resolution of conditional types with generic check or extends types
2018-12-04 15:48:57 -08:00
Anders Hejlsberg
e7bb5625c0 Add additional tests 2018-12-04 14:51:59 -08:00
Anders Hejlsberg
3e2f130b3c Add regression test 2018-12-04 13:18:04 -08:00
Nathan Shively-Sanders
ee987a25e2
Revert over-eager bailout when trailing whitespace (#28848) 2018-12-04 12:45:00 -08:00
Sheetal Nandi
c85460bc44
Merge pull request #28818 from Cow258/master
Move await keyword to inside of function
2018-12-04 12:36:13 -08:00
Nathan Shively-Sanders
24b39f90c9
Skip implicit any suggestions with no codefix (#28822)
The only unsupported one is binding patterns, which aren't supported by the codefix.
The code was a lot faster to write without supporting them, but there's
no real barrier besides that.
2018-12-04 09:17:37 -08:00
Nathan Shively-Sanders
594430f113
Infer from arrows from usage. (#28832)
* Infer from arrows from usage.

Previously only function expressions were, and only those with an easily
accessible name. Now any arrow function or function expression will
infer from usage.

* remove isApplicableFunctionForInference

*all* functions are applicable for inference now.
2018-12-04 09:03:08 -08:00
dreamran43@gmail.com
a2851d2ddc Move await keyword to inside of function and test 2018-12-04 03:01:56 +08:00
dreamran43@gmail.com
8eefaf48f5 Move await keyword to inside of function (Recovery & try test) 2018-12-04 01:50:02 +08:00
Wesley Wigham
2103ed69e6
Merge pull request #28782 from weswigham/global-merge-no-crash
Fix crash on umd and module merge, allow umds to be accessed when merged with a non-UMD symbol
2018-12-03 09:43:04 -08:00
dreamran43@gmail.com
47302147ab Move await keyword to inside of function and test 2018-12-04 01:19:51 +08:00
Wesley Wigham
03a98a2840
Merge pull request #28783 from weswigham/fix-typeparam-parent
Add missing case to declaration diagnostic handler
2018-12-03 09:15:38 -08:00
Anders Hejlsberg
28f8fdaccd
Merge pull request #28784 from Microsoft/controlFlowDestructuringLoop
Fix control flow analysis of destructuring in loops
2018-12-01 07:01:43 -08:00
Wesley Wigham
cd6fdb11d6 Add constructor case 2018-11-30 17:44:25 -08:00
Anders Hejlsberg
290eff9722 Add regression test 2018-11-30 16:28:21 -08:00
Wesley Wigham
fa8df0d32c Add missing case to declaration diagnostic handler 2018-11-30 16:25:07 -08:00
Wesley Wigham
d92771d61a Fix crash on umd and module merge, allow umds to be accessed when merged with a non-UMD symbol 2018-11-30 15:55:20 -08:00
Daniel Rosenwasser
b44ee8ef4b Added tests for types with overlap across a single property name. 2018-11-30 14:59:43 -08:00
Sheetal Nandi
23abcc02a3 Use compilerOptionsIndicateEs6Modules over program contains es6 modules for determining auto import offering. Also dont depend on uncheck js file for this.
Fixes #28696
2018-11-29 11:58:32 -08:00
Anders Hejlsberg
36dc04b982
Merge pull request #28718 from Microsoft/fixDefinitelyAssignableRelation
Fix definitely assignable relation
2018-11-28 17:38:51 -08:00
Anders Hejlsberg
d832fbf46a Add regression test 2018-11-28 14:58:11 -08:00
Wesley Wigham
54bbf74f62
Do not lookup name of default property symbols from the symbols value declaration (#28711) 2018-11-28 13:58:43 -08:00
Nathan Shively-Sanders
f915420c80 Revert "Don't consider 'typeof a' as using 'a' (#28528)"
This reverts commit 0c4ceeec24f16f87e75386355c86ac38612a1175.
2018-11-26 14:45:19 -08:00
Daniel Rosenwasser
6627d33540
Merge pull request #27087 from Microsoft/overlappyTypes
Elaborate on types in unions with the most overlap in properties
2018-11-26 14:58:15 -05:00