microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-06 20:14:01 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Disable truncation for codefixes in signatureToMethodDeclaration. (#28188)

Browse Source
This commit is contained in:
Kerem 2018-12-13 20:21:36 +01:00 committed by Wesley Wigham
parent 5788446aa1
commit de4803658e
2 changed files with 51 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/codefixes/helpers.ts
View File

@ -97,7 +97,7 @@ namespace ts.codefix {
optional: boolean,
body: Block | undefined,
): MethodDeclaration | undefined {
const signatureDeclaration = <MethodDeclaration>checker.signatureToSignatureDeclaration(signature, SyntaxKind.MethodDeclaration, enclosingDeclaration, NodeBuilderFlags.SuppressAnyReturnType);
const signatureDeclaration = <MethodDeclaration>checker.signatureToSignatureDeclaration(signature, SyntaxKind.MethodDeclaration, enclosingDeclaration, NodeBuilderFlags.NoTruncation | NodeBuilderFlags.SuppressAnyReturnType);
if (!signatureDeclaration) {
return undefined;
}

50
tests/cases/fourslash/codeFixClassExtendAbstractMethodWithLongName.ts Normal file
View File

@ -0,0 +1,50 @@
/// <reference path='fourslash.ts' />
////namespace some.really.long.generated.type.goes.here.you.know.this_.should.be.pretty.simple {
//// export interface Yah {}
////}
////namespace another.really.long.generated.type.goes.here.too.because.who.cares.about.space.do_.you.feel.me {
//// export interface Yah {}
////}
////interface this_will_be_collapsed {}
////interface this_is_fine {}
////abstract class AbstractCstVisitor {
//// abstract Node(
//// arg1: [
//// some.really.long.generated.type.goes.here.you.know.this_.should.be.pretty.simple.Yah[],
//// another.really.long.generated.type.goes.here.too.because.who.cares.about.space.do_.you.feel.me.Yah[]
//// ],
//// arg2: [this_will_be_collapsed],
//// arg3: Set<this_will_be_collapsed>,
//// arg4: this_is_fine
//// ): Set<this_will_be_collapsed>;
////}
////class CstVisitorImplementation extends AbstractCstVisitor {}
verify.codeFix({
description: "Implement inherited abstract class",
newFileContent: `namespace some.really.long.generated.type.goes.here.you.know.this_.should.be.pretty.simple {
export interface Yah {}
}
namespace another.really.long.generated.type.goes.here.too.because.who.cares.about.space.do_.you.feel.me {
export interface Yah {}
}
interface this_will_be_collapsed {}
interface this_is_fine {}
abstract class AbstractCstVisitor {
abstract Node(
arg1: [
some.really.long.generated.type.goes.here.you.know.this_.should.be.pretty.simple.Yah[],
another.really.long.generated.type.goes.here.too.because.who.cares.about.space.do_.you.feel.me.Yah[]
],
arg2: [this_will_be_collapsed],
arg3: Set<this_will_be_collapsed>,
arg4: this_is_fine
): Set<this_will_be_collapsed>;
}
class CstVisitorImplementation extends AbstractCstVisitor {
Node(arg1: [some.really.long.generated.type.goes.here.you.know.this_.should.be.pretty.simple.Yah[], another.really.long.generated.type.goes.here.too.because.who.cares.about.space.do_.you.feel.me.Yah[]], arg2: [this_will_be_collapsed], arg3: any, arg4: this_is_fine) {
throw new Error("Method not implemented.");
}
}`
});