christian
ea984d7b64
Centralize diagnostic reporting for empty files diagnostic
2018-09-05 23:18:39 -04:00
christian
959dbbba28
Add newline to bottom of tsconfig files
2018-09-03 23:16:53 -04:00
christian
c87ca2f1ab
Fix diagnostic reporting for empty files in tsconfig
2018-09-03 22:57:26 -04:00
Sheetal Nandi
45101491c0
Merge pull request #26782 from Microsoft/reportFileChangeDetectedOnce
...
Report file change detected only once when save takes place multipletimes before timeout
2018-08-31 15:26:03 -07:00
Ryan Cavanaugh
cbdfc01e25
Merge pull request #26794 from samlanning/fix-equalownproperties
...
Housekeeping: Fix equalOwnProperties
2018-08-31 13:58:25 -07:00
Ryan Cavanaugh
8f8e616f80
Merge pull request #26820 from RyanCavanaugh/resetParameterChanges
...
Reset parameter changes back to pre-fix state
2018-08-31 13:47:38 -07:00
Nathan Shively-Sanders
e6a4e90cae
Update baselines to fix build ( #26822 )
...
We started elaborating more errors in the 3 weeks since this PR was
opened.
2018-08-31 13:39:15 -07:00
Ryan Cavanaugh
183072b30e
Revert #26762 , #26726 , and #26317 in preparation for a clean PR fixing all the issues.
2018-08-31 13:06:22 -07:00
csigs
acc3502490
LEGO: Merge pull request 26816
...
LEGO: Merge pull request 26816
2018-08-31 09:11:09 -07:00
csigs
718c2cce9a
LEGO: check in for master to temporary branch.
2018-08-31 16:10:42 +00:00
Benjamin Lichtman
6ddf75209a
Merge pull request #26749 from uniqueiniquity/getWholeType
...
Use correct type for async refactoring diagnostics
2018-08-31 09:09:25 -07:00
Nathan Shively-Sanders
c929e74310
Add [Constructor]Parameter types to lib.d.ts ( #26243 )
2018-08-31 07:46:16 -07:00
Nathan Shively-Sanders
cc3d011333
Infer this parameters ( #26800 )
...
Previously we didn't. I can't remember why, probably because I
overlooked it in the initial PR.
2018-08-31 07:45:34 -07:00
Anders Hejlsberg
d293b679f6
Merge pull request #26790 from Microsoft/fixWeakObjectRelationCheck
...
Fix weak object relation check
2018-08-30 22:08:44 -07:00
Anders Hejlsberg
f597e2e409
Accept new baselines
2018-08-30 17:33:57 -07:00
Anders Hejlsberg
61b0e1d946
Merge branch 'master' into fixWeakObjectRelationCheck
...
# Conflicts:
# tests/baselines/reference/infiniteConstraints.errors.txt
2018-08-30 17:22:37 -07:00
Benjamin Lichtman
64bbf8925c
Allow for undefined in type
2018-08-30 16:53:46 -07:00
Nathan Shively-Sanders
b687caf3eb
No excess property error for spread properties ( #26798 )
...
That is, properties in an object literal type that came from a spread
assignment never cause an excess property error.
2018-08-30 16:16:58 -07:00
Wesley Wigham
cd37e41d3d
Make finer-grained errors get reported on function arguments ( #26784 )
2018-08-30 15:45:06 -07:00
Sam Lanning
2c41d8b44e
Fix equalOwnProperties
...
equalOwnProperties would incorrectly report two map-like objects as equal in
the case where a property defined in `left` was not defined in `right` and
whose value was considered "equal" to undefined by the equalityComparer.
This bug was found by an alert on LGTM.com
2018-08-30 14:08:24 -07:00
Sam Lanning
65fa0128bb
Add test for ts.equalOwnProperties
2018-08-30 14:08:20 -07:00
Ryan Cavanaugh
2deb3189de
Merge pull request #26788 from ajafff/remove-useless-condition
...
remove useless condition
2018-08-30 13:36:11 -07:00
Nathan Shively-Sanders
d3f96015f1
Fix namespace expando merge ( #26690 )
...
* Allow JSContainers to merge with namespaces
Expando functions marked with JSContainer previously failed to merge
with namespaces. This change adds JSContainer to ValueModuleExcludes,
allowing this kind of merge.
* Improve symbol flags to fix namespace/expando merging
Calls to bindPropertyAssignment now provide which special assignment
kind they originated from. This allows better symbol flags to be set:
1. Property assignments get the FunctionScopedVariable flag, since they are
equivalent to a `namespace` exporting a `var`.
2. Prototype property assignments get the Method flag if the initialiser
is functionlike, and Property otherwise.
3. Prototype assignments get the flag Property.
(3) is still not entirely correct (it's missing the Prototype flag),
but is what existed previously. I'll try adding the Prototype flag to
see whether it changes any baselines.
* Add cross-file merge test
* Update missed baselines
* Namespace declarations are primary for merging purposes
Also, property-assignments go back to being property declarations, not
function-scoped variable declarations
* Revert unneeded changes
* Revert unneeded changes (in a codefix this time)
* Put JSContainer on all assignment declarations
This allows most of the new special-case merge code to go away. It now
uses the JSContainer special-case code, which already exists.
* Missed comment
* Fix extra newline lint
2018-08-30 13:18:50 -07:00
Anders Hejlsberg
a35c49641d
Accept new baselines
2018-08-30 13:13:42 -07:00
Klaus Meinhardt
b2850ee467
remove useless condition
2018-08-30 22:13:39 +02:00
Anders Hejlsberg
a2928b8fd3
Optimize relationship checks for arrays and tuples
2018-08-30 13:13:21 -07:00
Anders Hejlsberg
1fb6f11a88
Accept new baselines
2018-08-30 12:46:40 -07:00
Anders Hejlsberg
316739e1c0
Exclude generic types from weak object checks
2018-08-30 12:46:29 -07:00
Sheetal Nandi
496b18ef5e
Report file change detected only once when save takes place multiple times before timeout
2018-08-30 11:38:34 -07:00
Sheetal Nandi
828279b611
Merge pull request #26777 from Microsoft/recursiveTypeSignatureHelp
...
Add test for signature help with recursive type
2018-08-30 10:41:00 -07:00
Sheetal Nandi
bf6d265b97
Add test for signaure help with recursive type
...
Test for #26155
2018-08-30 10:12:04 -07:00
Tim Schaub
20a2b0cade
Ignore newline and asterisk when parsing JSDoc typedef ( #26775 )
2018-08-30 10:01:33 -07:00
Wenlu Wang
038f665171
fix lookup regression again ( #26762 )
...
* fix lookup regression again
* add test case
2018-08-30 08:48:49 -07:00
Nathan Shively-Sanders
c327ab40bc
Make SymbolFlags.ObjectLiteral a Value ( #26752 )
...
Previously it was a Type
We couldn't think of a way to observe this change since object literals
don't merge with anything. Ideas?
2018-08-30 08:39:39 -07:00
Sheetal Nandi
d5b7edba8a
Merge pull request #26751 from Microsoft/declarationEmitWithComposite
...
Correctly mark visibile nodes when declaration isnt explicitly turned on but composite is true
2018-08-29 22:55:01 -07:00
csigs
a0d61a58bd
LEGO: Merge pull request 26765
...
LEGO: Merge pull request 26765
2018-08-29 21:11:05 -07:00
csigs
d604199602
LEGO: check in for master to temporary branch.
2018-08-30 04:10:39 +00:00
Andy
d37caf1c0d
Remove unnecessary getContainingClass calls ( #26753 )
2018-08-29 17:43:22 -07:00
Andy
cea49dfb0d
Completion for tuple index doesn't need to include quotes ( #26750 )
2018-08-29 16:38:42 -07:00
Andy
f78dc2ad11
importFixes: Only provide a fix using the best module specifier for a given module ( #26738 )
2018-08-29 16:18:56 -07:00
Sheetal Nandi
262fa3ac31
Correctly mark visibile nodes when declaration isnt explicitly turned on but composite is true
...
Fixes #26669
2018-08-29 16:17:24 -07:00
Sheetal Nandi
38a85cfbf4
Add test to verify #26669 where declaration output is incorrect when declaration flag is not set explicitly in options
2018-08-29 16:14:55 -07:00
Benjamin Lichtman
f4765a6ea3
Fix error introduced by rebase
2018-08-29 15:56:22 -07:00
Benjamin Lichtman
bb892d951d
Use non-diagnostics-producing typechecker to get type
2018-08-29 15:54:19 -07:00
Benjamin Lichtman
97e539339d
Add comment explaining special casing
2018-08-29 15:53:34 -07:00
Benjamin Lichtman
3ad6a66e69
Add tests and validate diagnostic spans
2018-08-29 15:53:05 -07:00
Benjamin Lichtman
158f0b0c0b
Allow codefix to apply to function expression in variable declaration
2018-08-29 15:52:35 -07:00
Benjamin Lichtman
cc4e1f833e
Look for correct description
2018-08-29 15:50:34 -07:00
Benjamin Lichtman
d21c078363
Test for existence of diagnostic when running tests
2018-08-29 15:49:48 -07:00
Anders Hejlsberg
a28791565d
Merge pull request #26746 from Microsoft/noUnionInferences
...
Don't infer unions for disjoint callback parameter candidates
2018-08-29 15:45:43 -07:00
