24380 Commits

Author SHA1 Message Date
Anders Hejlsberg
e88f63295b Accept new baselines 2018-07-12 07:07:23 -10:00
Anders Hejlsberg
55180f7725 Add tests 2018-07-12 07:07:13 -10:00
Anders Hejlsberg
87ad612e70 Additional arity check following instantiation of generic rest parameter 2018-07-11 17:26:35 -10:00
Andy
8a559e4630
Improve isNewFile assert (#25419) 2018-07-10 16:57:01 -07:00
Andy
5e2102799b
Reduce non-null assertions in getPropertySymbolsFromContextualType (#24675) 2018-07-10 16:53:08 -07:00
Andy
7a79a45aab
JSX closing tag completion: Include '>' if not already present (#25551)
* JSX closing tag completion: Include '>' if not already present

* Expand comment
2018-07-10 16:14:57 -07:00
Sheetal Nandi
527093c758
Merge pull request #25566 from Microsoft/nonCommonJsResolveJsonIsError
Report errors for module generation other than "commonjs" with --resolveJsonModule
2018-07-10 15:30:23 -07:00
Sheetal Nandi
c50407e01f
Merge pull request #25464 from Microsoft/cacheRecursiveDirectoryWatchers
Caches the recursive directory watchers so we do not have to traverse and recreate more children watches
2018-07-10 15:30:03 -07:00
Sheetal Nandi
4dc3cd3773 Use getEmitModuleKind to check module generation kind 2018-07-10 15:28:21 -07:00
Sheetal Nandi
821ebcb529 Merge branch 'master' into cacheRecursiveDirectoryWatchers 2018-07-10 15:08:14 -07:00
Sheetal Nandi
3866a5048b Report errors for module generation other than "commonjs" with --resolveJsonModule
Fixes #25517
2018-07-10 15:00:46 -07:00
Ron Buckton
a9771e3940
Merge pull request #25556 from Microsoft/buildScriptUpdates
Build script updates
2018-07-10 14:45:16 -07:00
Andy
b6640e9c5d
getJsxClosingTagAtPosition: Return a result if parent has same name and is unclosed (#25557) 2018-07-10 14:31:18 -07:00
Daniel Rosenwasser
3dd1d25e07
Merge pull request #25520 from Microsoft/internalizeNonexistentHelpers
Make getSuggestion APIs internal.
2018-07-10 13:47:05 -07:00
Ron Buckton
0713e754e7 Build script updates 2018-07-10 12:13:27 -07:00
Andy
1fc1495863
Increase span of unreachable code error (#25388)
* Increase span of unreachable code error

* Add a new diagnostic for each range of unreachable statements

* Update baselines
2018-07-10 11:45:16 -07:00
Ryan Cavanaugh
d7ce0eae3a
Merge pull request #25524 from RyanCavanaugh/useGetEmitDeclarations
Use getEmitDeclarations instead of .declarations
2018-07-10 10:59:06 -07:00
Andy
72be7156d2
Support completions for unique symbol exported from module (#25537) 2018-07-10 10:47:43 -07:00
Mohamed Hegazy
4bf42fd1c4
Merge pull request #25535 from Microsoft/fixAsserts
Fix assert and check for module symbol
2018-07-10 10:28:17 -07:00
Nathan Shively-Sanders
c344a3ea5b
Fix bogus use before def in jsdoc (#25532)
Block scoped variables, classes and enums would issue a bogus
use-before-def error in jsdoc because name resolution always adds Value,
even when resolving a type.

Fixes #25097
2018-07-10 08:33:19 -07:00
Nathan Shively-Sanders
60c0dfeb25
Fix crash in JS when checking destructuring shorthand assignment (#25529) 2018-07-10 08:32:56 -07:00
Pi Lanningham
b3b6c3bdbc Pass sourceFile to getChildren in getTokenAtPositionWorker (#25505) (#25538)
For performance reasons, we should always pass sourceFile to getChildren
if available.
2018-07-09 18:15:40 -07:00
Andy
e9e5ebee73
getEditsForFileRename: Handle all projects and source-mapped files (#25522)
* getEditsForFileRename: Handle all projects and source-mapped files

* Update API (#24966)

* Use areEqual
2018-07-09 17:58:02 -07:00
Ryan Cavanaugh
e532f53189
Merge pull request #25531 from RyanCavanaugh/fix25527
Don't crash when an implicit rootDir constraint is violated under composite: true
2018-07-09 17:51:17 -07:00
Mohamed Hegazy
2c70030c8a Compare normalized fileNames 2018-07-09 17:28:10 -07:00
Mohamed Hegazy
68cd382d8f Check for a module sysmbol existing before calling getReferencedSymbolsForModule 2018-07-09 17:26:35 -07:00
Sheetal Nandi
357f0d6fbd
Merge pull request #25521 from Microsoft/dontWatchAmbientModules
Do not watch modules that get resolved by ambient modules
2018-07-09 17:02:33 -07:00
Wesley Wigham
3d64b9d7ac
Handle intersection types when looking up base types for visibility (#25418)
* Handle intersection types when looking up base types for visibility

* Extract protected constructor check to function and recur on intersections

* Remove unneeded cast
2018-07-09 16:58:55 -07:00
Ryan Cavanaugh
72f0789908 Don't crash when an implicit rootDir constraint is violated under composite:true
Fixes #25527
2018-07-09 15:41:15 -07:00
Mohamed Hegazy
6b4a3b2bbb
Merge pull request #25500 from mattmccutchen/issue-25498
Fix crash in elaborateElementwise when the target property is known but it doesn't have a declaration (e.g., in a mapped type).
2018-07-09 15:35:35 -07:00
Ryan Cavanaugh
1b1ffe952b Use getEmitDeclarations instead of .declarations 2018-07-09 14:51:40 -07:00
Sheetal Nandi
f941226011 Do not watch modules that get resolved by ambient modules 2018-07-09 12:05:29 -07:00
Daniel Rosenwasser
d62717b281 Make getSuggestion APIs internal. 2018-07-09 11:42:38 -07:00
Benjamin Lichtman
b5f5513e4a
Merge pull request #25329 from uniqueiniquity/jsxFolding
Add outlining spans for JSX elements
2018-07-09 12:36:23 -04:00
Benjamin Lichtman
5c7b47e6e3 Pass sourceFile as appropriate 2018-07-09 08:54:57 -07:00
Daniel Rosenwasser
fe2baac33f
Merge pull request #25422 from Microsoft/actualSignatureHelpTriggers
Actual signature help trigger filtering
2018-07-08 22:09:35 -07:00
Matt McCutchen
d5fd17bf0b Fix crash in elaborateElementwise when the target property is known but
it doesn't have a declaration (e.g., in a mapped type).

Fixes #25498.
2018-07-07 16:27:23 -04:00
Nathan Shively-Sanders
10b174abc1
Fix lineText in references command (#25494)
Previously it was just the identifier text. Now it is back to the full
text of the line.
2018-07-06 16:23:11 -07:00
Wesley Wigham
403df45678
Rework entity name decorator metadata fallback emit to not throw at runtime (#25421)
* Rework entity name decorator metadata fallback emit to not throw at runtime

* Remove trailing whitespace
2018-07-06 15:18:03 -07:00
Wesley Wigham
831be5d078
Introduce truncation into node builder and symbol display part writer (#24258)
* Introduce truncation into node builder and symbol display part writer

* Change default maxa truncation length to 240

* Fancy truncation + higher hard limit
2018-07-06 14:58:46 -07:00
Wesley Wigham
547856a11d
Strip literal freshness from type queries (#25471)
* Strip literal freshness from type queries

* Rename to fix typo
2018-07-06 13:07:29 -07:00
Daniel Rosenwasser
ea73ee7fd7
Merge pull request #25477 from Microsoft/youProbablyMeantThisDeclaration
Link back to likely declarations in "did you mean...?" error messages
2018-07-06 12:03:10 -07:00
Daniel Rosenwasser
1d7c9540c5 Update 'package-lock.json'. 2018-07-06 11:35:08 -07:00
Daniel Rosenwasser
428f1de5bd Semicolon. 2018-07-06 11:28:50 -07:00
Nathan Shively-Sanders
6589e867fe
getJSDocReturnType gets return type from @type tags (#25486)
* get return type from `@type` tags

Previously, getJSDocReturnType did not check the `@type` tag for a type
node that has a return type. Now it does.

* Improve doc comment of getJSDocReturnType

* More type predicates in type guards!

* Update API baselines with new documentation (?!)
2018-07-06 10:46:43 -07:00
Nathan Shively-Sanders
c228924543
Index signatures contribute properties to unions (#25307)
* Index signatures contribute properties to unions

This means that in a union like this:

```ts
type T = { foo: number } | { [s: string]: string }
```

`foo` is now a property of `T` with type `number | string`. Previously
it was not.

Two points of interest:

1. A readonly index signature makes the resulting union property readonly.
2. A numeric index signature only contributes number-named properties.

Fixes #21141

* Correctly handle numeric and symbol property names

1. Symbol-named properties don't contribute to unions.
2. Number-named properties should use the numeric index signature type,
if present, and fall back to the string index signature type, not the
other way round.
2018-07-06 10:46:05 -07:00
Mohamed Hegazy
fd007e747d
Merge pull request #25341 from ajafff/factory-export-default
createExportAssignment: parenthesize nested class or function expression
2018-07-06 10:33:34 -07:00
Daniel Rosenwasser
b706adb3dc Merge remote-tracking branch 'origin/master' into youProbablyMeantThisDeclaration 2018-07-06 10:26:58 -07:00
Nathan Shively-Sanders
1785041b8c
make getEffectiveTypeParameterDeclarations public (#25472) 2018-07-06 10:26:53 -07:00
TypeScript Bot
bb57c5a6b2 Update user baselines (#25482) 2018-07-06 08:43:59 -07:00