mihailik
e7e020e958
PR feedback - comments and whitespace adjustments
2015-06-26 14:38:25 +01:00
mihailik
133a86a377
Conflict with Object.prototype.watch in FireFox/Gecko
...
In Gecko engine `commandLine.options.watch` evaluates to a truthy value (a function). Adding an extra check to work around.
[Definition of CompilerOptions.watch in compiler/types](https://github.com/Microsoft/TypeScript/blob/master/src/compiler/types.ts#L1860 )
``` typescript
export interface CompilerOptions {
// . . .
watch?: boolean;
```
[Object.prototype.watch on MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/watch )
> Warning: Generally you should avoid using watch() and unwatch() when possible. These two methods are
> implemented only in Gecko, and they're intended primarily for debugging use. In addition, using watchpoints
> has a serious negative impact on performance, which is especially true when used on global objects, such
> as window. You can usually use setters and getters or proxies instead. See Browser compatibility for details.
> Also, do not confuse Object.watch with Object.observe.
2015-06-26 09:22:55 +01:00
Mohamed Hegazy
d695afa102
Merge pull request #3635 from DickvdBrink/format-default
...
Fixed formatting on default keyword
2015-06-25 12:04:48 -07:00
Dick van den Brink
de2d532b1f
Added test for formatting on default keyword
2015-06-25 20:49:25 +02:00
Dick van den Brink
627ebc86eb
Fixed formatting spaces on default keyword
2015-06-25 20:47:40 +02:00
Daniel Rosenwasser
b76743857c
Merge pull request #3632 from Microsoft/fixTestCommentAndName
...
Fix test comment and name of test
2015-06-25 14:15:56 -04:00
Daniel Rosenwasser
ec2d5f3a0d
Renamed test.
2015-06-25 13:38:42 -04:00
Daniel Rosenwasser
eda3956fa2
Accepted baselines.
2015-06-25 13:34:31 -04:00
Daniel Rosenwasser
c04bc692d4
Fixed coment.
2015-06-25 13:21:58 -04:00
Daniel Rosenwasser
52e8b6cbbc
Merge pull request #3631 from Microsoft/externamEtc
...
Correct/improve names of certain fourslash tests
2015-06-25 12:59:27 -04:00
Daniel Rosenwasser
926c25e38b
No more 'scriptLexicalStructure'.
2015-06-25 12:14:59 -04:00
Daniel Rosenwasser
6732acaa32
Underscore typings.
2015-06-25 12:10:09 -04:00
Daniel Rosenwasser
f734055ee7
externam -> external
2015-06-25 12:06:13 -04:00
Daniel Rosenwasser
816cfe3ec6
Merge pull request #3615 from Microsoft/completionsInObjectPatterns
...
Enable completions in object binding patterns
2015-06-24 22:53:53 -04:00
Mohamed Hegazy
560dbd98f1
Merge pull request #3621 from DickvdBrink/unused-vars
...
Remove unused variables
2015-06-24 16:20:02 -07:00
Dick van den Brink
2a483187a7
Remove unused variables
2015-06-25 00:23:13 +02:00
Daniel Rosenwasser
e52a27b3de
Renamed function.
2015-06-24 18:07:49 -04:00
Mohamed Hegazy
b754cc1c73
Merge branch 'jbondc-minor-3'
2015-06-24 15:02:41 -07:00
Mohamed Hegazy
14f7dd02d7
Revert changes to the parser and augment check to the emitter to handel '1..toString' case
2015-06-24 15:02:20 -07:00
Daniel Rosenwasser
84ff2f8d47
Merge pull request #3617 from DickvdBrink/format-protected
...
Format after protected modifer
2015-06-24 17:39:07 -04:00
Dick van den Brink
822199f40a
Added test for formatting on protected modifier
2015-06-24 23:26:22 +02:00
Dick van den Brink
4853fd0267
Fixed formatting spaces on protected keyword
2015-06-24 23:26:13 +02:00
Daniel Rosenwasser
02e01d7afc
Added tests.
2015-06-24 17:13:47 -04:00
Daniel Rosenwasser
3d8650cd0a
Merge pull request #3601 from Microsoft/emptyBindingPatternParam
...
Emit valid code when a parameter's binding pattern has no elements
2015-06-24 16:50:27 -04:00
Daniel Rosenwasser
559c9b039b
Merge pull request #3614 from Microsoft/tsServerBuildDependencies
...
Add services sources as dependencies to tsserver.
2015-06-24 16:49:01 -04:00
Mohamed Hegazy
464f65533e
Merge branch 'minor-3' of https://github.com/jbondc/TypeScript into jbondc-minor-3
2015-06-24 12:59:06 -07:00
Mohamed Hegazy
cc4511d9a1
Update LKG
2015-06-24 12:48:35 -07:00
Mohamed Hegazy
3a989060fb
Merge branch 'release-1.5'
...
Conflicts:
bin/tsc.js
bin/tsserver.js
bin/typescript.js
bin/typescriptServices.js
2015-06-24 12:42:30 -07:00
Mohamed Hegazy
01f6366c95
Merge branch 'SaschaNaz-blockFormParameterIndentation'
2015-06-24 11:55:48 -07:00
Mohamed Hegazy
36a30c42b5
Rename functions and variables, also a small refactoring.
2015-06-24 11:53:53 -07:00
Mohamed Hegazy
20b4b7f45d
Merge pull request #3611 from tinganho/goToDefinitionTypePredicate
...
Go to definition for type predicate
2015-06-24 10:12:44 -07:00
Ron Buckton
4645a5b645
Merge pull request #3249 from Microsoft/resolveDecoratorAsCall
...
Migrated decorator checks to call resolution
2015-06-24 09:58:24 -07:00
Daniel Rosenwasser
713a70d794
Renamed tests.
2015-06-24 12:39:10 -04:00
Daniel Rosenwasser
d892a55aa9
Use 'propertyName' when available in a BindingPattern.
2015-06-24 12:35:11 -04:00
Daniel Rosenwasser
d3c59f4cc2
Added more tests.
2015-06-24 12:33:49 -04:00
Daniel Rosenwasser
f9ed47a1bb
Add the services sources as dependencies to tsserver.
2015-06-24 12:28:54 -04:00
Daniel Rosenwasser
498d06f6c0
Got filtering working in object binding patterns.
2015-06-24 11:41:59 -04:00
Daniel Rosenwasser
c114de1a83
Basic completion in object destructuring working.
2015-06-24 11:31:36 -04:00
Daniel Rosenwasser
513d73ad4b
Don't print in the middle of tests.
2015-06-24 11:30:10 -04:00
Daniel Rosenwasser
c6498d79e5
Changed ordering of verifications.
2015-06-24 11:29:05 -04:00
jbondc
8ae53a4310
Accept baselines (missing files).
2015-06-24 11:21:48 -04:00
jbondc
71dc7a5947
Accept baselines
2015-06-24 11:08:54 -04:00
jbondc
da1bc6bac8
Don't report an error for 1.toString(), just emit a space for JS compat.
2015-06-24 10:56:23 -04:00
Tingan Ho
cb9f80f1aa
Remove space and s
2015-06-24 11:32:30 +08:00
Tingan Ho
1d04545342
Changed symbolflag
2015-06-24 11:00:48 +08:00
Tingan Ho
485e319057
Accept baselines
2015-06-24 10:48:22 +08:00
Tingan Ho
2aceeea064
Fixes goto definitions for type predicates
2015-06-24 10:37:23 +08:00
Mohamed Hegazy
72aeb3c208
Merge pull request #3547 from Microsoft/updateMapDeclaration
...
Add a non-generic construct signature to Map, Set, and WeakMap
2015-06-23 17:38:49 -07:00
Anders Hejlsberg
c5567490c6
Merge pull request #3568 from Microsoft/classExpressions
...
Class expressions
2015-06-23 17:21:35 -07:00
Anders Hejlsberg
55f195d445
Another change suggested in CR
2015-06-23 17:06:47 -07:00
