Arthur Ozga
e7d2af0d72
remove duplicate verify
2017-08-17 20:06:34 -07:00
Arthur Ozga
760ef44c36
test if onlyMultiLine flag changes answer
2017-08-16 18:48:27 -07:00
Arthur Ozga
6029b5cce8
cleanup
2017-08-16 18:12:28 -07:00
Arthur Ozga
19e2fa6fc5
Merge branch 'master' into isInMultiLineComment
2017-08-16 17:57:04 -07:00
Arthur Ozga
b7bc7d889e
clarify JsxText handling
2017-08-16 17:56:20 -07:00
Arthur Ozga
23ca368020
Use simpler indentation for comments
...
* When in a multi-line comment, we would have liked to use the start of
the comment as a reference point for the indentation inside the comment,
but determining the number of columns shifted for the comment start
woudl require determining the length w/r/t graphemes, which we do not
currently implement. We would like to avoid taking on a runtime
dependency on a grapheme-parsing library.
Instead, we look at the indentation level on the previoud line or start
of the comment as a reference point, and correct shift for lines
starting with an asterisk.
2017-08-16 17:51:29 -07:00
Arthur Ozga
62f16bee55
add tests
2017-08-16 17:36:50 -07:00
Arthur Ozga
4b9f5a0f8f
rename tests
2017-08-16 17:36:39 -07:00
Arthur Ozga
70e4f346bb
update test
2017-08-16 17:35:14 -07:00
Arthur Ozga
153b94aeb4
JsxText has no leading comments
2017-08-16 15:28:47 -07:00
Andy
d4fecd4e46
Have grammarErrorAtPos take the source file of its argument ( #17834 )
2017-08-16 14:48:58 -07:00
Andy
9bcbc97e14
Replace 'isSourceFileJavaScript(getSourceFileOfNode())' with 'NodeFlags.JavaScriptFile' ( #17835 )
2017-08-16 14:48:46 -07:00
Andy
54af8aa945
Array arguments to concat should be ReadonlyArrays ( #17806 )
2017-08-16 14:32:14 -07:00
Tycho Grouwstra
76fb6545a5
fix some copy-pasting error ( #17766 )
...
* fix some copy-pasting error
* update to reflect @ahejlsberg's feedback
2017-08-16 11:49:24 -07:00
Nathan Shively-Sanders
146f828919
Merge pull request #17710 from Microsoft/add-readonly-check-to-property-access-of-index-signature
...
Add readonly check to property access of index signature
2017-08-16 11:16:54 -07:00
Nathan Shively-Sanders
7809398ad4
Indexed-assignment readonly err is not unknownType
...
Now, in an assignment to an indexed access of a readonly property, the
resulting type is still the property's type. Previously it was
unknownType. This improves error reporting slightly by reporting some
errors that were previously missed.
2017-08-16 10:06:01 -07:00
Andy
34a55899be
Remove unnecessary call to getApparentType ( #17788 )
2017-08-16 10:04:51 -07:00
Anders Hejlsberg
ce2ac1751e
Merge pull request #17771 from Microsoft/fixCircularContextualType
...
Fix circular contextual return type error
2017-08-16 09:17:15 +02:00
Arthur Ozga
ad9c29b928
add test
2017-08-15 12:44:21 -07:00
Andy
93abebc04a
Change function name to camelCase ( #17751 )
2017-08-15 12:26:00 -07:00
Arthur Ozga
a08d18af57
consolidate isInComment and getRangeOfEnclosingComment
2017-08-15 12:09:43 -07:00
Arthur Ozga
a209db7bb6
dont compute preceding token twice
2017-08-15 12:09:02 -07:00
Arthur Ozga
f3e0cbbd52
findPrecedingToken handles EOF child more gracefully
2017-08-15 12:09:02 -07:00
Arthur Ozga
472ad9d313
findPrevious changes
2017-08-15 12:08:00 -07:00
Arthur Ozga
b2188ad66c
cleanup
2017-08-15 12:08:00 -07:00
Ryan Cavanaugh
eb8f7bddc2
Merge pull request #17796 from basarat/patch-1
...
Fix build 🌹
2017-08-15 11:06:33 -07:00
Andy
7409648416
Remove unused UseTypeAliasValue flag ( #17779 )
2017-08-15 10:24:15 -07:00
Andy
10c8d5effa
In services, show the aliasSymbol for a type even if it's not accessible in the current scope ( #17433 )
...
* In services, show the aliasSymbol for a type even if it's not accessible in the current scope
* Rename flag
2017-08-15 10:23:45 -07:00
Basarat Ali Syed
c4dd820564
export interfaces used by exported functions 🌹
2017-08-15 15:19:40 +10:00
Basarat Ali Syed
e7ddaa7d49
export ScopeUsages 🌹
2017-08-15 15:17:19 +10:00
Andy
80a7ed9a42
Fixes to session's handling of empty results ( #17728 )
...
* Fixes to session's handling of empty results
* Fix emptyArray -> undefined
2017-08-14 13:42:15 -07:00
Wesley Wigham
e2f35ecead
Accept missing baseline updates for #13721
2017-08-14 13:23:22 -07:00
Anders Hejlsberg
a1cbeb2eca
Merge pull request #17767 from tycho01/15768-generic-numeric-index-error
...
loosen number index check, fixes #15768
2017-08-14 19:02:06 +02:00
Andy
543e0affff
Make exportSymbol public ( #17457 )
...
* Make exportSymbol public
* Add a `getExportSymbolOfSymbol` method
* Use own implementation instead of delegating to `getExportSymbolOfValueSymbolIfExported`
2017-08-14 09:20:48 -07:00
Daniel Rosenwasser
ea7c7d3467
Merge pull request #16631 from Microsoft/fix13721
...
Emit class annotation comment on downlevel classes
2017-08-14 10:33:41 -04:00
Tycho Grouwstra
4268e13cde
simplify fix as suggested by @ahejlsberg
2017-08-14 17:45:18 +08:00
Anders Hejlsberg
57705fc4e0
Add regression test
2017-08-14 09:08:11 +02:00
Anders Hejlsberg
dacc851434
No contextual return type when type is circular
2017-08-14 09:01:50 +02:00
Tycho Grouwstra
1d6863ab0b
loosen number index check, fixes #15768
2017-08-14 02:18:47 +08:00
Wesley Wigham
d03d1074ee
Make compiler options which map to a flag case-insensitive again ( #17755 )
2017-08-11 19:59:43 -07:00
Ron Buckton
360dc914c3
Merge pull request #17602 from Microsoft/multiInferredProjects
...
Adds support for inferred project isolation by projectRootPath
2017-08-11 16:06:49 -07:00
Ron Buckton
c272c3c5cd
Comment update
2017-08-11 16:06:24 -07:00
Ron Buckton
95ee9aef0f
Merge pull request #17750 from Microsoft/importFixInferQuote
...
Add support to infer the quote style for import code fix
2017-08-11 15:52:38 -07:00
Ron Buckton
09487b8a1d
Added tests, pr feedback
2017-08-11 15:31:09 -07:00
Ron Buckton
e3b6df64b3
Add support to infer the quote style for import quick fixes
2017-08-11 14:26:25 -07:00
Yui
d352e3b03f
[Master] fix 16407 - LS in binding element of object binding pattern ( #16534 )
...
* wip-try get symbol of bindingelement in objectBindingPattern first
* Add fourslash tests
* Update .types baselines
* Update .symbols baselines
* Revert checker changes
* Actually lookup type for binding property name definition
* More succinct check, clarify yui's comment
2017-08-11 11:14:59 -07:00
Wesley Wigham
c92deef6ec
Fix runtests-browser with latest node ( #17735 )
...
* Fixes for running tests in the browser with the latest node
* Make memoize safe
* Integrate PR feedback, require key func on memoize
2017-08-11 10:58:38 -07:00
Ryan Cavanaugh
c110ecb870
Merge pull request #17625 from RyanCavanaugh/extract-method-2
...
Extract Method
2017-08-11 10:54:48 -07:00
Andy
f64b8ad902
Add "preserveSymlinks" option ( #16661 )
...
* Add "preserveSymlinks" option
* Respond to PR comments
2017-08-11 10:03:21 -07:00
Andy
b3f3f336ad
Use hasModifier and hasModifiers helper functions ( #17724 )
2017-08-11 07:15:15 -07:00
