19274 Commits

Author SHA1 Message Date
Anders Hejlsberg
2256f9159f Fix typo 2019-01-16 09:46:02 -08:00
Anders Hejlsberg
db840f41c5 Update array/tuple relationship checking 2019-01-15 14:44:38 -08:00
Anders Hejlsberg
bb8378fddf Support 'readonly' type modifier on array and tuple types 2019-01-15 09:43:39 -08:00
Anders Hejlsberg
903863a87a Respect readonly mapped type modifier when mapping arrays and tuples 2019-01-12 08:45:05 -08:00
Anders Hejlsberg
52b82560e8
Merge pull request #29338 from Microsoft/fixConditionalTypeResolution
Fix conditional type resolution
2019-01-09 17:18:12 -08:00
Anders Hejlsberg
70148a4b55 Improve logic that determines when to resolve conditional types 2019-01-09 16:10:28 -08:00
Wesley Wigham
d0aff9bdcd
Fix crash (#29333) 2019-01-09 14:23:57 -08:00
Sheetal Nandi
387be1fffa
Merge pull request #29316 from Microsoft/randomIdentifier
Verify that completion with new identifier location returns isNewIdentifierLocation: true
2019-01-09 13:01:22 -08:00
Daniel Rosenwasser
6bfb935929
Merge pull request #25445 from a-tarasyuk/bug/24542-bad-error-message-for-import-ing-an-export
24542 - bad error message for `import *`-ing an `export=`
2019-01-09 11:02:14 -08:00
Klaus Meinhardt
b52a7fc3ea Exclude JSDoc @extends from 'super()' checks (#29308)
* Exclude JSDoc @extends from 'super()' checks

This fixes a similar problem as #29244 where JSDoc `@extends`

* fix check 'super can only be referenced in a derived class'
2019-01-09 10:35:22 -08:00
Sheetal Nandi
85e6c2f8ab
Merge pull request #26280 from Microsoft/tsconfig_canonicalpath
getScriptInfoOrConfig: Canonicalize tsconfig path before lookup
2019-01-08 16:33:34 -08:00
Sheetal Nandi
4c70bf0292
Merge pull request #29313 from Microsoft/getEditsForRename
There is no need to check for file presence when trying to rename imports based on file rename
2019-01-08 16:24:51 -08:00
Sheetal Nandi
46482e14a4 Verify that completion with new identifier location returns isNewIdentifierLocation: true
Fixes #24009

Signed-off-by: Sheetal Nandi <shkamat@microsoft.com>
2019-01-08 16:21:46 -08:00
Sheetal Nandi
76c9d9f717 Fix the failing test case 2019-01-08 16:08:43 -08:00
Sheetal Nandi
1870ee4099 Merge branch 'master' into tsconfig_canonicalpath 2019-01-08 16:04:22 -08:00
Sheetal Nandi
08f738fc42 There is no need to check for file presence when trying to rename imports based on file rename
Fixes #29031
2019-01-08 15:18:52 -08:00
Wesley Wigham
19c72c758a
Allow untyped calls on unions of untyped things (#29265) 2019-01-08 11:05:55 -08:00
Alexander T
52057ac4f6 Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/24542-bad-error-message-for-import-ing-an-export 2019-01-08 10:55:11 +02:00
Alexander T
945eed8d9b PR feedback: change error #2497 message 2019-01-08 10:54:08 +02:00
csigs
ec5224f114 LEGO: check in for master to temporary branch. 2019-01-07 16:10:20 +00:00
Sheetal Nandi
93249db692 Use the sourceFile to determine the jsxNamespace at the location for organizingImports
Fixes #28827
2019-01-04 14:12:04 -08:00
Martin Probst
7a2b2cebbf Do not emit code for @extends tags in JS. (#29244)
When transpiling JavaScript, TS3.1+ emits `@extends` tags as code. E.g.

    /** @extends {SuperClass} */
    class SubClass {}

Causes an ES5 emit that references SuperClass:

    /**
    * @extends {SomeBase}
    */
    var SubClass = /** @class */ (function (_super) {
        __extends(SubClass, _super);
        function SubClass() {
            return _super !== null && _super.apply(this, arguments) || this;
        }
        return SubClass;
    }(SomeBase));

Note the literal references to `SomeBase`.

This appears to be an accidental effect of 0f55566cf4. It refactored
`getEffectiveBaseTypeNode` for type checking, but missed an instance
where it is also used for emit logic. This change fixes the problem by
specifically getting the heritage clauses directly off the AST.

Change-Id: I3128a757e5924e2528c61230a90ac13650852542
2019-01-04 08:13:14 -08:00
Sheetal Nandi
b7d7d5f7b3
Merge pull request #29252 from Microsoft/tscWatchIsolatedModules
Do not cache semantic diagnostics with --isolated modules
2019-01-03 14:35:19 -08:00
Sheetal Nandi
a633f95da7 Do not cache semantic diagnostics with --isolated modules
Fixes #28332
2019-01-03 14:07:25 -08:00
Sheetal Nandi
bce9e2c11c
Merge pull request #29250 from Microsoft/hasContextSensitiveReturnExpression
Fix function declaration without body to be checked as context sensitive
2019-01-03 14:06:13 -08:00
Sheetal Nandi
f4a6fb79da Replace ternary expression 2019-01-03 13:29:43 -08:00
Sheetal Nandi
d8ee4116ef Fix function declaration without body to be checked as context sensitive
Fixes #29032
2019-01-03 12:46:39 -08:00
Sheetal Nandi
c426fc6868 Merge branch 'master' into tscWatchExportUpdate 2019-01-03 11:35:54 -08:00
Sheetal Nandi
d35ea02cc6
Merge pull request #29247 from ajafff/organizeimports-crash
Fix crash in organizeImports
2019-01-03 08:54:34 -08:00
Klaus Meinhardt
6a9ad0e2eb Fix crash in organizeImports
Fixes: #29236
2019-01-03 16:20:46 +01:00
Sheetal Nandi
24cc284d19 The assert that cached value of config file existance is always correct, might not be true if file watcher is not invoked before creating configured project
Fixes #29191
2019-01-02 15:42:12 -08:00
Benjamin Lichtman
799656a037
Merge pull request #29214 from uniqueiniquity/nestedAsyncCodeFix
Only provide suggestion for outermost async fix
2018-12-31 17:18:39 -08:00
Benjamin Lichtman
11585d29bc
Merge pull request #29218 from uniqueiniquity/jsdocSpanForVarStatement
Jsdoc span for var statement
2018-12-31 16:27:34 -08:00
Benjamin Lichtman
cb57f17aba Simplify approach 2018-12-31 16:25:26 -08:00
Benjamin Lichtman
28e68a6891 Fix spelling of convertible 2018-12-31 16:00:24 -08:00
Benjamin Lichtman
048d04684b use existing util functions 2018-12-31 15:56:54 -08:00
Benjamin Lichtman
aebcb6df36
Merge pull request #29216 from uniqueiniquity/multilineArgumentSpans
Give appropriate outlining span for array and object literals as args in call expression
2018-12-31 15:18:07 -08:00
Benjamin Lichtman
34970d8a69 give jsdoc outline span before func exp assigned to var 2018-12-31 15:10:22 -08:00
Benjamin Lichtman
6c34520281 Use normal start for spans for args 2018-12-31 14:37:31 -08:00
Benjamin Lichtman
b466336a3e Add class expression to set of nodes for outlining 2018-12-31 14:04:48 -08:00
Benjamin Lichtman
2dd6e20ef9 Only provide suggestion for outermost async fix 2018-12-31 11:50:40 -08:00
Daniel Rosenwasser
0dbb9760c0
Merge pull request #29147 from Kingwl/type_query_completions
fix typeof completions broken
2018-12-31 10:36:39 -08:00
Anders Hejlsberg
beebda3574
Merge pull request #29110 from Microsoft/fixDiscriminantCheck
Fix discriminant property check
2018-12-30 17:46:01 -10:00
Anders Hejlsberg
8570a67572
Merge pull request #29121 from Microsoft/mappedTypeConstraints
Improve constraints for non-homomorphic mapped types
2018-12-30 17:44:41 -10:00
Anders Hejlsberg
fd3af78b8b
Merge pull request #29179 from Microsoft/typeParameterDefaultForwardReference
No self or forward references in type parameter defaults
2018-12-30 17:43:57 -10:00
Anders Hejlsberg
8e1403144d
Merge pull request #29192 from Microsoft/initializerWidening
Fix initializer widening
2018-12-28 17:15:36 -10:00
Anders Hejlsberg
0165e80e7c Don't widen contextually typed literals in initializer expressions 2018-12-28 09:30:14 -10:00
Benjamin Lichtman
c46090b8dc Show template literal in navtree function call args 2018-12-27 17:43:56 -08:00
Anders Hejlsberg
3f7a9a906b Type parameter defaults can only reference previously declared type parameters 2018-12-27 13:45:13 -10:00
王文璐
7c93affd7d fix typeof completions broken 2018-12-25 17:30:04 +08:00