microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 12:51:30 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #29316 from Microsoft/randomIdentifier

Browse Source 
Verify that completion with new identifier location returns isNewIdentifierLocation: true
This commit is contained in:
Sheetal Nandi
2019-01-09 13:01:22 -08:00
committed by GitHub
parent 6bfb935929 3f5c0b81a3
commit 387be1fffa
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
completionAtDottedNamespace.ts Normal file
View File

@@ -0,0 +1,5 @@
/// <reference path='fourslash.ts'/>
////namespace wwer./**/w
verify.completions({ marker: "", exact: [], isNewIdentifierLocation: true });

2
src/services/completions.ts
View File

@@ -104,7 +104,7 @@ namespace ts.Completions {
getJSCompletionEntries(sourceFile, location!.pos, uniqueNames, compilerOptions.target!, entries); // TODO: GH#18217
}
else {
if ((!symbols || symbols.length === 0) && keywordFilters === KeywordCompletionFilters.None) {
if (!isNewIdentifierLocation && (!symbols || symbols.length === 0) && keywordFilters === KeywordCompletionFilters.None) {
return undefined;
}

2
tests/cases/fourslash/completionListBuilderLocations_Modules.ts
View File

@@ -7,5 +7,5 @@
verify.completions(
{ marker: "moduleName1", exact: completion.globals, isNewIdentifierLocation: true },
{ marker: "moduleName2", exact: undefined },
{ marker: "moduleName2", exact: [], isNewIdentifierLocation: true },
);