Commit Graph

20066 Commits

Author SHA1 Message Date
Anders Hejlsberg
bb8378fddf Support 'readonly' type modifier on array and tuple types 2019-01-15 09:43:39 -08:00
Sheetal Nandi
520e33fa51 PR feedback 2019-01-14 18:15:54 -08:00
Andrew Casey
b86cb27d0b Fix trailing whitespace 2019-01-14 18:13:13 -08:00
Ron Buckton
208148d05c Fix crash in getTextOfPropertyName 2019-01-14 17:47:52 -08:00
Andrew Casey
104434182b Harden telemetryOnOpenFile against disabled projects
As for syntax-only servers, we can't meaningfully report open-file
telemetry for projects with disabled language services.

Hopefully, a deeper fix will follow, but this solves the immediate
problem that VS disables the LS for all projects when it sees a failure
in applyChangedToOpenFiles (because it assumes the server state is
corrupt).
2019-01-14 17:43:06 -08:00
Ron Buckton
5763e2c3d4 Remove overzealous simple relationship check for unique symbols 2019-01-14 17:08:04 -08:00
Benjamin Lichtman
2c50ed3089 Respond to CR 2019-01-14 17:05:25 -08:00
Sheetal Nandi
d53619a30d Merge pull request #29418 from Microsoft/exportEquals
Handle generating action for export equals with anonymous symbol
2019-01-14 16:12:32 -08:00
Sheetal Nandi
6e54cbdaff Handle generating action for export equals with anonymous symbol
Fixes #28845
2019-01-14 15:32:13 -08:00
Sheetal Nandi
e745fca413 Fix typo 2019-01-14 14:35:05 -08:00
Josh Goldberg
38e1856945 Accepted 'witness' baselines; removed unnecessary !== 2019-01-14 17:30:42 -05:00
Sheetal Nandi
d69b2ea448 Merge pull request #29380 from Microsoft/sourceMap
Use the SourceMapSource to get line and column instead of current source file
2019-01-14 14:30:27 -08:00
Sheetal Nandi
ff97d86cfa Fix typo 2019-01-14 14:00:22 -08:00
Wesley Wigham
3d2bf6a75f Fix implement interface quickfix import types (#29410)
* Pass module specifier resolution host thru types constructed by implements quickfixes

* Add regression test

* Fix scope node for generated methods, fix lints
2019-01-14 13:56:27 -08:00
Wesley Wigham
dc0f4afe5e Save & recalculate declare flag modifier on late printed statements (#29412)
* Save & recalculate declre flag modifier on late printed statements

* Accept related baseline updates
2019-01-14 13:53:04 -08:00
Sheetal Nandi
3943588793 CompilerHostLikeForCache rename 2019-01-14 12:48:22 -08:00
Sheetal Nandi
c909becdd5 Rename indexing variable 2019-01-14 12:44:37 -08:00
Sheetal Nandi
d4055a3234 Merge pull request #26017 from ajafff/rest-param-destructuring
allow BindingPattern in FunctionRestParameter
2019-01-14 10:58:19 -08:00
Gabriela Britto
e5708e1903 Merge pull request #29352 from Microsoft/qualified-name-param-tag-error
Qualified name param tag error
2019-01-14 10:28:08 -08:00
Josh Goldberg
cd88f6a319 Added error for class properties used within their own declaration
Fixes #5987.

Usages of a class property in a preceding property already gave an error, but the following doesn't yet:

```ts
class Test {
    x: number = this.x;
}
```

As with other use-before-declare checking, IIFEs are not treated as invalid uses.
2019-01-13 13:30:58 -05:00
Anders Hejlsberg
903863a87a Respect readonly mapped type modifier when mapping arrays and tuples 2019-01-12 08:45:05 -08:00
Alexander
ba94fd9e05 Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/28086 2019-01-12 08:39:06 +02:00
Benjamin Lichtman
c88016d397 Fix comment 2019-01-11 14:52:47 -08:00
Sheetal Nandi
d1061579d3 Merge branch 'master' into sourceMap 2019-01-11 14:47:24 -08:00
Benjamin Lichtman
d029fae35c Add user preference to opt-in to renaming import paths 2019-01-11 14:45:08 -08:00
Sheetal Nandi
c1edbb8522 Merge branch 'master' into incrementalBuild 2019-01-11 14:34:45 -08:00
Wesley Wigham
fadd95f72b Fix unneeded cast lints (#29383) 2019-01-11 14:24:49 -08:00
Sheetal Nandi
9f19c06dbf Merge pull request #29372 from JoshuaKGoldberg/codefix-enable-decorators
Added codefix to enable experimentalDecorators in the user's config file
2019-01-11 12:45:28 -08:00
Sheetal Nandi
021c63f1c3 Use the SourceMapSource to get line and column instead of current source file
Fixes #29300
2019-01-11 12:24:33 -08:00
Sheetal Nandi
b23664adf7 Test to verify external source map range addition 2019-01-11 12:23:24 -08:00
Alexander
d5f5d7347e Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/28086 2019-01-11 22:21:02 +02:00
Alexander
a076417837 remove unused error message 2568 2019-01-11 22:13:29 +02:00
Josh Goldberg
7b6adae6dd Extracted compilerOptions setting to helper function 2019-01-11 15:05:24 -05:00
Sheetal Nandi
fb99d552ea Merge pull request #29022 from mprobst/no-resolve-libref
Do not process library reference directives with noLib set.
2019-01-11 09:03:46 -08:00
Josh Goldberg
8d28f9230c Added codefix to enable experimentalDecorators in the user's config file
Starts on #29035 by creating a codefix to enable the `experimentalDecorators` setting in a user's config file, if one exists. The issue's discussion also mentions giving a more precise error message if the user has a jsconfig or tsconfig or creating one if not; I'd rather tackle those in separate PRs to keep this one small.

Doesn't create the code action if no config file is present. Otherwise keeps to the precedent of returning without action when the config file contents aren't the expected JSON structure (looking at `fixCannotFindModule.ts`).  Moves a couple JSON helpers from that file into the sibling `helpers.ts` so both codefixes can use them.
2019-01-11 09:20:12 -05:00
Martin Probst
11b150129a Do not process library reference directives with noLib set.
When a user sets `noLib`, this indicates that they will supply their own
list of `lib*.d.ts` files as part of input sources. In this situation,
TypeScript should not try to resolve library reference directives.

This avoids a problem where TypeScript loads a file that e.g. contains
`/// <reference lib="es2015.symbol"/>`. Previously, TypeScript would use
its builtin ts.libMap and attempt to load builtin libraries from the
TypeScript installation, instead of respecting the user-supplied set of
libraries.
2019-01-11 09:02:49 +01:00
王文璐
9d16225bc2 emit jsx type arguments 2019-01-11 13:34:18 +08:00
Sheetal Nandi
abc861862a Fix typo 2019-01-10 15:18:02 -08:00
Wesley Wigham
aba0b700b6 Allow circular umd-merged-with-augmentation refs to resolve to the module as intended (#29335) 2019-01-10 14:48:15 -08:00
Wesley Wigham
76f444e338 Allow nonnull assertions in references (#29351) 2019-01-10 14:45:19 -08:00
Gabriela Britto
a9ed42f541 Merge branch 'master' into qualified-name-param-tag-error 2019-01-10 09:49:26 -08:00
Anders Hejlsberg
52b82560e8 Merge pull request #29338 from Microsoft/fixConditionalTypeResolution
Fix conditional type resolution
2019-01-09 17:18:12 -08:00
Anders Hejlsberg
70148a4b55 Improve logic that determines when to resolve conditional types 2019-01-09 16:10:28 -08:00
Gabriela Britto
dd0a612cc9 Use specific error message for qualified param name without leading top level param name 2019-01-09 16:08:14 -08:00
Gabriela Britto
e16be71c08 Add diagnostic message for JSDoc qualified param name without top level param 2019-01-09 15:52:05 -08:00
Wesley Wigham
d0aff9bdcd Fix crash (#29333) 2019-01-09 14:23:57 -08:00
Sheetal Nandi
387be1fffa Merge pull request #29316 from Microsoft/randomIdentifier
Verify that completion with new identifier location returns isNewIdentifierLocation: true
2019-01-09 13:01:22 -08:00
Daniel Rosenwasser
6bfb935929 Merge pull request #25445 from a-tarasyuk/bug/24542-bad-error-message-for-import-ing-an-export
24542 - bad error message for `import *`-ing an `export=`
2019-01-09 11:02:14 -08:00
Sheetal Nandi
1b37830615 Merge branch 'master' into incrementalBuild 2019-01-09 10:40:01 -08:00
Klaus Meinhardt
b52a7fc3ea Exclude JSDoc @extends from 'super()' checks (#29308)
* Exclude JSDoc @extends from 'super()' checks

This fixes a similar problem as #29244 where JSDoc `@extends`

* fix check 'super can only be referenced in a derived class'
2019-01-09 10:35:22 -08:00