12302 Commits

Author SHA1 Message Date
Mohamed Hegazy
b10c2baaf3 Update version to 2.0.2 2016-08-18 14:53:04 -07:00
Yui
1d9124eb7c [Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction

* Remove unnecessary subtype reduction operations

* Use binary searching in union types to improve performance

* Optimize type inference

* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)

* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)

* Fix typo in comment for MAX_SAFE_INTEGER

* In ts.performance.now, bind window.performance.now

Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.

* Add lint enforcing line endings (#9942)

* Add servicesSources to the list of prerequisites for running tests

* Support emitting static properties for classes with no name

* Add assertion whitespace lint rule (#9931)

* Add assertion whitespace lint rule

* Fix typo

* Add the word `Rule` to Jakefile

* Limit travis build matrix (#9968)

* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)

* Convert getErrorBaseline to use canonical diagnostic formatting

* Fix lint

* Found another clone of format diagnostic - consolidate

* Fully declone

* Unify nodeKind implementations for navigationBar and navigateTo

* Fix test and rename a function

* Fix lint errors

* Remove hardcoded port, use the custom port

* Unlock ts-node version (#9960)

* Allow an abstract class to appear in a local scope

* JSDoc understands string literal types

Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.

* Update baselines to be current

* Add find and findIndex to ReadonlyArray

* The optional this should be readonly too.

* Update baseline source location

* Re-add concat overload to support inferring tuples

* Update baselines with new concat overload

* Update LastJSDoc[Tag]Node

* Display enum member types using qualified names

* Accept new baselines

* Fix lint error

* null/undefined are allowed as index expressions

`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.

* Use correct nullable terminology

* Get rid of port parameter

* Remove [port] in usage message

* Properly reset type guards in loops

* Add regression test

* Introduce the `EntityNameExpression` type

* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.

* Lint tests helper files

* recreate program if baseUrl or paths changed in tsconfig

* Simplify some code

* Have travis use a newer image for the OSX build (#10034)

Suggested by travis support for stopping the randomly-halting-builds issue.

* Correctly check for ambient class flag

* Use "best choice type" for || and ?: operators

* jsx opening element formatting

* change error message for unused parameter property

fix

* Fix issue related to this and #8383

* Add additional tests

* Accept new baselines

* Provide `realpath` for module resolution in LSHost

* Add test

* Add test baselines

* Accept new baselines

* CR feedback

* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.

* Fix bug

* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)

* Use recursion, and fix error for undefined node

* Rename function

* Fix lint error

* Narrowing type parameter intersects w/narrowed types

This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.

* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.

* Limit type guards as assertions to incomplete types in loops

* Accept new baselines

* Fix linting error

* Allow JS multiple declarations of ctor properties

When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.

* Use {} type facts for unconstrained type params

Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.

* Fix newline lint

* Test that declares conflicting method first

* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)

* Change the shape of the shim layer to support getAutomaticTypeDirectives

* Change the key for looking up automatic type-directives

* Update baselines from change look-up name of type-directives

* Add @currentDirectory into the test

* Update baselines

* Fix linting error

* Address PR: fix spelling mistake

* Instead of return path of the type directive names just return type directive names

* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)

* Add string-literal completion test for jsdoc

* Support other (new) literal types in jsdoc

* Don't allow properties inherited from Object to be automatically included in TSX attributes

* Add new test baseline and delete else in binder

The extra `else` caused a ton of test failures!

* Fix lint

* Port PR #10016 to Master (#10100)

* Treat namespaceExportDeclaration as declaration

* Update baselines

* wip - add tests

* Add tests

* Show "export namespace" for quick-info

* Fix more lint

* Try using runtests-parallel for CI (#9970)

* Try using runtests-parallel for CI

* Put worker count setting into .travis.yml

* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts

* Fix lssl task (#9967)

* Surface noErrorTruncation option

* Stricter check for discriminant properties in type guards

* Add tests

* Emit more efficient/concise "empty" ES6 ctor

When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:

```ts
class Foo extends Bar {
  public foo = 1;
}
```

```js
class Foo extends Bar {
  constructor(…args) {
    super(…args);
    this.foo = 1;
  }
}
```

This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).

This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:


```js
var Foo = (function (_Bar) {
  _inherits(Foo, _Bar);

  function Foo() {
    _classCallCheck(this, Foo);

    for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
      args[_key] = arguments[_key];
    }

    _Bar.call.apply(_Bar, [this].concat(args));
    this.foo = 1;
  }

  return Foo;
})(Bar);
```

This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).

Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:


```js
class Foo extends Bar {
  constructor() {
    super(…arguments);
    this.foo = 1;
  }
}
```

Which compiles into the following in Babel:

```js
var Foo = (function (_Bar) {
  _inherits(Foo, _Bar);

  function Foo() {
    _classCallCheck(this, Foo);

    _Bar.apply(this, arguments);
    this.foo = 1;
  }

  return Foo;
})(Bar);
```

Which is well-optimized (today) in most engines and much less confusing
to read.

As far as I can tell, the proposed compilation has exactly the same
semantics as before.

Fixes #10175

* Fix instanceof operator narrowing issues

* Accept new baselines

* Add regression test

* Improve naming and documentation from PR

* Update comment

* Add more tests

* Accept new baselines

* Reduce worker count to 3 (#10210)

Since we saw a starvation issue on one of @sandersn's PRs.

* Speed up fourslash tests

* Duh

* Make baselines faster by not writing out unneeded files

* Fix non-strict-compliant test

* Fix 10076: Fix Tuple Destructing with "this" (#10208)

* Call checkExpression eventhough there is no appropriate type from destructuring of array

* Add tests and baselines

* use transpileModule

* Remove use strict

* Improve instanceof for structurally identical types

* Introduce isTypeInstanceOf function

* Add test

* Accept new baselines

* Fix loop over array to use for-of instead of for-in

* Use correct this in tuple type parameter constraints

Instantiate this in tuple types used as type parameter constraints

* Add explanatory comment to resolveTupleTypeMembers

* Ignore null, undefined, void when checking for discriminant property

* Add regression test

* Delay tuple type constraint resolution

Create a new tuple that stores the this-type.

* Always use thisType when generating tuple id

* Optimize format of type list id strings used in maps

* Make ReadonlyArray iterable.

* Allow OSX to fail while we investigate (#10255)

The random test timeouts are an issue.

* avoid using the global name

* Fix single-quote lint

* Optimize performance of maps

* Update API sample

* Fix processDiagnosticMessages script

* Have travis take shallow clones of the repo (#10275)

Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.

We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.

* Add folds to travis log (#10269)

* Optimize filterType to only call getUnionType if necessary

* Add shorthand types declaration for travis-fold (#10293)

* Optimize getTypeWithFacts

* Filter out nullable and primitive types in isDiscriminantProperty

* Fix typo

* Add regression tests

* Optimize core filter function to only allocate when necessary

* Address CR comments + more optimizations

* Faster path for creating union types from filterType

* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.

* Lint

* Collect timing information for commands running on travis (#10308)

* Simplifies performance API

* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.

* narrow from 'any' in most situations

instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.

* Update instanceof conformance tests

* accept new baselines

* add tests

* accept new baselines

* Use lowercase names for type reference directives

* Use proper response codes in web tests

* Treat ambient shorthand declarations as explicit uses of the `any` type

* Parallel linting (#10313)

* A perilous thing, a parallel lint

* Use work queue rather than scheduling work

* Dont read files for lint on main thread

* Fix style

* Fix the style fix (#10344)

* Aligned mark names with values used by ts-perf.

* Use an enum in checkClassForDuplicateDeclarations to aid readability

* Rename to Accessor

* Correctly update package.json version

* Migrated more MapLikes to Maps

* Add ES2015 Date constructor signature that accepts another Date (#10353)

* Parameters with no assignments implicitly considered const

* Add tests

* Migrate additional MapLikes to Maps.

* Fix 10625: JSX Not validating when index signature is present  (#10352)

* Check for type of property declaration before using index signature

* Add tests and baselines

* fix linting error

* Adding more comments

* Clean up/move some Map helper functions.

* Revert some formatting changes.

* Improve ReadonlyArray<T>.concat to match Array<T>

The Array-based signature was incorrect and also out-of-date.

* Fix link to blog

* Remove old assertion about when we're allowed to use fileExists

* Set isNewIdentifierLocation to true for JavaScript files

* Update error message for conflicting type definitions

Fixes #10370

* Explain why we lower-case type reference directives

* Correctly merge bindThisPropertyAssignment

Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.

* Fix comment

* Property handle imcomplete control flow types in nested loops

* Update due to CR suggestion

* Add regression test

* Fix 10289: correctly generate tsconfig.json with --lib (#10355)

* Separate generate tsconfig into its own function and implement init with --lib

# Conflicts:
#	src/compiler/tsc.ts

* Add tests and baselines; Update function name

Add unittests and baselines
Add unittests and baselines for generating tsconfig

Move unittest into harness folder

Update harness tsconfig.json

USe correct function name

* Use new MapLike interstead. Update unittest

# Conflicts:
#	src/compiler/commandLineParser.ts

* Update JakeFile

* Add tests for incorrect cases

* Address PR : remove explicity write node_modules

* Add more tests for `export = foo.bar`.

* Output test baselines to tests/baselines/local instead of root
2016-08-18 14:49:09 -07:00
Yui
5d0e1994f4 [Release 2.0] fix10076 : Destructing with "this" (#10209)
* Call checkExpression eventhough there is no appropriate type from destructuring of array

* Add tests and baselines
2016-08-09 16:05:17 -07:00
Yui
0cfeaaffb5 [Release 2.0] fix10179: 2.0 emits optional class properties defined in constructors, which breaks compatibility (#10212)
* Do not emit "?" for in property declaration in .d.ts when the property is declared as optional parameter property declaration

* Update baselines
2016-08-08 14:45:01 -07:00
Yui
8830d7691e Port PR#9867 to Release-2.0 (#10147)
* Change the shape of the shim layer to support getAutomaticTypeDirectives

* Change the key for looking up automatic type-directives

* Update baselines from change look-up name of type-directives

* Add @currentDirectory into the test

* Update baselines

* Fix linting error

* Address PR: fix spelling mistake

* Instead of return path of the type directive names just return type directive names
2016-08-05 14:00:40 -07:00
Andy
d173bca569 Merge pull request #10136 from Microsoft/release-2.0_export_specifiers_map
Add a helper function `getOrUpdateProperty` to prevent unprotected ac…
2016-08-04 07:44:04 -07:00
Andy Hanson
0aaec56b8f Add a helper function getOrUpdateProperty to prevent unprotected access to Maps. 2016-08-04 06:04:41 -07:00
Yui
126c1eeb59 [Release-2.0] fix 9802: fix language service for UMD module alias (#10016)
* Treat namespaceExportDeclaration as declaration

* Update baselines

* wip - add tests

* Add tests

* Show "export namespace" for quick-info
2016-08-02 13:01:05 -07:00
Andy
8ceeb4bdc4 Merge pull request #10070 from Microsoft/release-2.0_lshost_realpath
Provide `realpath` for module resolution in LSHost
2016-08-02 06:09:50 -07:00
Andy Hanson
5fb2fbd33c Provide realpath for module resolution in LSHost 2016-08-01 10:30:10 -07:00
Richard Knoll
d98846bd53 Merge pull request #9972 from Microsoft/explicitly_included_globs_2.0
Porting #9528 to release 2.0 branch
2016-07-29 13:27:24 -07:00
Richard Knoll
b587127227 Merge remote-tracking branch 'origin/release-2.0' into explicitly_included_globs_2.0 2016-07-29 13:04:09 -07:00
Andy
80e80b1221 Merge pull request #9981 from Microsoft/release-2.0_class_expression_static_property
Support emitting static properties for classes with no name
2016-07-27 07:14:34 -07:00
Andy Hanson
4e778c0790 Support emitting static properties for classes with no name 2016-07-27 05:43:00 -07:00
Anatoly Ressin
d182d7fa8d Fixed broken singleAsteriskRegex. Fixes #9918 (#9920) 2016-07-26 15:38:31 -07:00
Richard Knoll
591959507a Add support for including dotted and .min.js files explicitly in include
Porting #9528 to release 2.0 branch
2016-07-26 14:57:45 -07:00
Yui
bd6d2c0251 [Release-2.0] Fix 9829 : do not report error using import, export, module augmentation in d.t.s (#9894)
* Only error in non-declaration file

* Add tests and baselines

* Addess PR: get the first non-ambient external module file

* Rename test file and update baseline

* Add tests and baselines

* Update baselines
2016-07-22 10:16:00 -07:00
Nathan Shively-Sanders
da212960b1 Use originalKeywordKind to detect this parameters 2016-07-22 07:53:22 -07:00
Nathan Shively-Sanders
97e4578b74 Test that emitter skips this with rest parameter
Also test that it's skipped when emitting decorator metadata
2016-07-22 07:52:54 -07:00
Nathan Shively-Sanders
5768b42bfa Skip this in emitter in 2 more places 2016-07-22 07:52:31 -07:00
Yui
14aa1323f5 [Release-2.0] Fix 9632 Auto-completion for quoted property in object literal expression (#9745)
* wip

* Add completion for quote property name in object literal expression

* Add fourslash tests for completion of quoted property in object literal expression

* Handle object-literal expression as an argument

* Add tests and baseline for object literal expression for arguments

* Undo wip

* Undo wip
2016-07-21 21:02:49 -07:00
Daniel Rosenwasser
253253db5a Merge pull request #9855 from Microsoft/tsaImmutableTo-2.0
Port TemplateStringsArray immutability to release-2.0
2016-07-21 14:37:15 -07:00
Daniel Rosenwasser
6968ebf84e Accepted baselines. 2016-07-20 18:07:45 -07:00
Daniel Rosenwasser
3470ef5cbc Fixed up tests that used 'string[]' instead of 'TemplateStringsArray'. 2016-07-20 18:00:17 -07:00
Daniel Rosenwasser
1ef7375834 Make TemplateStringsArray completely immutable. 2016-07-20 18:00:04 -07:00
Yui
3721a2d799 [Release-2.0] Fix 9782: do not report blocked-scope-used-before-declaration error in ambient context (#9789)
* Do not report block-scoped-used-before-declaration in ambient context

* Add tests and baselines
2016-07-19 10:53:04 -07:00
Ryan Cavanaugh
2aed1c89c3 Merge pull request #9799 from RyanCavanaugh/port_fix9785
Port #9798
2016-07-18 14:57:04 -07:00
Mohamed Hegazy
08b3b8be71 Merge pull request #9784 from Microsoft/Fix9636
Fix #9636: report unused type parameter error on the last declaration
2016-07-18 14:42:56 -07:00
Ryan Cavanaugh
dec09ec51d Port #9798 2016-07-18 14:36:43 -07:00
Mohamed Hegazy
7f045adc86 Code review comments 2016-07-18 09:19:29 -07:00
Yui
9886f88004 [Release-2.0] Fix 9685: missing decoratedClassAlias emit in self-reference decorated class (#9763)
* Wip

* Fix incorrect emit decorated class alias when targeting es6 or higher

* Add tests and baselines

* Remove unused test file
2016-07-18 08:48:12 -07:00
Mohamed Hegazy
a3b0810d8c Merge branch 'release-2.0' into Fix9636 2016-07-17 23:51:52 -07:00
Mohamed Hegazy
290caad402 Fix #9636: Report unused type paramters only on last declaration 2016-07-17 23:51:17 -07:00
Mohamed Hegazy
9ef65cf3af remove unused method declaration 2016-07-17 23:25:33 -07:00
Vladimir Matveev
2b8c1f9515 Merge pull request #9764 from Microsoft/port-9750
Port #9750 into release 2.0
2016-07-17 12:10:16 -07:00
Yui
5319fa3a0d Fix linting error (#9762) 2016-07-15 16:49:18 -07:00
Vladimir Matveev
bf8937cc84 remove extra semicolon 2016-07-15 12:51:53 -07:00
Vladimir Matveev
af0c548312 Merge pull request #9750 from Microsoft/fixFormatDiagnostics
use sys based host for formatting diagnostics
2016-07-15 12:35:03 -07:00
Mohamed Hegazy
37d41f9ec0 Merge pull request #9713 from alexeagle/release-2.0
use getNewLine from host rather than sys
2016-07-13 16:57:11 -07:00
Alex Eagle
05fbe7cddd use getNewLine from host rather than sys 2016-07-13 15:25:15 -07:00
Mohamed Hegazy
8612caea38 Merge pull request #9701 from alexeagle/release-2.0
cherry-pick formatDiagnostics utility to release-2.0 branch
2016-07-13 14:31:14 -07:00
Alex Eagle
e28acd3c1f Add formatDiagnostics utility 2016-07-13 14:22:16 -07:00
Andy
ea99262891 Merge pull request #9680 from Microsoft/format_tsx_release-2.0
Handle JSX bodies in formatter
2016-07-13 14:01:41 -07:00
zhengbli
606ac0e533 Port #9621 to release-2.0 2016-07-13 11:38:26 -07:00
Andy Hanson
122c47c035 Handle JSX bodies in formatter 2016-07-13 08:15:55 -07:00
Nathan Shively-Sanders
fa0fab1523 Merge branch 'release-2.0' of https://github.com/Microsoft/TypeScript into release-2.0 2016-07-11 13:54:22 -07:00
Bill Ticehurst
78da46c435 Merge pull request #9614 from Microsoft/port9607
Port9607
2016-07-11 13:47:28 -07:00
Nathan Shively-Sanders
4e02bc61a2 Update conflicting baseline.
PR #9574 added a baseline that #9578 caused to be changed. The two PRs
went in so close to each other that the CI build didn't catch the change
to the new test's baseline.
2016-07-11 13:10:01 -07:00
Nathan Shively-Sanders
4598c13eec Provide a symbol for salsa-inferred class types 2016-07-11 12:51:45 -07:00
Nathan Shively-Sanders
9ae04223e3 Fix multiple Salsa assignment-declarations
Previously, all assignment-declarations needed to be of the same kind:
either all `this.p = ...` assignments or `C.prototype.p = ...`
assignments.
2016-07-11 12:51:24 -07:00