Andrew Casey
9efab94dfd
Annotate fewer extracted constants with types
...
Expose `isContextSensitive` from the checker and omit type annotations
for expressions for which it returns false.
2017-12-15 15:11:17 -08:00
Andrew Casey
e9ac87c2d6
Don't insert a blank line after extracted locals
...
Still insert a blank line after extracted properties.
2017-12-15 15:11:16 -08:00
Andrew Casey
a3ab1ffcff
Merge pull request #20713 from amcasey/GH19165
...
Stop assuming code fix test changes are in the originating file
2017-12-15 14:21:57 -08:00
Wesley Wigham
d89d68f426
make jsx attributes mutable locations ( #20710 )
2017-12-15 10:02:56 -08:00
csigs
d6192385a1
LEGO: Merge pull request 20720
...
LEGO: Merge pull request 20720
2017-12-15 03:10:50 -08:00
csigs
ed4bd2e5ab
LEGO: check in for master to temporary branch.
2017-12-15 11:10:31 +00:00
Andrew Casey
8b0988543b
Stop assuming code fix test changes are in the originating file
...
Triggering a fix in one file can result in changes in another file.
Instead of passing around the originating file, retrieve an appropriate
`ScriptInfo` for each `FileTextChanges`.
Fixes #19165
2017-12-14 16:50:28 -08:00
Josh Goldberg
423ab2e03d
Removed colors devDependency ( #20430 )
...
* Replaced colors with chalk
* Used chalk's preferred import style
2017-12-14 16:05:25 -08:00
csigs
7d3eff8cdc
LEGO: Merge pull request 20708
...
LEGO: Merge pull request 20708
2017-12-14 15:10:56 -08:00
csigs
be1d6da123
LEGO: check in for master to temporary branch.
2017-12-14 23:10:37 +00:00
Benjamin Lichtman
26c1a49d59
Merge pull request #20640 from uniqueiniquity/revertToJsDocInclusionList
...
Revert to inclusion list for JsDoc comment completion
2017-12-14 14:37:31 -05:00
csigs
7d229aedec
LEGO: Merge pull request 20698
...
LEGO: Merge pull request 20698
2017-12-14 09:10:28 -08:00
csigs
f6a383e3e4
LEGO: check in for master to temporary branch.
2017-12-14 17:10:08 +00:00
csigs
ac091c2ca7
LEGO: Merge pull request 20693
...
LEGO: Merge pull request 20693
2017-12-14 03:10:58 -08:00
csigs
309468396d
LEGO: check in for master to temporary branch.
2017-12-14 11:10:40 +00:00
csigs
2368ad7eef
LEGO: Merge pull request 20690
...
LEGO: Merge pull request 20690
2017-12-13 21:10:30 -08:00
csigs
064d9345e1
LEGO: check in for master to temporary branch.
2017-12-14 05:10:09 +00:00
csigs
f06d57174d
LEGO: Merge pull request 20687
...
LEGO: Merge pull request 20687
2017-12-13 15:11:10 -08:00
csigs
5299e91be3
LEGO: check in for master to temporary branch.
2017-12-13 23:10:50 +00:00
Wesley Wigham
e1278f091c
Get resolved module exports in symbol chain and not raw exports ( #20661 )
...
* Actually get module exports and not module exports sans export stars
* style update
* Trim test a bit
2017-12-13 14:01:23 -08:00
Wesley Wigham
2c6501db52
Allow multiple star-star globs in one pattern ( #20639 )
...
* Allow multiple starglobs in one pattern
* Add extra test case
2017-12-13 12:57:16 -08:00
Ryan Cavanaugh
f6603cd9f2
Merge pull request #20545 from RyanCavanaugh/codefixOmnibus
...
Omnibus fixes for telemetry-sourced crashes
2017-12-13 12:49:58 -08:00
Ryan Cavanaugh
8f8e6a36a7
Merge pull request #20679 from RyanCavanaugh/removeLibTodo
...
Remove TODO from lib.d.ts
2017-12-13 12:49:40 -08:00
Andy
84eb25c561
Handle arrays with properties in assert.deepEqual ( #20674 )
...
* Handle arrays with properties in assert.deepEqual
* Fix tests
2017-12-13 11:50:53 -08:00
Andy
6fbeced025
Simplify test case ( #20675 )
2017-12-13 11:03:37 -08:00
Ryan Cavanaugh
100262537a
Remove TODO
2017-12-13 10:58:04 -08:00
Ryan Cavanaugh
65e92c624b
Merge pull request #20664 from RyanCavanaugh/clearResolutionCache
...
Clear the module resolution cache when new @types appear
2017-12-13 09:40:16 -08:00
Wesley Wigham
79a1240a19
Revert merge pull request #20429 (removing chai) ( #20654 )
...
* Revert "Merge pull request #20429 from Microsoft/unchai"
This reverts commit 66ec938164b61a7a9e14214f36bf58edc11c7609, reversing
changes made to 37a40561ac4c4cb1f970ade5fff2389d954593f6.
* Update lockfile
2017-12-13 06:49:50 -08:00
csigs
edb9e97ca7
LEGO: Merge pull request 20672
...
LEGO: Merge pull request 20672
2017-12-13 03:10:50 -08:00
csigs
7125cad406
LEGO: check in for master to temporary branch.
2017-12-13 11:10:32 +00:00
csigs
9ae67026d7
LEGO: Merge pull request 20666
...
LEGO: Merge pull request 20666
2017-12-12 21:10:29 -08:00
csigs
dbceefd05a
LEGO: check in for master to temporary branch.
2017-12-13 05:10:08 +00:00
Ryan Cavanaugh
9e122d0305
Fix test
2017-12-12 17:22:41 -08:00
Wesley Wigham
40029a0523
Use TypeFlags.UnionOrIntersection not TypeFlags.Union ( #20662 )
2017-12-12 16:32:55 -08:00
Ryan Cavanaugh
bd3a27ed52
Clear the module resolution cache when new @types appear
2017-12-12 16:11:37 -08:00
csigs
5dab24a2a7
LEGO: Merge pull request 20660
...
LEGO: Merge pull request 20660
2017-12-12 15:11:51 -08:00
csigs
ef23eb71be
LEGO: check in for master to temporary branch.
2017-12-12 23:11:33 +00:00
Andy
8ad4aeece1
Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter ( #20574 )
...
* Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter
* Don't require newLineCharacter as input to ChangeTracker methods, and make it private again
2017-12-12 12:23:13 -08:00
Andy
21ff2cd501
Remove unnecessary getFirstChildOfKind helper function ( #20647 )
2017-12-12 11:25:58 -08:00
Nathan Shively-Sanders
e58d80ad83
Merge pull request #20648 from Microsoft/nonprimitive-spreads-to-empty-object
...
Non-primitive spreads to empty object
2017-12-12 10:56:21 -08:00
csigs
9f3621947a
LEGO: Merge pull request 20646
...
LEGO: Merge pull request 20646
2017-12-12 09:10:29 -08:00
csigs
ea1e4102f5
LEGO: check in for master to temporary branch.
2017-12-12 17:10:08 +00:00
Wesley Wigham
0d8856cf47
Update chrome devtools user test baseline ( #20641 )
2017-12-12 08:45:39 -08:00
Nathan Shively-Sanders
4bc0d85d29
Test:spread object retains lefthandside
...
1. Make sure that spreading `object` doesn't lose everything to the left.
2. Update baselines to show that `{ ...object }` is now `{}`.
2017-12-12 08:37:34 -08:00
Nathan Shively-Sanders
43a5a271ee
object spreads to {}
...
Specifically, when spreading `object` on the right, spread now returns the
left of the spread; previously it returned `object`, which loses
everything to the left.
2017-12-12 08:34:36 -08:00
Andy
d53af092c7
Always check a return expression in a generator ( #20621 )
2017-12-12 07:50:11 -08:00
Wesley Wigham
3aa192a870
Unshallow submodule clones, update submodule ref ( #20636 )
2017-12-11 19:26:42 -05:00
uniqueiniquity
97a573984f
Add type alias declarations to inclusion list docs
2017-12-11 16:15:32 -08:00
uniqueiniquity
03b036b630
Revert "Loosen restrictions on jsdoc completion locations"
...
This reverts commit 612616a1058d7aa9fc181126f83041549bfbe295.
2017-12-11 15:56:31 -08:00
csigs
d3a7db8b57
LEGO: Merge pull request 20638
...
LEGO: Merge pull request 20638
2017-12-11 15:11:48 -08:00