Sheetal Nandi
9dbe037e84
Use seen map to avoid circular transitive exports to cause stack over flow
...
Fixes #28433
2018-11-09 09:22:39 -08:00
Sheetal Nandi
69c61cd166
Merge pull request #27988 from KnisterPeter/fix24931
...
Correct codefix by removing private modifier
2018-11-09 08:47:49 -08:00
Markus Wolf
499bed540b
Better reference usage detection
2018-11-09 09:45:20 +01:00
Markus Wolf
6bd298b884
add test for remove modifier and parameter
2018-11-09 09:45:12 +01:00
Markus Wolf
13e85ac3a9
add more modifiers
2018-11-09 09:45:12 +01:00
Markus Wolf
d411fa34a7
Add test case for codeFix
2018-11-09 09:45:11 +01:00
Markus Wolf
de7faa1b7e
Remove obsolte ts namespace
2018-11-09 09:45:11 +01:00
Markus Wolf
e6e71978df
Correct codefix by removing private modifier
...
In case of private attribute and private constructor parameter with
assignment in the constructor body, the parameter is flagged as unused.
This is caused by the private modifier which is shadowed by the
explicity assignment in the body.
This commit updates the codefix to just remove the private modifier in
this cases.
Closes #24931
2018-11-09 09:45:11 +01:00
Anders Hejlsberg
187fa20bf2
Accept new baselines
2018-11-09 06:45:41 +01:00
Anders Hejlsberg
627f1ad876
Add regression tests
2018-11-09 06:45:21 +01:00
csigs
6b641de465
LEGO: Merge pull request 28428
...
LEGO: Merge pull request 28428
2018-11-08 20:10:40 -08:00
csigs
23b7284ca3
LEGO: check in for master to temporary branch.
2018-11-09 04:10:18 +00:00
Kagami Sascha Rosylight
7995f9153a
apply suggested changes
2018-11-09 11:26:58 +09:00
Sheetal Nandi
62419bb103
Merge pull request #28419 from Microsoft/elaborateAssert
...
Elaborate assert of infos attached to project
2018-11-08 15:45:38 -08:00
Sheetal Nandi
c0587191fc
Merge pull request #28418 from ajafff/internal-comments
...
remove even more internal comments
2018-11-08 14:58:33 -08:00
Sheetal Nandi
7bfc2c8113
Elaborate assert of infos attached to project
2018-11-08 14:56:10 -08:00
Klaus Meinhardt
bcc4e64832
revert changes to tsbuild.ts
2018-11-08 23:36:54 +01:00
Sheetal Nandi
432772e5a3
Merge pull request #28417 from Microsoft/relativeFilesThroughDynamicFile
...
Allow creation of relative path file infos only for open script infos and dynamic file
2018-11-08 13:25:16 -08:00
Sheetal Nandi
8dd05d5858
Fix public API
2018-11-08 13:01:22 -08:00
Sheetal Nandi
55fb052d7a
Allow creation of relative path file infos only for open script infos
...
Fixes #20476
2018-11-08 12:43:48 -08:00
Wesley Wigham
89fda5ca83
Fix enum const initializer visibility painting ( #28415 )
2018-11-08 12:33:54 -08:00
Sheetal Nandi
41b19309d4
Better project logging
2018-11-08 12:32:49 -08:00
Sheetal Nandi
f97274383d
Log project name when removing project
2018-11-08 12:32:48 -08:00
Sheetal Nandi
9eecf3bd68
Some reorg
2018-11-08 12:32:48 -08:00
Sheetal Nandi
7736ea4e93
Add tests that create relative path even though the script info isnt dynamic
2018-11-08 12:32:48 -08:00
Sheetal Nandi
b534fb4849
Merge pull request #27980 from EECOLOR/leading-slash-imports
...
match leading slash imports with path mappings - fixes #13730
2018-11-08 09:20:45 -08:00
Anders Hejlsberg
e95ed29ca9
Fix fourslash test
2018-11-08 18:02:04 +01:00
Anders Hejlsberg
a8c4e6f83c
Accept new baselines
2018-11-08 17:59:39 +01:00
Anders Hejlsberg
55da2b9669
Preserve actual empty object type intersection
2018-11-08 17:59:03 +01:00
Ryan Clarke
ecb88f5a3e
Fix comments on pull request
2018-11-07 21:43:02 -05:00
Daniel Rosenwasser
514e8a129f
Merge pull request #28405 from weswigham/no-summary-non-watch-zero-errors
...
Do not output summary if theres nothing to report
2018-11-07 16:37:23 -08:00
Wesley Wigham
6ad58b242e
Do not output summary if theres nothing to report
2018-11-07 15:46:13 -08:00
Sheetal Nandi
15af7e17c6
Merge pull request #28400 from Microsoft/gotoDefinition
...
Fix the issue with file being included in the referencing project on rename when it wasnt included earlier
2018-11-07 14:17:17 -08:00
Sheetal Nandi
3ec06038d5
Retain the casing in map files in file names
2018-11-07 13:47:30 -08:00
EECOLOR
1a9c20949e
path mappings now supports rooted disk paths and urls - fixes #13730
2018-11-07 22:19:04 +01:00
Sheetal Nandi
ab4be8da42
Fix the issue with file being included in the referencing project on rename when it wasnt included earlier
...
Fixes #28307
2018-11-07 11:30:39 -08:00
Sheetal Nandi
16ea9af36e
Merge pull request #28398 from Microsoft/renameInReferencedProject
...
Fix the issue with file being included in the referencing project on rename when it wasnt included earlier
2018-11-07 10:33:45 -08:00
Sheetal Nandi
1d87250573
Fix the issue with file being included in the referencing project on rename when it wasnt included earlier
...
Fixes #28043
2018-11-07 09:48:27 -08:00
Klaus Meinhardt
e2947fac1c
remove even more redundant internal comments
2018-11-07 16:12:48 +00:00
Alexander T
3f4c00c8a6
resolve conflicts
2018-11-07 10:20:11 +02:00
Alexander T
5bd0051daa
Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific
2018-11-07 10:05:34 +02:00
Sheetal Nandi
59a8c94ff1
Merge pull request #28385 from Microsoft/metadata
...
Add metadata to response if it exists for results from language service.
2018-11-06 20:12:58 -08:00
Sheetal Nandi
f0f02754f3
Change type of metadata to unknown
2018-11-06 18:45:08 -08:00
Anders Hejlsberg
8e0c4369b7
Merge pull request #28386 from Microsoft/removeTwoTypeFlags
...
Remove two flags from TypeFlags
2018-11-06 16:41:41 -08:00
Sheetal Nandi
448f385e3c
Fix lint errors
2018-11-06 15:49:17 -08:00
Anders Hejlsberg
7e3fd4626a
Accept API baseline changes
2018-11-06 15:07:00 -08:00
Sheetal Nandi
4a51f12c3e
Add metadata to response if it exists for results from language service.
...
Currently its wired through for completions requests.
Handles #21999
2018-11-06 15:06:54 -08:00
Anders Hejlsberg
e63ffe54fd
Move FreshLiteral flag from TypeFlags to ObjectFlags
2018-11-06 15:00:34 -08:00
Wesley Wigham
d351610e7a
Update opposite direction of #28218 ( #28384 )
2018-11-06 13:52:35 -08:00
Anders Hejlsberg
7df5a2cf8c
Remove pointless check
2018-11-06 13:31:56 -08:00
