microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-12 12:57:11 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

add test for remove modifier and parameter

Browse Source
This commit is contained in:
Markus Wolf 2018-11-05 18:07:29 +01:00
parent 13e85ac3a9
commit 6bd298b884
No known key found for this signature in database
GPG Key ID: 46051C9BE153B7A5
2 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/services/codefixes/fixUnusedIdentifier.ts
View File

@ -200,11 +200,10 @@ namespace ts.codefix {
function tryDeleteParameter(changes: textChanges.ChangeTracker, sourceFile: SourceFile, p: ParameterDeclaration, checker: TypeChecker, sourceFiles: ReadonlyArray<SourceFile>, isFixAll: boolean): void {
if (mayDeleteParameter(p, checker, isFixAll)) {
const modifiers: Modifier["kind"][] = [SyntaxKind.PrivateKeyword, SyntaxKind.ProtectedKeyword, SyntaxKind.PublicKeyword, SyntaxKind.ReadonlyKeyword];
const foundModifiers = modifiers.map(modifier => findModifier(p, modifier)).filter(modifier => modifier !== undefined);
if (foundModifiers.length > 0) {
foundModifiers.forEach(modifier => {
changes.deleteModifier(sourceFile, modifier!);
if (p.modifiers && p.modifiers.length > 0
&& (!isIdentifier(p.name) || FindAllReferences.Core.isSymbolReferencedInFile(p.name, checker, sourceFile))) {
p.modifiers.forEach(modifier => {
changes.deleteModifier(sourceFile, modifier);
});
}
else {

18
tests/cases/fourslash/codeFixUnusedIdentifier_parameter_modifier_and_arg.ts Normal file
View File

@ -0,0 +1,18 @@
/// <reference path='fourslash.ts' />
// @noUnusedLocals: true
// @noUnusedParameters: true
////export class Example {
//// constructor(private readonly arg: any) {
//// }
////}
verify.codeFix({
description: "Remove declaration for: 'arg'",
newFileContent:
`export class Example {
constructor() {
}
}`,
});