3410 Commits

Author SHA1 Message Date
Sheetal Nandi
75698a893f Add project roots in the list of root files even if they arent present on the disk
This helps in reporting errors as well as syncing of the configured/external project when the files are created
2017-07-10 11:31:33 -07:00
Andy
bffde588cc Improve performance of JSDoc tag utilities (#16836)
* Improve performance of JSDoc tag utilities

* Use emptyArray instead of null, and address PR comments
2017-07-10 11:26:59 -07:00
Andy
0567ca29c6 Remove EmptySafeList (#16647) 2017-07-10 09:19:18 -07:00
Andy
17578e8a5d Use Map<true> for sets (#16972) 2017-07-07 10:34:36 -07:00
Andy
2d802a62c4 Have isObjectBindingPatternElementWithoutPropertyName return the binding element (#16956) 2017-07-07 10:34:11 -07:00
Andy
e7dc2a67ca Enable "object-literal-shorthand" lint rule (#16987) 2017-07-07 07:26:58 -07:00
Wesley Wigham
4b19eb3200 Remove duplicate entries from tsconfig files (#16991) 2017-07-06 15:56:34 -07:00
Wesley Wigham
07e8263204 Start using a union for FunctionLike things (#16988)
* Start using a union for FunctionLike things

* Rename to shorter name
2017-07-06 14:46:15 -07:00
Wesley Wigham
4e6b2f3c93 Created a branded type for identifier-escaped strings (#16915)
* Created a branded type for escaped strings

Then flowed it throughout the compiler, finding and fixing a handful of
bugs relating to underscore-prefixed identifiers in the process.
Includes a test for two cases noticed - diagnostics from conflicting
symbols from export *'s, and enum with underscore prefixed member emit.

* Correctly double underscores WRT mapped types

* Add fourslash tests for other fixed issues

* use function call over cast

* Update forEachEntry type accuracy

* Just use escaped names for ActiveLabel

* Remove casts from getPropertyNameForPropertyNameNode

* This pattern has occurred a few times, could use a helper function.

* Remove duplicated helper

* Remove unneeded check, use helper

* Identifiers list is no longer escaped strings

* Extract repeated string-getting code into helper

* Rename type and associated functions

* Make getName() return UnderscoreEscapedString, add getUnescapedName()

* Add list of internal symbol names to escaped string type to cut back on casting

* Remove outdated comments

* Reassign interned values to nodes, just in case

* Swap to string enum

* Add deprecated aliases to escapeIdentifier and unescapeIdentifier

* Add temp var

* Remove unsafe casts

* Rename escaped string type as per @sandersn's suggestion, fix string enum usages

* Reorganize double underscore tests

* Remove jfreeman from TODO

* Remove unneeded parenthesis
2017-07-06 14:45:50 -07:00
Arthur Ozga
4e6e1d1b8b Merge pull request #16657 from aozgaa/formatOnOpenCurly
Format on open curly
2017-06-30 10:04:57 -07:00
Arthur Ozga
25abf8a9e8 respond ot comments 2017-06-29 17:31:41 -07:00
Ryan Cavanaugh
ec00bb9b72 Merge pull request #16697 from RyanCavanaugh/preserveMethodComments
Preserve method comments in JS->ES6 conversion.
2017-06-29 15:40:16 -07:00
Andrew Casey
ac72803bb2 Merge pull request #16684 from amcasey/Vsts434619
Watch for the creation of missing files
2017-06-29 13:41:18 -07:00
Arthur Ozga
60b78c618f only format open curly up to the open curly 2017-06-29 11:13:44 -07:00
Andy
179a3e10b5 Handle depth in all readDirectory implementations (#16646) 2017-06-29 11:04:33 -07:00
Andrew Casey
587309d029 Update error case check
`getTouchingWord` indicates failure by returning the sourceFile node,
rather than `undefined`.
2017-06-29 10:39:30 -07:00
t_
51fb7e9a81 Add alwaysStrict option (#16562)
* Add alwaysStrict option

* Enable alwaysStrict

* Fix for strict mode

* keep whitespace
2017-06-28 19:44:15 -07:00
Andy
c4319e3b94 Clean up uses of ensureScriptKind (#16714)
* Clean up uses of ensureScriptKind

* Remove unneeded parentheses
2017-06-28 14:29:16 -07:00
Andy
2ccfe502f7 Fix scope of @typedef references (#16718)
* Fix scope of @typedef references

* Remove unused variables
2017-06-28 13:30:23 -07:00
Andy
9013665e22 Replace FileMap with Map where there is no keyMapper (#16724)
* Replace FileMap with Map where there is no keyMapper

* Remove `toKey` and use `keyMapper` directly
2017-06-28 13:15:34 -07:00
Arthur Ozga
eae234cab2 disable spaceBeforeOpenCurly if newline rule is enabled 2017-06-28 13:13:53 -07:00
Andy
9260a399a3 Remove duplicate switch cases (#16721) 2017-06-28 12:53:43 -07:00
Andy
42e08f5578 findAllRefs: Find string references inside of template strings (#16723) 2017-06-28 12:53:12 -07:00
Arthur Ozga
a5c8a29fa4 only format opencurly if no intervening tokens 2017-06-28 12:48:14 -07:00
Andy
18357543c6 Provide better services for incomplete generic calls (#16535)
* Provide better services for incomplete generic calls

* Use clearer name

* Remove `inferredAnyDefaultTypeArgument` and `getBestGuessSignature`; have `resolveSignature` always get the best signature if !produceDiagnostics

* Update names and comments
2017-06-27 09:14:23 -07:00
Arthur Ozga
c5f6c4fac0 remove unecessary check 2017-06-26 11:21:21 -07:00
Arthur Ozga
61af315778 respond to comments 2017-06-26 10:55:04 -07:00
Ryan Cavanaugh
b52747e12c Add property comments as well 2017-06-26 10:54:18 -07:00
Andy
fd22a88abc Code cleanup in jsTyping.ts (#16632) 2017-06-23 10:03:01 -07:00
Ryan Cavanaugh
04d750f9f8 Preserve method comments in JS->ES6 conversion. Fixes #16622 2017-06-22 11:45:34 -07:00
Arthur Ozga
485927b26a clarify comment 2017-06-22 11:17:55 -07:00
Andrew Casey
aac7fb7cef Merge pull request #16664 from amcasey/TokenWorker
Short-circuit getTokenAtPositionWorker
2017-06-22 10:44:47 -07:00
Andrew Casey
2690d792c1 Short-circuit getTokenAtPositionWorker
The children of a given node are sorted by start position so, if one of
them starts after a given position, all subsequent children all start
after that position.
2017-06-20 15:32:32 -07:00
Arthur Ozga
0df66a5e6d format space before single-line blocks 2017-06-20 11:52:03 -07:00
Arthur Ozga
4c40c42f56 format on open curly 2017-06-20 11:51:45 -07:00
Sheetal Nandi
31653de3c3 Merge pull request #16566 from Microsoft/keywordFilters
Fix the completion for parameters
2017-06-15 15:44:33 -07:00
Sheetal Nandi
4ce8af3652 Show public/private/protected/readonly when looking for constructor parameter and otherwise parameter declaration or property declaraiton should result in no completion
Fixes #15937
2017-06-15 11:16:35 -07:00
Sheetal Nandi
09f0b3471a Merge branch 'master' into ownJsonParsing 2017-06-15 09:59:37 -07:00
Sheetal Nandi
187febd10f Merge pull request #16494 from Microsoft/dontCreateScriptInfosWithFileExistsAndReadFile
Fixes the memory leak because of project and its corresponding script info even after project is removed
2017-06-14 15:17:25 -07:00
Mohamed Hegazy
3532875af7 Merge branch 'master' into completionWithMeaning 2017-06-13 17:41:24 -07:00
Arthur Ozga
9cd04e06fd Merge pull request #16309 from aozgaa/codeFixPrefixUnused2
Code fix prefix unused2
2017-06-13 11:16:33 -07:00
Sheetal Nandi
1f167786ad Merge branch 'master' into completionWithMeaning 2017-06-13 11:16:32 -07:00
Arthur Ozga
2a05bb1441 Merge pull request #16433 from Microsoft/suppressBraceCompletionOfQuotesinComments
Suppress brace completion of Quotes in Comments
2017-06-13 11:07:52 -07:00
Yui
23f618b6bc Merge pull request #16406 from Microsoft/master-fix16402
[Master] Language Service on Dynamic import
2017-06-13 10:22:45 -07:00
Mohamed Hegazy
1d0087dd2d Update version 2017-06-12 18:28:10 -07:00
Sheetal Nandi
1bf1209f7e Cleanup script infos that are not part of any project when the project is closed or inferred projects are refreshed
Also dispose some pointers so that the closures get disposed with project and script infos
2017-06-12 16:52:36 -07:00
Arthur Ozga
70bace78a0 respond to comments 2017-06-12 15:36:34 -07:00
Andy
6a8a6c34b4 getPossibleSymbolReferencePositions: Always use full start (#16420) 2017-06-12 15:24:31 -07:00
Nathan Shively-Sanders
93bdd3cb39 Fix reference to isTypeParameterDeclaration in services
Fixes build break
2017-06-12 15:07:04 -07:00
Andy
7fb821e45b Support completions in destructuring in for-of (#16454) 2017-06-12 12:12:51 -07:00