microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-04-17 01:49:41 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #16433 from Microsoft/suppressBraceCompletionOfQuotesinComments

Browse Source 
Suppress brace completion of Quotes in Comments
This commit is contained in:
Arthur Ozga
2017-06-13 11:07:53 -07:00
committed by GitHub
parent 23f618b6bc 70bace78a0
commit 2a05bb1441
2 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/services/services.ts
View File

@@ -1822,6 +1822,13 @@ namespace ts {
return false;
}
switch (openingBrace) {
case CharacterCodes.singleQuote:
case CharacterCodes.doubleQuote:
case CharacterCodes.backtick:
return !isInComment(sourceFile, position);
}
return true;
}

19
tests/cases/fourslash/commentBraceCompletionPosition.ts
View File

@@ -7,17 +7,30 @@
//// // inside regular comment /*2*/
//// var c = "";
////
//// /* inside multi-
//// line comment /*3*/
//// /*3*//* inside /*4*/multi-
//// line comment /*5*/
//// */
//// var y =12;
//// }
goTo.marker('1');
verify.isValidBraceCompletionAtPosition('(');
verify.not.isValidBraceCompletionAtPosition('"');
verify.not.isValidBraceCompletionAtPosition(`'`);
verify.not.isValidBraceCompletionAtPosition('`');
goTo.marker('2');
verify.isValidBraceCompletionAtPosition('(');
verify.not.isValidBraceCompletionAtPosition('"');
goTo.marker('3');
verify.isValidBraceCompletionAtPosition('(');
verify.isValidBraceCompletionAtPosition('(');
verify.isValidBraceCompletionAtPosition('"');
goTo.marker('4');
verify.isValidBraceCompletionAtPosition('(');
verify.not.isValidBraceCompletionAtPosition('"');
goTo.marker('5');
verify.isValidBraceCompletionAtPosition('(');
verify.not.isValidBraceCompletionAtPosition('"');