Mohamed Hegazy
962c4de875
Address code review comments
2014-10-27 15:30:38 -07:00
Mohamed Hegazy
b6f4aa9da9
Fix wrong condition for unterminated multi-line comments
2014-10-23 14:08:04 -07:00
Mohamed Hegazy
3c32fcc8df
Move helpers to the bottom of the function
2014-10-23 13:44:10 -07:00
Mohamed Hegazy
48404452b8
Cleanup completion list logic:
...
- Do not walk the tree multiple times for the same session, instead pass along the previous token
- Use current token if the this is not after a dot to avoid running into scoping issues
- Also, add some documentation about different steps
2014-10-23 13:42:56 -07:00
Mohamed Hegazy
899271ce57
Merge branch 'master' into completionFixes
...
Conflicts:
src/services/services.ts
2014-10-23 12:57:22 -07:00
Mohamed Hegazy
d327873d7b
Fix issue #764 , select the correct scope node if not left of a dot
2014-10-23 12:52:42 -07:00
Mohamed Hegazy
669044c495
Fix issue #866 , detect the current location correctelly in completion entry details
2014-10-23 12:35:04 -07:00
Mohamed Hegazy
161eea13e0
Add test for issue#903
2014-10-23 09:34:29 -07:00
Mohamed Hegazy
3dc6072f58
Disallow completion in interface declarations
2014-10-23 09:27:50 -07:00
Daniel Rosenwasser
fbbc4a3b59
Merge pull request #901 from Microsoft/syntacticClassificationOnNewTree
...
Switched syntactic classifier to use new tree
2014-10-22 18:49:20 -07:00
Mohamed Hegazy
463b2392b7
remove call to getSourceUnit
2014-10-22 17:36:43 -07:00
Mohamed Hegazy
68db15d960
Split completionListAtIdentifierDefinitionLocation into multiple tests to ease debugging
2014-10-22 17:34:00 -07:00
Mohamed Hegazy
417cea9cc0
move completion list position detection to the new tree
2014-10-22 17:33:16 -07:00
Daniel Rosenwasser
06e5f158ca
Merge branch 'master' into syntacticClassificationOnNewTree
2014-10-22 15:57:03 -07:00
Daniel Rosenwasser
32606ac1b6
Addressed CR feedback.
2014-10-22 15:56:00 -07:00
Anders Hejlsberg
051478d7d5
Merge pull request #942 from Microsoft/unionTypeFixes
...
Union type fixes and optimizations
2014-10-22 14:48:22 -07:00
Anders Hejlsberg
71c69a8e83
Renaming getApparentPropertyOfType to getPropertyOfType
2014-10-22 14:33:06 -07:00
Anders Hejlsberg
f4ccaf28c3
Union type fixes and optimizations
2014-10-22 10:53:08 -07:00
Daniel Rosenwasser
30a49db96e
Merge pull request #932 from Microsoft/breakCycleInDiagnosticGeneration
...
Removed Diagnostics from sys.ts in order to avoid cyclical build dependency
2014-10-22 01:06:34 -07:00
Daniel Rosenwasser
b371b02ea0
Addressed CR feedback.
2014-10-21 15:11:55 -07:00
Daniel Rosenwasser
aac8b3fae5
Removed Diagnostics from sys.ts in order to avoid cyclical build dependency.
...
Specifically, processDiagnosticMessages.ts was dependent on sys.ts, which was dependent on the rest of the compiler,
which meant that in a broken state of diagnostics, you could never compile processDiagnosticMessages.ts.
2014-10-21 14:48:43 -07:00
Yui
a6eb698f5b
Merge pull request #924 from Microsoft/fixColorizationUnittest
...
Fix colorization unittest
2014-10-20 14:52:46 -07:00
Yui T
54bc1da5d0
Address code review
2014-10-20 14:39:31 -07:00
Yui T
7806094a1a
Address code review
2014-10-20 13:47:09 -07:00
Yui T
ba77284485
Fix colorization unittest
2014-10-20 13:11:08 -07:00
Yui T
30fe3f7221
Fix runtests for unittests
2014-10-20 13:08:33 -07:00
Jason Freeman
a1e69b0dc2
Merge pull request #915 from Microsoft/sigHelp
...
Basic generic signature help
2014-10-20 12:46:16 -07:00
Jason Freeman
d5709edbc7
Merge branch 'master' into sigHelp
2014-10-20 11:52:31 -07:00
Jason Freeman
1b8814cdcd
Address PR feedback
2014-10-20 11:51:45 -07:00
Anders Hejlsberg
a537cb3f02
Merge pull request #919 from Microsoft/optionalPropertySubtyping
...
Require optional properties to be present in subtypes
2014-10-20 11:47:22 -07:00
Anders Hejlsberg
ff20df7a4a
Merge branch 'master' into optionalPropertySubtyping
...
Conflicts:
tests/baselines/reference/arrayLiteralWithMultipleBestCommonTypes.types
2014-10-20 11:33:23 -07:00
Anders Hejlsberg
04dad2cc22
Adding missing blank
2014-10-20 11:20:14 -07:00
Anders Hejlsberg
152a9402d0
Merge pull request #914 from Microsoft/parensInTypes
...
Parentheses in type literals
2014-10-20 09:43:07 -07:00
Anders Hejlsberg
40d12a0995
Accepting new baselines
2014-10-19 16:44:32 -07:00
Anders Hejlsberg
81eaae0afa
Require optional properties to be present in subtypes
...
Remove unused getBestCommonType method (unrelated change)
2014-10-19 16:43:32 -07:00
Anders Hejlsberg
f3bd294d0e
Adding tests
2014-10-19 07:57:10 -07:00
Anders Hejlsberg
b124b1d9e0
Formatting fixes
2014-10-19 07:21:55 -07:00
Anders Hejlsberg
91b3f16363
Removing doc\header.md from jakefile, fixing formatting
2014-10-18 17:36:34 -07:00
Anders Hejlsberg
91d746d114
Updating Language Specification
2014-10-18 17:11:54 -07:00
Anders Hejlsberg
e96983dd2b
Merge pull request #908 from Microsoft/contextualSignatureUnionTypes
...
Union types in contextual signature instantiations
2014-10-18 08:47:41 -07:00
Anders Hejlsberg
e5872b4824
Addressing CR feedback
2014-10-18 08:37:33 -07:00
Anders Hejlsberg
a58011c205
Fixing fourslash test
2014-10-18 07:44:22 -07:00
Jason Freeman
c20e4f53ea
Produce SignatureHelpParameters from type parameters for generic help
2014-10-17 17:03:45 -07:00
Jason Freeman
808ded88d6
Signature Help relies on display building routines in checker
2014-10-17 17:03:43 -07:00
Jason Freeman
628fa4c7b2
Remove OmittedType
2014-10-17 16:55:16 -07:00
Jason Freeman
464f2a0745
Split genericParameterHelp test into multiple tests
2014-10-17 16:55:14 -07:00
Jason Freeman
08f9a0148a
Parser changes to parse omitted types correctly
2014-10-17 16:55:11 -07:00
Jason Freeman
09f0755dc1
Reenable some basic generics tests
2014-10-17 16:55:09 -07:00
Jason Freeman
390b92dac0
Move getChildListThatStartsWithOpenerToken inside getSignatureHelpItems
2014-10-17 16:55:07 -07:00
Anders Hejlsberg
df715decbc
Changing type-to-string conversions to use parentheses
2014-10-17 16:53:18 -07:00
