20937 Commits

Author SHA1 Message Date
Daniel Rosenwasser
89b5d8cb14
Merge pull request #19204 from Kingwl/fix-completions-with-template-literal-type
fix completions for string literal types with template string (#19162)
2017-12-19 11:18:21 -08:00
csigs
1c4b9a5f2b
LEGO: Merge pull request 20781
LEGO: Merge pull request 20781
2017-12-19 09:10:36 -08:00
csigs
a23d38eed7 LEGO: check in for master to temporary branch. 2017-12-19 17:10:11 +00:00
Wesley Wigham
6c15fc6634
Fix devtools test (#20731)
* Fix devtools test

* Add small test case mimicing the issue from the user test
2017-12-18 14:47:45 -08:00
Andy
60bd262437
Don't treat class name as a completion list blocker if the position comes after it (#20762) 2017-12-18 12:41:05 -08:00
Andy
1562a278f8
Don't add completion for method if the this parameter doesn't match (#20616) 2017-12-18 11:28:04 -08:00
Andy
2efc92d1dc
Adjust formatting rule priority: Never delete space after case (#20615) 2017-12-18 10:54:54 -08:00
Andy
9a62454485
Include static 'this' accesses in references of class (#20483) 2017-12-18 10:54:22 -08:00
csigs
aa9e2ba318
LEGO: Merge pull request 20732
LEGO: Merge pull request 20732
2017-12-15 21:10:26 -08:00
csigs
31b2c11c15 LEGO: check in for master to temporary branch. 2017-12-16 05:10:04 +00:00
Andrew Casey
5e2dec7727
Merge pull request #20729 from amcasey/GH19839
Refine Extract Local
2017-12-15 16:51:25 -08:00
Andrew Casey
804949f744 Additional test case for contextual type check 2017-12-15 16:37:09 -08:00
Andrew Casey
08a9c61640 Update fourslash baseline 2017-12-15 16:31:27 -08:00
Wesley Wigham
ae73a9141d
Allow JSXAttributes types to be shortcut-spread into the spread type like normal objects (#19047)
* Bring jsx type resolution inline with normal objects, move jsx attribute property ignorign into relationship check

* Improved errors and reordered members

* Always use inferrential mode for jsx pass

* Add some missing skipLibChecks

* New check mode instead of odd type mapper

* Do not enable object literal freshness checks on jsx spreads

* Fix minor style nits

* Update order of type for test

* Accept corrected baseline
2017-12-15 16:13:28 -08:00
Wesley Wigham
dd933f4413
Fix get symbol at location to behave correctly for parameter assignments and jsx attributes (#20706)
* Fix get symbol at location to behave correctly got parameter assignments and jsx attributes

* Handle all those edge cases that weren;t explicitly handled

* Fix part of bug WRT getTypeAtLocation and for loops

* Baseline corrections pursuant to #20710

* Restore jsdoc tag interpretation

* Clean up some code, revert fourslash tests

* Cleanup types used by PR feedback
2017-12-15 15:50:22 -08:00
Andrew Casey
adc3234e46 Don't insert a blank line after extracted locals at the start of the file 2017-12-15 15:49:27 -08:00
Andrew Casey
129d1924be Regression test for GH #20727 2017-12-15 15:11:18 -08:00
Andrew Casey
9efab94dfd Annotate fewer extracted constants with types
Expose `isContextSensitive` from the checker and omit type annotations
for expressions for which it returns false.
2017-12-15 15:11:17 -08:00
Andrew Casey
e9ac87c2d6 Don't insert a blank line after extracted locals
Still insert a blank line after extracted properties.
2017-12-15 15:11:16 -08:00
Andrew Casey
a3ab1ffcff
Merge pull request #20713 from amcasey/GH19165
Stop assuming code fix test changes are in the originating file
2017-12-15 14:21:57 -08:00
Wesley Wigham
d89d68f426
make jsx attributes mutable locations (#20710) 2017-12-15 10:02:56 -08:00
csigs
d6192385a1
LEGO: Merge pull request 20720
LEGO: Merge pull request 20720
2017-12-15 03:10:50 -08:00
csigs
ed4bd2e5ab LEGO: check in for master to temporary branch. 2017-12-15 11:10:31 +00:00
Andrew Casey
8b0988543b Stop assuming code fix test changes are in the originating file
Triggering a fix in one file can result in changes in another file.
Instead of passing around the originating file, retrieve an appropriate
`ScriptInfo` for each `FileTextChanges`.

Fixes #19165
2017-12-14 16:50:28 -08:00
Josh Goldberg
423ab2e03d Removed colors devDependency (#20430)
* Replaced colors with chalk

* Used chalk's preferred import style
2017-12-14 16:05:25 -08:00
csigs
7d3eff8cdc
LEGO: Merge pull request 20708
LEGO: Merge pull request 20708
2017-12-14 15:10:56 -08:00
csigs
be1d6da123 LEGO: check in for master to temporary branch. 2017-12-14 23:10:37 +00:00
Benjamin Lichtman
26c1a49d59
Merge pull request #20640 from uniqueiniquity/revertToJsDocInclusionList
Revert to inclusion list for JsDoc comment completion
2017-12-14 14:37:31 -05:00
csigs
7d229aedec
LEGO: Merge pull request 20698
LEGO: Merge pull request 20698
2017-12-14 09:10:28 -08:00
csigs
f6a383e3e4 LEGO: check in for master to temporary branch. 2017-12-14 17:10:08 +00:00
csigs
ac091c2ca7
LEGO: Merge pull request 20693
LEGO: Merge pull request 20693
2017-12-14 03:10:58 -08:00
csigs
309468396d LEGO: check in for master to temporary branch. 2017-12-14 11:10:40 +00:00
csigs
2368ad7eef
LEGO: Merge pull request 20690
LEGO: Merge pull request 20690
2017-12-13 21:10:30 -08:00
csigs
064d9345e1 LEGO: check in for master to temporary branch. 2017-12-14 05:10:09 +00:00
csigs
f06d57174d
LEGO: Merge pull request 20687
LEGO: Merge pull request 20687
2017-12-13 15:11:10 -08:00
csigs
5299e91be3 LEGO: check in for master to temporary branch. 2017-12-13 23:10:50 +00:00
Wesley Wigham
e1278f091c
Get resolved module exports in symbol chain and not raw exports (#20661)
* Actually get module exports and not module exports sans export stars

* style update

* Trim test a bit
2017-12-13 14:01:23 -08:00
Wesley Wigham
2c6501db52
Allow multiple star-star globs in one pattern (#20639)
* Allow multiple starglobs in one pattern

* Add extra test case
2017-12-13 12:57:16 -08:00
Ryan Cavanaugh
f6603cd9f2
Merge pull request #20545 from RyanCavanaugh/codefixOmnibus
Omnibus fixes for telemetry-sourced crashes
2017-12-13 12:49:58 -08:00
Ryan Cavanaugh
8f8e6a36a7
Merge pull request #20679 from RyanCavanaugh/removeLibTodo
Remove TODO from lib.d.ts
2017-12-13 12:49:40 -08:00
Andy
84eb25c561
Handle arrays with properties in assert.deepEqual (#20674)
* Handle arrays with properties in assert.deepEqual

* Fix tests
2017-12-13 11:50:53 -08:00
Andy
6fbeced025
Simplify test case (#20675) 2017-12-13 11:03:37 -08:00
Ryan Cavanaugh
100262537a Remove TODO 2017-12-13 10:58:04 -08:00
Ryan Cavanaugh
65e92c624b
Merge pull request #20664 from RyanCavanaugh/clearResolutionCache
Clear the module resolution cache when new @types appear
2017-12-13 09:40:16 -08:00
Wesley Wigham
79a1240a19 Revert merge pull request #20429 (removing chai) (#20654)
* Revert "Merge pull request #20429 from Microsoft/unchai"

This reverts commit 66ec938164b61a7a9e14214f36bf58edc11c7609, reversing
changes made to 37a40561ac4c4cb1f970ade5fff2389d954593f6.

* Update lockfile
2017-12-13 06:49:50 -08:00
csigs
edb9e97ca7
LEGO: Merge pull request 20672
LEGO: Merge pull request 20672
2017-12-13 03:10:50 -08:00
csigs
7125cad406 LEGO: check in for master to temporary branch. 2017-12-13 11:10:32 +00:00
csigs
9ae67026d7
LEGO: Merge pull request 20666
LEGO: Merge pull request 20666
2017-12-12 21:10:29 -08:00
csigs
dbceefd05a LEGO: check in for master to temporary branch. 2017-12-13 05:10:08 +00:00
Ryan Cavanaugh
9e122d0305 Fix test 2017-12-12 17:22:41 -08:00