Commit Graph

12745 Commits

Author SHA1 Message Date
Mohamed Hegazy
78f259340a Merge branch 'master' into release-2.0 2016-08-18 16:17:18 -07:00
Mohamed Hegazy
c7c3158ef3 Update LKG 2016-08-18 15:05:43 -07:00
Mohamed Hegazy
b10c2baaf3 Update version to 2.0.2 2016-08-18 14:53:04 -07:00
Yui
1d9124eb7c [Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction

* Remove unnecessary subtype reduction operations

* Use binary searching in union types to improve performance

* Optimize type inference

* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)

* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)

* Fix typo in comment for MAX_SAFE_INTEGER

* In ts.performance.now, bind window.performance.now

Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.

* Add lint enforcing line endings (#9942)

* Add servicesSources to the list of prerequisites for running tests

* Support emitting static properties for classes with no name

* Add assertion whitespace lint rule (#9931)

* Add assertion whitespace lint rule

* Fix typo

* Add the word `Rule` to Jakefile

* Limit travis build matrix (#9968)

* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)

* Convert getErrorBaseline to use canonical diagnostic formatting

* Fix lint

* Found another clone of format diagnostic - consolidate

* Fully declone

* Unify nodeKind implementations for navigationBar and navigateTo

* Fix test and rename a function

* Fix lint errors

* Remove hardcoded port, use the custom port

* Unlock ts-node version (#9960)

* Allow an abstract class to appear in a local scope

* JSDoc understands string literal types

Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.

* Update baselines to be current

* Add find and findIndex to ReadonlyArray

* The optional this should be readonly too.

* Update baseline source location

* Re-add concat overload to support inferring tuples

* Update baselines with new concat overload

* Update LastJSDoc[Tag]Node

* Display enum member types using qualified names

* Accept new baselines

* Fix lint error

* null/undefined are allowed as index expressions

`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.

* Use correct nullable terminology

* Get rid of port parameter

* Remove [port] in usage message

* Properly reset type guards in loops

* Add regression test

* Introduce the `EntityNameExpression` type

* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.

* Lint tests helper files

* recreate program if baseUrl or paths changed in tsconfig

* Simplify some code

* Have travis use a newer image for the OSX build (#10034)

Suggested by travis support for stopping the randomly-halting-builds issue.

* Correctly check for ambient class flag

* Use "best choice type" for || and ?: operators

* jsx opening element formatting

* change error message for unused parameter property

fix

* Fix issue related to this and #8383

* Add additional tests

* Accept new baselines

* Provide `realpath` for module resolution in LSHost

* Add test

* Add test baselines

* Accept new baselines

* CR feedback

* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.

* Fix bug

* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)

* Use recursion, and fix error for undefined node

* Rename function

* Fix lint error

* Narrowing type parameter intersects w/narrowed types

This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.

* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.

* Limit type guards as assertions to incomplete types in loops

* Accept new baselines

* Fix linting error

* Allow JS multiple declarations of ctor properties

When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.

* Use {} type facts for unconstrained type params

Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.

* Fix newline lint

* Test that declares conflicting method first

* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)

* Change the shape of the shim layer to support getAutomaticTypeDirectives

* Change the key for looking up automatic type-directives

* Update baselines from change look-up name of type-directives

* Add @currentDirectory into the test

* Update baselines

* Fix linting error

* Address PR: fix spelling mistake

* Instead of return path of the type directive names just return type directive names

* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)

* Add string-literal completion test for jsdoc

* Support other (new) literal types in jsdoc

* Don't allow properties inherited from Object to be automatically included in TSX attributes

* Add new test baseline and delete else in binder

The extra `else` caused a ton of test failures!

* Fix lint

* Port PR #10016 to Master (#10100)

* Treat namespaceExportDeclaration as declaration

* Update baselines

* wip - add tests

* Add tests

* Show "export namespace" for quick-info

* Fix more lint

* Try using runtests-parallel for CI (#9970)

* Try using runtests-parallel for CI

* Put worker count setting into .travis.yml

* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts

* Fix lssl task (#9967)

* Surface noErrorTruncation option

* Stricter check for discriminant properties in type guards

* Add tests

* Emit more efficient/concise "empty" ES6 ctor

When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:

```ts
class Foo extends Bar {
  public foo = 1;
}
```

```js
class Foo extends Bar {
  constructor(…args) {
    super(…args);
    this.foo = 1;
  }
}
```

This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).

This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:


```js
var Foo = (function (_Bar) {
  _inherits(Foo, _Bar);

  function Foo() {
    _classCallCheck(this, Foo);

    for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
      args[_key] = arguments[_key];
    }

    _Bar.call.apply(_Bar, [this].concat(args));
    this.foo = 1;
  }

  return Foo;
})(Bar);
```

This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).

Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:


```js
class Foo extends Bar {
  constructor() {
    super(…arguments);
    this.foo = 1;
  }
}
```

Which compiles into the following in Babel:

```js
var Foo = (function (_Bar) {
  _inherits(Foo, _Bar);

  function Foo() {
    _classCallCheck(this, Foo);

    _Bar.apply(this, arguments);
    this.foo = 1;
  }

  return Foo;
})(Bar);
```

Which is well-optimized (today) in most engines and much less confusing
to read.

As far as I can tell, the proposed compilation has exactly the same
semantics as before.

Fixes #10175

* Fix instanceof operator narrowing issues

* Accept new baselines

* Add regression test

* Improve naming and documentation from PR

* Update comment

* Add more tests

* Accept new baselines

* Reduce worker count to 3 (#10210)

Since we saw a starvation issue on one of @sandersn's PRs.

* Speed up fourslash tests

* Duh

* Make baselines faster by not writing out unneeded files

* Fix non-strict-compliant test

* Fix 10076: Fix Tuple Destructing with "this" (#10208)

* Call checkExpression eventhough there is no appropriate type from destructuring of array

* Add tests and baselines

* use transpileModule

* Remove use strict

* Improve instanceof for structurally identical types

* Introduce isTypeInstanceOf function

* Add test

* Accept new baselines

* Fix loop over array to use for-of instead of for-in

* Use correct this in tuple type parameter constraints

Instantiate this in tuple types used as type parameter constraints

* Add explanatory comment to resolveTupleTypeMembers

* Ignore null, undefined, void when checking for discriminant property

* Add regression test

* Delay tuple type constraint resolution

Create a new tuple that stores the this-type.

* Always use thisType when generating tuple id

* Optimize format of type list id strings used in maps

* Make ReadonlyArray iterable.

* Allow OSX to fail while we investigate (#10255)

The random test timeouts are an issue.

* avoid using the global name

* Fix single-quote lint

* Optimize performance of maps

* Update API sample

* Fix processDiagnosticMessages script

* Have travis take shallow clones of the repo (#10275)

Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.

We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.

* Add folds to travis log (#10269)

* Optimize filterType to only call getUnionType if necessary

* Add shorthand types declaration for travis-fold (#10293)

* Optimize getTypeWithFacts

* Filter out nullable and primitive types in isDiscriminantProperty

* Fix typo

* Add regression tests

* Optimize core filter function to only allocate when necessary

* Address CR comments + more optimizations

* Faster path for creating union types from filterType

* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.

* Lint

* Collect timing information for commands running on travis (#10308)

* Simplifies performance API

* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.

* narrow from 'any' in most situations

instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.

* Update instanceof conformance tests

* accept new baselines

* add tests

* accept new baselines

* Use lowercase names for type reference directives

* Use proper response codes in web tests

* Treat ambient shorthand declarations as explicit uses of the `any` type

* Parallel linting (#10313)

* A perilous thing, a parallel lint

* Use work queue rather than scheduling work

* Dont read files for lint on main thread

* Fix style

* Fix the style fix (#10344)

* Aligned mark names with values used by ts-perf.

* Use an enum in checkClassForDuplicateDeclarations to aid readability

* Rename to Accessor

* Correctly update package.json version

* Migrated more MapLikes to Maps

* Add ES2015 Date constructor signature that accepts another Date (#10353)

* Parameters with no assignments implicitly considered const

* Add tests

* Migrate additional MapLikes to Maps.

* Fix 10625: JSX Not validating when index signature is present  (#10352)

* Check for type of property declaration before using index signature

* Add tests and baselines

* fix linting error

* Adding more comments

* Clean up/move some Map helper functions.

* Revert some formatting changes.

* Improve ReadonlyArray<T>.concat to match Array<T>

The Array-based signature was incorrect and also out-of-date.

* Fix link to blog

* Remove old assertion about when we're allowed to use fileExists

* Set isNewIdentifierLocation to true for JavaScript files

* Update error message for conflicting type definitions

Fixes #10370

* Explain why we lower-case type reference directives

* Correctly merge bindThisPropertyAssignment

Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.

* Fix comment

* Property handle imcomplete control flow types in nested loops

* Update due to CR suggestion

* Add regression test

* Fix 10289: correctly generate tsconfig.json with --lib (#10355)

* Separate generate tsconfig into its own function and implement init with --lib

# Conflicts:
#	src/compiler/tsc.ts

* Add tests and baselines; Update function name

Add unittests and baselines
Add unittests and baselines for generating tsconfig

Move unittest into harness folder

Update harness tsconfig.json

USe correct function name

* Use new MapLike interstead. Update unittest

# Conflicts:
#	src/compiler/commandLineParser.ts

* Update JakeFile

* Add tests for incorrect cases

* Address PR : remove explicity write node_modules

* Add more tests for `export = foo.bar`.

* Output test baselines to tests/baselines/local instead of root
2016-08-18 14:49:09 -07:00
Yui
b8963ba8f1 Fix RWC Runner (#10420)
* Use /// <reference types

* Don't report an errors if it comes from lib.d.ts
2016-08-18 14:39:15 -07:00
Daniel Rosenwasser
d830034a3d Merge pull request #10404 from Microsoft/addCommentForEmptyCtorEmit
Restored comments to explain spreading 'arguments' into 'super' calls
2016-08-18 14:03:31 -07:00
Daniel Rosenwasser
6facbf1e90 Merge pull request #10403 from Microsoft/completionsForNullableObjects
Fix completions for nullable objects
2016-08-18 14:00:30 -07:00
Ryan Cavanaugh
f57b0fbb98 Merge pull request #10415 from Microsoft/baseline_local_path
Output test baselines to tests/baselines/local instead of root
2016-08-18 09:19:21 -07:00
Andy
4e40b7564d Merge pull request #10413 from Microsoft/export_equals_property_test
Add more tests for `export = foo.bar`.
2016-08-18 09:02:24 -07:00
Andy Hanson
67b6c56ee8 Output test baselines to tests/baselines/local instead of root 2016-08-18 07:44:20 -07:00
Andy Hanson
2e572201fd Add more tests for export = foo.bar. 2016-08-18 07:38:20 -07:00
Daniel Rosenwasser
c1e70c97c0 Use the non-nullable type of the contextual type for object completions. 2016-08-17 20:49:21 -07:00
Daniel Rosenwasser
111b7c55f8 Added test. 2016-08-17 20:30:15 -07:00
Daniel Rosenwasser
73a857b306 Restored comments to explain spreading 'arguments' into calls to 'super'. 2016-08-17 18:10:06 -07:00
Yui
da8fc5d5a9 Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib

# Conflicts:
#	src/compiler/tsc.ts

* Add tests and baselines; Update function name

Add unittests and baselines
Add unittests and baselines for generating tsconfig

Move unittest into harness folder

Update harness tsconfig.json

USe correct function name

* Use new MapLike interstead. Update unittest

# Conflicts:
#	src/compiler/commandLineParser.ts

* Update JakeFile

* Add tests for incorrect cases

* Address PR : remove explicity write node_modules
2016-08-17 15:23:28 -07:00
Mohamed Hegazy
73a64888f0 Merge branch 'gcnew-noErrorTruncation' 2016-08-17 14:22:12 -07:00
Mohamed Hegazy
5843bbbd76 Merge branch 'noErrorTruncation' of https://github.com/gcnew/TypeScript into gcnew-noErrorTruncation
# Conflicts:
#	src/compiler/diagnosticMessages.json
2016-08-17 14:22:01 -07:00
Anders Hejlsberg
4880e7ea9e Merge pull request #10396 from Microsoft/fixNestedLoopTypeGuards
Fix nested loop type guards
2016-08-17 14:05:02 -07:00
jramsay
7a9f8c8798 Merge pull request #10391 from Microsoft/SetIsNewIdentifierLocationToTrueForJS
Set isNewIdentifierLocation to true for JavaScript files
2016-08-17 13:58:21 -07:00
Mohamed Hegazy
ef2d6ab014 Merge pull request #10342 from Microsoft/ambient_shorthand_is_explicit_any
Treat ambient shorthand declarations as explicit uses of the `any` type
2016-08-17 13:33:13 -07:00
Anders Hejlsberg
b93cdecdf5 Add regression test 2016-08-17 13:30:13 -07:00
Jason Ramsay
44476f1984 Update due to CR suggestion 2016-08-17 13:30:03 -07:00
Anders Hejlsberg
2d1639fac8 Property handle imcomplete control flow types in nested loops 2016-08-17 13:30:03 -07:00
Ryan Cavanaugh
bf63811e1f Merge pull request #10213 from RyanCavanaugh/baselinePerf
Make baselines faster by not writing out unneeded files
2016-08-17 11:13:18 -07:00
Nathan Shively-Sanders
9769718a38 Merge pull request #10123 from Microsoft/allow-js-multiple-declaration-of-constructor-properties
Allow JS multiple declarations of ctor properties
2016-08-17 10:58:50 -07:00
Nathan Shively-Sanders
c73efe2fb6 Fix comment 2016-08-17 10:45:35 -07:00
Nathan Shively-Sanders
07a8f31a2d Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
2016-08-17 10:43:02 -07:00
Mohamed Hegazy
09bc2e6b41 Merge pull request #10387 from Microsoft/comment_process_type_reference_directives
Explain why we lower-case type reference directives
2016-08-17 10:28:29 -07:00
Nathan Shively-Sanders
c218d37191 Merge pull request #9995 from Microsoft/jsdoc-string-literal-types
JSDoc string literal types
2016-08-17 10:25:58 -07:00
Nathan Shively-Sanders
96840c3669 Merge branch 'master' into allow-js-multiple-declaration-of-constructor-properties 2016-08-17 09:04:10 -07:00
Nathan Shively-Sanders
000637156a Merge pull request #10374 from Microsoft/readonly-array-type-argument-assignability
Improve ReadonlyArray<T>.concat to match Array<T>
2016-08-17 08:28:38 -07:00
Andy Hanson
c42f1cb0d0 Explain why we lower-case type reference directives 2016-08-17 06:21:49 -07:00
Andy
c9d1f0d150 Merge pull request #10376 from Microsoft/remove_file_exists_assertion
Remove old assertion about when we're allowed to use fileExists
2016-08-17 06:04:33 -07:00
Andy
ef4fefc197 Merge pull request #10340 from Microsoft/lower_case_types
Use lowercase names for type reference directives
2016-08-17 06:04:14 -07:00
Ron Buckton
11c5c4ee8e Merge pull request #10359 from Microsoft/optimizeMoreMaps
Migrate more MapLikes to Maps
2016-08-16 20:11:35 -07:00
Mohamed Hegazy
c4d1f1509e Merge pull request #10375 from Microsoft/fix_blog_link
Fix link to blog
2016-08-16 17:23:36 -07:00
Anders Hejlsberg
905957d463 Merge pull request #10357 from Microsoft/implicitConstParameters
Implicit const parameters
2016-08-16 15:53:13 -07:00
Nathan Shively-Sanders
01aaff7247 Merge pull request #10009 from Microsoft/null-undefined-allowed-as-index-expressions
`Null` and `undefined` are allowed as index expressions
2016-08-16 15:46:42 -07:00
Daniel Rosenwasser
9cc8b2ebb2 Merge pull request #10189 from chancancode/constructor-splat-arguments
Emit more efficient/concise "empty" ES6 ctor
2016-08-16 15:39:11 -07:00
Ryan Cavanaugh
2a62917ac6 Merge pull request #10377 from RyanCavanaugh/fix10370
Update error message for conflicting type definitions
2016-08-16 14:27:30 -07:00
Ryan Cavanaugh
a36e15558e Update error message for conflicting type definitions
Fixes #10370
2016-08-16 14:04:02 -07:00
Jason Ramsay
a66b38af56 Set isNewIdentifierLocation to true for JavaScript files 2016-08-16 13:59:13 -07:00
Andy Hanson
a6974474a1 Remove old assertion about when we're allowed to use fileExists 2016-08-16 13:51:17 -07:00
Andy Hanson
dcf3946b68 Fix link to blog 2016-08-16 11:31:32 -07:00
Nathan Shively-Sanders
ce5e2078ee Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
2016-08-16 11:29:09 -07:00
Ron Buckton
c0146556e8 Revert some formatting changes. 2016-08-16 11:18:24 -07:00
Ron Buckton
889e5ac7ae Clean up/move some Map helper functions. 2016-08-16 11:15:15 -07:00
Anders Hejlsberg
5770157504 Adding more comments 2016-08-16 09:41:33 -07:00
Yui
f7f50073d3 Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature

* Add tests and baselines

* fix linting error
2016-08-16 08:47:21 -07:00
Ron Buckton
1dc495adf8 Migrate additional MapLikes to Maps. 2016-08-15 16:41:32 -07:00