10919 Commits

Author SHA1 Message Date
Andy
74f01abfcf
Clean up findPrecedingToken and avoid returning whitespace-only jsx text token (#21903) 2018-02-12 14:42:16 -08:00
Anders Hejlsberg
d07523e9e5
Merge pull request #21866 from Microsoft/fixIndexedAccessWildcard
Fix indexed access issue with conditional types
2018-02-12 14:18:44 -08:00
Adrian Leonhard
6ab5d97a5d Changed "Duplicate Identifier" to "enum cannot be merged..." (#18579)
* Changed "Duplicate Identifier" to "enum can only be merged..."
when either declaration of the identifier is an enum.

Partial (?) fix for #529

Not sure if the new test is necessary, all the cases seem to have been covered by others tests.

* picked a nit
2018-02-12 13:38:08 -08:00
Ron Buckton
2ff8fae5da
Merge pull request #21900 from Microsoft/fix21620
Fix emit when binder treats exported const as namespace
2018-02-12 13:34:54 -08:00
Ron Buckton
7a6a0673df
Merge pull request #21897 from Microsoft/fix21626
Fix duplicate label in es2017 async function
2018-02-12 13:04:39 -08:00
Ron Buckton
c84b7caa25 Fix emit when binder treats exported const as namespace 2018-02-12 13:02:47 -08:00
Ron Buckton
641f787006
Merge pull request #21896 from Microsoft/fix21878
Revert BOM emit change
2018-02-12 12:31:12 -08:00
Ron Buckton
6736ced51d Fix duplicate label in es2017 async function 2018-02-12 12:30:29 -08:00
Ron Buckton
ea8f5158c2 Revert BOM emit change 2018-02-12 12:02:34 -08:00
Andy
fca3db440c
Give MethodDeclaration and MethodSignature parent types (#21892)
* Give MethodDeclaration and MethodSignature parent types
* And fix code that used MethodDeclaration for parameter that might be a MethodSignature

* Move type check back inside checkGrammarArrowFunction
2018-02-12 11:56:44 -08:00
Andy
2d80253d09
Fix error message for implicit-any property in object literal with symbol key (#21883) 2018-02-12 11:09:50 -08:00
jack-williams
67984c720e Fix #21848: Allows to mutate const with non-null assertion (#21873) 2018-02-12 10:57:59 -08:00
Anders Hejlsberg
0a35ad7aa5 Merge branch 'master' into fixIndexedAccessWildcard 2018-02-12 10:55:25 -08:00
Mohamed Hegazy
3fb481ff40
Multiple telemetry debug assert failure fixes (#21886)
* Use getAllowSyntheticDefaultImports to access `--allowSyntheticDefaultImport` value

* Fix #21788: Handel missing imporotClause case

* Fix #21789: Add a defensive check to forgottenThisPropertyAccess code fix for non-identifier locations

* Do not suggest prefix with `this` if the name we are looking for is diffrent from the errorLocation

* Fix #21796: Handel case of unknown module

* Add check to capture more info for #21800

* Fix #21807: check for symbol before looking up its flags

* Fix #21812: Gracefully fail if the token is not `this`.
2018-02-12 10:34:17 -08:00
Anders Hejlsberg
318e53cecb Merge branch 'master' into fixIndexedAccessWildcard
# Conflicts:
#	tests/baselines/reference/conditionalTypes1.errors.txt
#	tests/baselines/reference/conditionalTypes1.js
#	tests/baselines/reference/conditionalTypes1.symbols
#	tests/baselines/reference/conditionalTypes1.types
#	tests/cases/conformance/types/conditional/conditionalTypes1.ts
2018-02-10 17:29:06 -08:00
Anders Hejlsberg
9189354713 Wildcard instantiation of indexed access should be wildcard 2018-02-10 17:10:32 -08:00
Anders Hejlsberg
fadf031088 Merge branch 'master' into fixStructuralIdentity
# Conflicts:
#	tests/baselines/reference/conditionalTypes1.errors.txt
#	tests/baselines/reference/conditionalTypes1.js
#	tests/baselines/reference/conditionalTypes1.symbols
#	tests/baselines/reference/conditionalTypes1.types
#	tests/cases/conformance/types/conditional/conditionalTypes1.ts
2018-02-09 16:16:02 -08:00
Benjamin Lichtman
f989ef7261
Merge pull request #21004 from uniqueiniquity/updateATA
Enable typings cache entries to expire and be updated
2018-02-09 14:17:26 -08:00
Andy
171b68c9e7
Add assertions for bad symbol declaration (#21837)
* Add assertions for bad symbol declaration

* Fix lint
2018-02-09 14:08:56 -08:00
Anders Hejlsberg
57351e898e Add higher order structural identity relations 2018-02-09 13:02:07 -08:00
Anders Hejlsberg
868a9ee117
Merge pull request #21782 from Microsoft/fixIdenticalConditionalTypes
Compatibility of identical conditional types
2018-02-08 17:38:31 -08:00
Anders Hejlsberg
a9251723c7 Properly detect identical conditional types in caching logic 2018-02-08 17:10:25 -08:00
Andy
e2178ecfab
In getSymbolAtLocation, return undefined instead of unknownSymbol (#21774)
* In getSymbolAtLocation, return undefined instead of unknownSymbol

* Update check in completions to look for undefined instead of unknownSymbol
2018-02-08 14:35:21 -08:00
Nathan Shively-Sanders
37f15ccb41
Print deferred mapped symbols 1 level deep (#21311)
* Print deferred mapped symbols 1 level deep

Previously, deferred mapped symbols would not print their type at all;
it would always print as `any`. This differed from the older behaviour
that printed it forever if necessary. As a compromise, we now print
deferred mapped symbosl 1 level deep before giving up and printing
`any`. This should cover the most common uses of mapped types.

* Use context flags instead of a global
2018-02-08 13:35:00 -08:00
Mohamed Hegazy
4150a463e2
Fix #20805 (#21755)
* Add `-dev` to version patch number in master

* Refactor to handel non-identifier tokens for UMD modules

* Be more graceful handeling non-identifier tokens in import fixes

* Fix bad merge

* Remove check for isIdentifier
2018-02-08 10:32:08 -08:00
Andy
2a17825428
completions: Add assertions that symbols are defined (#21764)
* completions: Add assertions that symbols are defined

* Add assertion messages
2018-02-08 10:20:01 -08:00
Sheetal Nandi
353cfbddc6
Merge pull request #21750 from Microsoft/memberCompletionOfUnknownRightSideOfImport
Fix the member completion returned on right side of the import when it does not resolve to any symbol
2018-02-08 10:07:12 -08:00
Andy
28c4871c99
hasSameKeys: Simplify and optimize for identical maps (#21763) 2018-02-08 09:45:43 -08:00
Mohamed Hegazy
384527aa09
Add -dev to version patch number in master (#21741) 2018-02-07 23:45:37 -08:00
Wesley Wigham
871e71d4ef
Move insertSorted from server to core, use for diagnostic collections (#21401)
* Move insertSorted from server to core, use for diagnostic collections

* All keep the overall list sorted, too

* Increase timeout for js verification

* Use knowledge of how diagnostics are sorted to make all diagnostic list creation lazy and more efficient

* Staunchly avoid array allocation in favor of resizing an existing array
2018-02-07 17:00:59 -08:00
Anders Hejlsberg
22fbb8edce
Merge pull request #21744 from Microsoft/fixGetConstrainedTypeParameter
Fix getConstrainedTypeParameter function
2018-02-07 16:37:10 -08:00
Sheetal Nandi
5b1f29c722 Fix the member completion returned on right side of the import when it does not resolve to any symbol
Fixes #20794
2018-02-07 15:44:22 -08:00
Anders Hejlsberg
7ad8182af2
Merge pull request #21737 from Microsoft/fixDeferredConditional
Fix definitely false check in conditional types
2018-02-07 14:59:40 -08:00
Anders Hejlsberg
22cbfe3b1b Fix getConstrainedTypeParameter function 2018-02-07 14:48:13 -08:00
Anders Hejlsberg
3d9981221d
Merge pull request #21709 from Microsoft/inferredTypeParameterConstraints
Inferred type parameter constraints
2018-02-07 13:16:07 -08:00
Alan Agius
3893ed498f fix: matchedText module resolution incorrect length (#21647)
* fix: `matchedText` was not properly extract the correct parts from the candidate

closes: #21636

* core: replace `substr` with `substring` in `matchedText`

* test: remove redundant code from tests
2018-02-07 12:54:37 -08:00
Anders Hejlsberg
a0e12c7b75 Use typeMaybeAssignableTo in definitely false check 2018-02-07 12:48:44 -08:00
Sheetal Nandi
3b1a3f8a4d
Merge pull request #21693 from Microsoft/fileChangeThroughDeleteAndCreate
Handle file versioning little better in tsc --watch mode
2018-02-07 10:24:27 -08:00
Andy
017f30eaf4
isValidPropertyAccessWithType: Simplify loop (#21725) 2018-02-07 10:23:36 -08:00
Sheetal Nandi
82aa1fbbe4 Get new line before writing log to log correct output 2018-02-07 09:21:38 -08:00
Anders Hejlsberg
a44ab96468 Discard constraint inferences of the type parameter itself 2018-02-07 06:57:23 -08:00
Anders Hejlsberg
e62abbb9f8 Instantiate inferred type parameter constraints 2018-02-06 17:21:18 -08:00
Sheetal Nandi
22c0444814 Missing files are versions are stored as number 2018-02-06 13:48:09 -08:00
Anders Hejlsberg
8885d7941c Infer constraints for 'infer T' declarations nested in type references 2018-02-06 13:24:53 -08:00
Sheetal Nandi
2684784545 Handle source file versioning better since the emit depends on it
This ensures that when file is deleted and re-created, the file version isnt same to ensure emits correctly
Fixes #21444
2018-02-06 12:30:13 -08:00
Anders Hejlsberg
bb28444f8c Handle all instantiable non-primitive types in homomorphic mapped types 2018-02-06 12:27:35 -08:00
Ron Buckton
3b73ce49d7
Merge pull request #21585 from Microsoft/fix21584
Fix initializer assignability for unique symbol
2018-02-06 11:30:12 -08:00
Wesley Wigham
17554ff285
Fix JSX contextual types to not eagerly become apparent, use 2-pass inference for JSX (#21383)
* Fix JSX contextual types to not eagerly become apparent

* Apply changes from code review, unify common code

* Fix jsx children contextual typing

* Light code review feedback

* Use fillMissingTypeArguments

* Accept nonliteral jsx child type

* Add test for the fillMissingTypeArguments case
2018-02-05 16:33:39 -08:00
Anders Hejlsberg
3b220a8b0f
Merge pull request #21649 from Microsoft/conditionalTypesASI
Conditional types ASI
2018-02-05 16:21:34 -08:00
Mohamed Hegazy
8f8fec433e
Rename switch --emitDeclarationsOnly to --emitDeclarationOnly (#21651)
* Rename `--emitDeclarationsOnly` to `--renameDeclarationOnly`

* Rename test files
2018-02-05 14:48:50 -08:00