21766 Commits

Author SHA1 Message Date
Andy
74f01abfcf
Clean up findPrecedingToken and avoid returning whitespace-only jsx text token (#21903) 2018-02-12 14:42:16 -08:00
Anders Hejlsberg
d07523e9e5
Merge pull request #21866 from Microsoft/fixIndexedAccessWildcard
Fix indexed access issue with conditional types
2018-02-12 14:18:44 -08:00
Adrian Leonhard
6ab5d97a5d Changed "Duplicate Identifier" to "enum cannot be merged..." (#18579)
* Changed "Duplicate Identifier" to "enum can only be merged..."
when either declaration of the identifier is an enum.

Partial (?) fix for #529

Not sure if the new test is necessary, all the cases seem to have been covered by others tests.

* picked a nit
2018-02-12 13:38:08 -08:00
Ron Buckton
2ff8fae5da
Merge pull request #21900 from Microsoft/fix21620
Fix emit when binder treats exported const as namespace
2018-02-12 13:34:54 -08:00
Andy
458c12fa78
importFixes: Fix bug by using replaceNode and removing changeIdentifierToPropertyAccess (#21898) 2018-02-12 13:05:40 -08:00
Andy
20a6be67a0
Clarify assumptions in verifyImportFixAtPosition (#21899) 2018-02-12 13:05:13 -08:00
Ron Buckton
7a6a0673df
Merge pull request #21897 from Microsoft/fix21626
Fix duplicate label in es2017 async function
2018-02-12 13:04:39 -08:00
Ron Buckton
c84b7caa25 Fix emit when binder treats exported const as namespace 2018-02-12 13:02:47 -08:00
Ron Buckton
641f787006
Merge pull request #21896 from Microsoft/fix21878
Revert BOM emit change
2018-02-12 12:31:12 -08:00
Ron Buckton
6736ced51d Fix duplicate label in es2017 async function 2018-02-12 12:30:29 -08:00
Sheetal Nandi
2305f7b22a
Merge pull request #21895 from Microsoft/jsxTagCompletion
Fix completion of jsx attributes in self closing element
2018-02-12 12:28:57 -08:00
Ron Buckton
ea8f5158c2 Revert BOM emit change 2018-02-12 12:02:34 -08:00
Sheetal Nandi
d6d9953f6d Fix completion of jsx attributes in self closing element
Fixes #21844
2018-02-12 11:57:20 -08:00
Andy
fca3db440c
Give MethodDeclaration and MethodSignature parent types (#21892)
* Give MethodDeclaration and MethodSignature parent types
* And fix code that used MethodDeclaration for parameter that might be a MethodSignature

* Move type check back inside checkGrammarArrowFunction
2018-02-12 11:56:44 -08:00
Mohamed Hegazy
c9a0b7ec5b
Port generated lib files (#21889) 2018-02-12 11:53:03 -08:00
Andy
fcf348610c
documentHighlights: Handle some invalid modifier locations (#21893) 2018-02-12 11:34:49 -08:00
Andy
2d80253d09
Fix error message for implicit-any property in object literal with symbol key (#21883) 2018-02-12 11:09:50 -08:00
jack-williams
67984c720e Fix #21848: Allows to mutate const with non-null assertion (#21873) 2018-02-12 10:57:59 -08:00
Anders Hejlsberg
0a35ad7aa5 Merge branch 'master' into fixIndexedAccessWildcard 2018-02-12 10:55:25 -08:00
Andrew Casey
ddf206b184
Merge pull request #21845 from amcasey/GH21793
Harden Extract Symbol against symbols without declarations
2018-02-12 10:40:31 -08:00
Mohamed Hegazy
3fb481ff40
Multiple telemetry debug assert failure fixes (#21886)
* Use getAllowSyntheticDefaultImports to access `--allowSyntheticDefaultImport` value

* Fix #21788: Handel missing imporotClause case

* Fix #21789: Add a defensive check to forgottenThisPropertyAccess code fix for non-identifier locations

* Do not suggest prefix with `this` if the name we are looking for is diffrent from the errorLocation

* Fix #21796: Handel case of unknown module

* Add check to capture more info for #21800

* Fix #21807: check for symbol before looking up its flags

* Fix #21812: Gracefully fail if the token is not `this`.
2018-02-12 10:34:17 -08:00
Anders Hejlsberg
318e53cecb Merge branch 'master' into fixIndexedAccessWildcard
# Conflicts:
#	tests/baselines/reference/conditionalTypes1.errors.txt
#	tests/baselines/reference/conditionalTypes1.js
#	tests/baselines/reference/conditionalTypes1.symbols
#	tests/baselines/reference/conditionalTypes1.types
#	tests/cases/conformance/types/conditional/conditionalTypes1.ts
2018-02-10 17:29:06 -08:00
Anders Hejlsberg
611ebc7aad
Merge pull request #21839 from Microsoft/fixStructuralIdentity
Fix structural identity relations
2018-02-10 17:14:40 -08:00
Anders Hejlsberg
071ee915ca Accept new baselines 2018-02-10 17:11:02 -08:00
Anders Hejlsberg
2e1dcd666c Add regression test 2018-02-10 17:10:44 -08:00
Anders Hejlsberg
9189354713 Wildcard instantiation of indexed access should be wildcard 2018-02-10 17:10:32 -08:00
Eric Grube
879cb69d6a add beautifier rule for space after close paren and destructure bracket (#21859) 2018-02-10 12:45:54 -08:00
Josh Goldberg
02e7696759 PR template typo: labeled / labelled (#21854) 2018-02-10 12:44:01 -08:00
Priyantha Lankapura
a732ff6b35 Add type infer formatting (#21850)
* add test for type infer formatting

* Fix type infer formatting

* update test to use condtional
2018-02-10 12:36:04 -08:00
csigs
d9fefd4f82
LEGO: Merge pull request 21857
LEGO: Merge pull request 21857
2018-02-10 03:10:41 -08:00
csigs
9b65a7dfe1 LEGO: check in for master to temporary branch. 2018-02-10 11:10:20 +00:00
Andrew Casey
e65a1a429c Harden Extract Symbol against symbols without declarations
Fixes #21793
2018-02-09 19:42:34 -08:00
Andrew Casey
57d94b9661
Merge pull request #21849 from amcasey/GH21816
Handle class declarations without names in Extract Symbol
2018-02-09 19:39:02 -08:00
Andrew Casey
025418fdb0 Handle class declarations without names in Extract Symbol
Fixes #21816
2018-02-09 19:09:25 -08:00
Andrew Casey
22c4862d9e
Merge pull request #21835 from amcasey/GH21786
Handle variable declaration without initializer in Convert to ES6 Module
2018-02-09 18:21:50 -08:00
Andrew Casey
d99cd05c63
Merge pull request #21833 from amcasey/TextChangesRange
Call replaceNode rather than replaceRange
2018-02-09 18:21:32 -08:00
Andrew Casey
1baae42149 Handle variable declaration without initializer in Convert to ES6 Module
Fixes #21786
2018-02-09 18:08:47 -08:00
Andrew Casey
ab5596e785 Call replaceNode rather than replaceRange
...where convenient.  Same for deleteNode/Range.
2018-02-09 17:51:28 -08:00
Andrew Casey
ad68fa88a7
Merge pull request #21832 from amcasey/TextChangesSeparator
Eliminate ChangeMultipleNodesOptions in favor of smart separators
2018-02-09 17:00:16 -08:00
Anders Hejlsberg
fadf031088 Merge branch 'master' into fixStructuralIdentity
# Conflicts:
#	tests/baselines/reference/conditionalTypes1.errors.txt
#	tests/baselines/reference/conditionalTypes1.js
#	tests/baselines/reference/conditionalTypes1.symbols
#	tests/baselines/reference/conditionalTypes1.types
#	tests/cases/conformance/types/conditional/conditionalTypes1.ts
2018-02-09 16:16:02 -08:00
Andrew Casey
8d1f316414 Eliminate ChangeMultipleNodesOptions in favor of smart separators 2018-02-09 16:06:14 -08:00
Anders Hejlsberg
f1d7afe760
Merge pull request #21847 from Microsoft/predefinedConditionalTypes
Predefined conditional types
2018-02-09 15:39:58 -08:00
Andy
49e78f68d2
findAllRefs: Fix bug for export not at top-level of a module/namespace (#21846) 2018-02-09 15:10:34 -08:00
Andy
425a4182a3
Handle empty declaration list in Convert to ES6 Module (#21843)
* Handle empty declaration list in Convert to ES6 Module

* Fix test
2018-02-09 14:46:57 -08:00
Anders Hejlsberg
11a075c289 Accept new baselines 2018-02-09 14:23:19 -08:00
Anders Hejlsberg
92b8ce7821 Update tests 2018-02-09 14:22:57 -08:00
Anders Hejlsberg
2aba29fc32 Add Exclude, Extract, NonNullable, ReturnType, and InstanceType types 2018-02-09 14:22:46 -08:00
Benjamin Lichtman
f989ef7261
Merge pull request #21004 from uniqueiniquity/updateATA
Enable typings cache entries to expire and be updated
2018-02-09 14:17:26 -08:00
Andy
171b68c9e7
Add assertions for bad symbol declaration (#21837)
* Add assertions for bad symbol declaration

* Fix lint
2018-02-09 14:08:56 -08:00
Andy
31ec5e7390
findAllReferences: Don't fail on broken re-export (#21841) 2018-02-09 13:56:04 -08:00