22630 Commits

Author SHA1 Message Date
Sheetal Nandi
67bb67edf1 Cache canonical global cache's package.json path 2018-04-18 11:22:02 -07:00
Sheetal Nandi
db9620d8f0 Use watch recursive directories instead of watchFile for node_modules and bower components 2018-04-17 14:27:21 -07:00
Sheetal Nandi
d64f2483e4 Update to respond to PR feedback 2018-04-17 14:17:15 -07:00
Sheetal Nandi
82e9a7595b Invoked should be property on watchers map instead of local variable since watchers arent closed if they need to be reopened 2018-04-13 15:17:13 -07:00
Sheetal Nandi
60b19f5782 Invalidate the unresolved import resolutions when typing files are set
This has 3 changes:
1. In updateGraph when enqueue the typing installation request (depending on unresolved imports)
2. When ActionSet event is received, invalidate only files with unresolved imports and resolve those.
3. When ActionInvalidate event is received, typing installer has detected some change in global typing cache location, so just enqueue a new typing installation request. This will repeat the cycle of setting correct typings and pickiing unresolved imports
2018-04-13 15:17:13 -07:00
Sheetal Nandi
35abe26824 Force new typings resolution only if there are more or less script infos in the project.
This helps in reducing number of forced typing installation requests
We anyways use changes in unresolved import array to determine if we need to enqueue new typing request
Hence there is no need to soley rely on hasChanges from updateGraph which just indicates that we didnt reused the program (that does not mean new files were added to the program or changes in unresolved imports)
2018-04-13 15:17:13 -07:00
Sheetal Nandi
c9479f7263 Remove the specialized type UnresolvedImportsMap which is just a redirection and helps only in test only 2018-04-13 15:17:13 -07:00
Sheetal Nandi
b0fb73c47c Typings cache is internal data structure 2018-04-13 15:17:12 -07:00
csigs
23ed9f8423
LEGO: Merge pull request 23401
LEGO: Merge pull request 23401
2018-04-13 15:11:08 -07:00
csigs
ef772d5e68 LEGO: check in for master to temporary branch. 2018-04-13 22:10:41 +00:00
Ryan Cavanaugh
7631ad03a3
Merge pull request #23386 from Microsoft/fix-jakefile-case-and-reference-circularity
Fix jakefile case and circular references
2018-04-12 17:01:49 -07:00
Nathan Shively-Sanders
32c571374e Update tsserverlibrary.d.ts after missed baseline 2018-04-12 16:26:37 -07:00
Nathan Shively-Sanders
7b712160e0 Re-add fixName to tsserverlibrary.d.ts 2018-04-12 16:20:04 -07:00
Nathan Shively-Sanders
a0b08f31f9 Fix jakefile case and circular references
Fails on Linux but not on Windows. Weird!
2018-04-12 16:11:16 -07:00
Sheetal Nandi
a9ffabbe51
Merge pull request #23374 from Microsoft/npmInstallCommandTooLong
Handle command too long failure in typings installer
2018-04-12 14:17:47 -07:00
Nathan Shively-Sanders
941777848f
Switch webpack to submodule (#23372)
* Prepare for adding webpack submodule

* Actually switch webpack to submodule

I'm sure this will work with no problems!

* Add ignore=all to webpack gitmodule entry

The other submodules do this, although I'm not sure why.

* Add newline at end of .gitmodules
2018-04-12 14:09:07 -07:00
Ryan Cavanaugh
0ef0b7adea
Merge pull request #23354 from RyanCavanaugh/referencesDogfood_1
Project references transitional: Remove reference comments
2018-04-12 13:56:47 -07:00
Ryan Cavanaugh
8e36afa5bd Remove reference emit from diagnostics 2018-04-12 12:41:00 -07:00
Ryan Cavanaugh
bbcf00c040 Remove ref comments from processDiagnosticMessages 2018-04-12 12:35:56 -07:00
Ryan Cavanaugh
ff60520460 Merge branch 'master' into referencesDogfood_1 2018-04-12 12:26:10 -07:00
Ryan Cavanaugh
f24d57f1ac Update diagnostic tasks in jakefile 2018-04-12 12:20:27 -07:00
Andy
abbb79f972
Combine getTouchingWord and getTouchingPropertyName (#22127) 2018-04-12 11:56:40 -07:00
Andy
afcced6839
Simplify tryGetImportOrExportClauseCompletionSymbols (#22961)
* Simplify tryGetImportOrExportClauseCompletionSymbols

* Handle undefined key in arrayToSet
2018-04-12 11:55:21 -07:00
Andy
d2dc2e6d48
Don't copy trivia when implementing an interface (#23343)
* Don't copy trivia when implementing an interface

* Use an `includeTrivia` flag instead of a separate function
2018-04-12 11:47:42 -07:00
Sheetal Nandi
b3d83c81cc Handle command too long failure in typings installer 2018-04-12 11:43:18 -07:00
Andy
05c746b547
generateGetAccessorAndSetAccessor: Share modifier-creating code (#23311) 2018-04-12 11:13:25 -07:00
Nathan Shively-Sanders
5d23cb49d0
Exclude generated files from user tests (#23371)
* Exclude generated files from user tests

The top 3 offenders, at least: bcryptjs, bluebird and lodash.

* Clean url-search-params too

Only need to build the commonjs original, not the browserified ones.
2018-04-12 10:25:53 -07:00
Andy
b363240d05
Simplify registerCodeFIx (#23349) 2018-04-12 09:19:01 -07:00
csigs
a04e747569
LEGO: Merge pull request 23369
LEGO: Merge pull request 23369
2018-04-12 09:10:51 -07:00
csigs
2a10ef0016 LEGO: check in for master to temporary branch. 2018-04-12 16:10:29 +00:00
Andy
ff7ef4a25a
Add fixName property to CodeFixAction (#23350) 2018-04-12 09:05:30 -07:00
csigs
d4a166dad3
LEGO: Merge pull request 23360
LEGO: Merge pull request 23360
2018-04-12 03:10:58 -07:00
csigs
29dc3d2a66 LEGO: check in for master to temporary branch. 2018-04-12 10:10:32 +00:00
Andy
edcf087145
Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment (#23314)
* Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment

* Also test for export specifier
2018-04-11 19:01:30 -07:00
Ryan Cavanaugh
0e07d775a1 You have to do this everywhere now! 2018-04-11 16:59:53 -07:00
Andy
d36f83a98d
Remove TODO: GH#18795 comments (#23337) 2018-04-11 16:23:04 -07:00
Andy
b0552b089d
Don't include "/index" in import from @types even with classic resolution (#23347) 2018-04-11 16:22:10 -07:00
Ryan Cavanaugh
df95de3231 Merge branch 'master' into referencesDogfood_1 2018-04-11 16:17:38 -07:00
Nathan Shively-Sanders
79ad7df7e1
Improve user test tsconfig (#23325)
* Improve user test tsconfigs

Also incorporate updates from the packages themselves (they fixed
some of the bugs the compiler noticed).

* Fix enhanced-resolve module resolution

* Update baselines after merge w/master
2018-04-11 15:59:19 -07:00
Ryan Cavanaugh
e1a50366e3 .d.ts changed order 2018-04-11 15:55:29 -07:00
Ryan Cavanaugh
9a5a5b10a3 Remove all reference comments from services 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh
501d7be7ba Add explicit file lists to server tsconfig files 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh
bb8fd41793 Fix harness file listing 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh
034b8eee14 Remove explicit harness file list from Jakefile 2018-04-11 15:39:10 -07:00
Ryan Cavanaugh
21d16693da Explicitly list server source files in their current emitted order 2018-04-11 15:38:27 -07:00
Ryan Cavanaugh
3ca1d2d7e3 Remove all reference comments from server/ 2018-04-11 15:38:26 -07:00
Ryan Cavanaugh
5b3254957c Explicitly list compiler source files in their current emitted order 2018-04-11 15:38:26 -07:00
Ryan Cavanaugh
8294259ec2 Remove all reference comments from compiler/ 2018-04-11 15:38:26 -07:00
Andy
28455c65b3
patternMatcher: Return single best match instead of list (#23166) 2018-04-11 15:35:22 -07:00
Andy
f6b206a75a
When testing references, also test documentHighlights respects filesToSearch (#23306)
* When testing references, also test documentHighlights respects filesToSearch

* Fix handling for redirects and move assertion inside getDocumentHighlights

* Add another assert
2018-04-11 14:07:22 -07:00