21744 Commits

Author SHA1 Message Date
jack-williams
67984c720e Fix #21848: Allows to mutate const with non-null assertion (#21873) 2018-02-12 10:57:59 -08:00
Andrew Casey
ddf206b184
Merge pull request #21845 from amcasey/GH21793
Harden Extract Symbol against symbols without declarations
2018-02-12 10:40:31 -08:00
Mohamed Hegazy
3fb481ff40
Multiple telemetry debug assert failure fixes (#21886)
* Use getAllowSyntheticDefaultImports to access `--allowSyntheticDefaultImport` value

* Fix #21788: Handel missing imporotClause case

* Fix #21789: Add a defensive check to forgottenThisPropertyAccess code fix for non-identifier locations

* Do not suggest prefix with `this` if the name we are looking for is diffrent from the errorLocation

* Fix #21796: Handel case of unknown module

* Add check to capture more info for #21800

* Fix #21807: check for symbol before looking up its flags

* Fix #21812: Gracefully fail if the token is not `this`.
2018-02-12 10:34:17 -08:00
Anders Hejlsberg
611ebc7aad
Merge pull request #21839 from Microsoft/fixStructuralIdentity
Fix structural identity relations
2018-02-10 17:14:40 -08:00
Eric Grube
879cb69d6a add beautifier rule for space after close paren and destructure bracket (#21859) 2018-02-10 12:45:54 -08:00
Josh Goldberg
02e7696759 PR template typo: labeled / labelled (#21854) 2018-02-10 12:44:01 -08:00
Priyantha Lankapura
a732ff6b35 Add type infer formatting (#21850)
* add test for type infer formatting

* Fix type infer formatting

* update test to use condtional
2018-02-10 12:36:04 -08:00
csigs
d9fefd4f82
LEGO: Merge pull request 21857
LEGO: Merge pull request 21857
2018-02-10 03:10:41 -08:00
csigs
9b65a7dfe1 LEGO: check in for master to temporary branch. 2018-02-10 11:10:20 +00:00
Andrew Casey
e65a1a429c Harden Extract Symbol against symbols without declarations
Fixes #21793
2018-02-09 19:42:34 -08:00
Andrew Casey
57d94b9661
Merge pull request #21849 from amcasey/GH21816
Handle class declarations without names in Extract Symbol
2018-02-09 19:39:02 -08:00
Andrew Casey
025418fdb0 Handle class declarations without names in Extract Symbol
Fixes #21816
2018-02-09 19:09:25 -08:00
Andrew Casey
22c4862d9e
Merge pull request #21835 from amcasey/GH21786
Handle variable declaration without initializer in Convert to ES6 Module
2018-02-09 18:21:50 -08:00
Andrew Casey
d99cd05c63
Merge pull request #21833 from amcasey/TextChangesRange
Call replaceNode rather than replaceRange
2018-02-09 18:21:32 -08:00
Andrew Casey
1baae42149 Handle variable declaration without initializer in Convert to ES6 Module
Fixes #21786
2018-02-09 18:08:47 -08:00
Andrew Casey
ab5596e785 Call replaceNode rather than replaceRange
...where convenient.  Same for deleteNode/Range.
2018-02-09 17:51:28 -08:00
Andrew Casey
ad68fa88a7
Merge pull request #21832 from amcasey/TextChangesSeparator
Eliminate ChangeMultipleNodesOptions in favor of smart separators
2018-02-09 17:00:16 -08:00
Anders Hejlsberg
fadf031088 Merge branch 'master' into fixStructuralIdentity
# Conflicts:
#	tests/baselines/reference/conditionalTypes1.errors.txt
#	tests/baselines/reference/conditionalTypes1.js
#	tests/baselines/reference/conditionalTypes1.symbols
#	tests/baselines/reference/conditionalTypes1.types
#	tests/cases/conformance/types/conditional/conditionalTypes1.ts
2018-02-09 16:16:02 -08:00
Andrew Casey
8d1f316414 Eliminate ChangeMultipleNodesOptions in favor of smart separators 2018-02-09 16:06:14 -08:00
Anders Hejlsberg
f1d7afe760
Merge pull request #21847 from Microsoft/predefinedConditionalTypes
Predefined conditional types
2018-02-09 15:39:58 -08:00
Andy
49e78f68d2
findAllRefs: Fix bug for export not at top-level of a module/namespace (#21846) 2018-02-09 15:10:34 -08:00
Andy
425a4182a3
Handle empty declaration list in Convert to ES6 Module (#21843)
* Handle empty declaration list in Convert to ES6 Module

* Fix test
2018-02-09 14:46:57 -08:00
Anders Hejlsberg
11a075c289 Accept new baselines 2018-02-09 14:23:19 -08:00
Anders Hejlsberg
92b8ce7821 Update tests 2018-02-09 14:22:57 -08:00
Anders Hejlsberg
2aba29fc32 Add Exclude, Extract, NonNullable, ReturnType, and InstanceType types 2018-02-09 14:22:46 -08:00
Benjamin Lichtman
f989ef7261
Merge pull request #21004 from uniqueiniquity/updateATA
Enable typings cache entries to expire and be updated
2018-02-09 14:17:26 -08:00
Andy
171b68c9e7
Add assertions for bad symbol declaration (#21837)
* Add assertions for bad symbol declaration

* Fix lint
2018-02-09 14:08:56 -08:00
Andy
31ec5e7390
findAllReferences: Don't fail on broken re-export (#21841) 2018-02-09 13:56:04 -08:00
Andy
aa1ebda6a6
Fix bug: handle missing symbol.parent for non-accessible symbol (#21834) 2018-02-09 13:48:40 -08:00
Anders Hejlsberg
d9a0334ec7 Accept new baselines 2018-02-09 13:02:37 -08:00
Anders Hejlsberg
35f1fcbe85 Add tests 2018-02-09 13:02:21 -08:00
Anders Hejlsberg
57351e898e Add higher order structural identity relations 2018-02-09 13:02:07 -08:00
uniqueiniquity
4c89a813bf Handle case where package.json and package-lock.json don't agree 2018-02-09 10:36:49 -08:00
Andrew Casey
6dd88b39d5
Merge pull request #21781 from amcasey/TextChangesReplace
Tidy up textChanges.replace*
2018-02-09 10:35:20 -08:00
Andy
1b620886a9
Assert getExportEqualsLocalSymbol returns a defined result (#21831) 2018-02-09 10:28:31 -08:00
Anders Hejlsberg
868a9ee117
Merge pull request #21782 from Microsoft/fixIdenticalConditionalTypes
Compatibility of identical conditional types
2018-02-08 17:38:31 -08:00
Anders Hejlsberg
6dfcbffdc1 Accept new baselines 2018-02-08 17:15:00 -08:00
Anders Hejlsberg
e54606b7bf Add tests 2018-02-08 17:14:52 -08:00
Anders Hejlsberg
a9251723c7 Properly detect identical conditional types in caching logic 2018-02-08 17:10:25 -08:00
Andrew Casey
f77cefee88 Introduce *WithNodes paralleling textChanges.Replace*
1) Take options
2) Return `this`
3) Use adjusted positions
2018-02-08 15:52:12 -08:00
Andrew Casey
80b2c58c51 Eliminate replaceWithSingle in favor of replaceRange 2018-02-08 15:43:46 -08:00
Andrew Casey
8d6e48a2ec Change the meaning of useNonAdjustedStartPosition
Old: getFullStart
New: getStart
Impact: only used in tests
Reason: symmetry with useNonAdjustedEndPosition - both now effectively
mean "exclude trivia from range"
2018-02-08 15:43:41 -08:00
Andy
e2178ecfab
In getSymbolAtLocation, return undefined instead of unknownSymbol (#21774)
* In getSymbolAtLocation, return undefined instead of unknownSymbol

* Update check in completions to look for undefined instead of unknownSymbol
2018-02-08 14:35:21 -08:00
Andy
16f3b93ffd
Simplify TextSpan creation (#21306)
* Simplify TextSpan creation

* Rename 'start' to 'pos' where possible
2018-02-08 13:51:10 -08:00
Nathan Shively-Sanders
37f15ccb41
Print deferred mapped symbols 1 level deep (#21311)
* Print deferred mapped symbols 1 level deep

Previously, deferred mapped symbols would not print their type at all;
it would always print as `any`. This differed from the older behaviour
that printed it forever if necessary. As a compromise, we now print
deferred mapped symbosl 1 level deep before giving up and printing
`any`. This should cover the most common uses of mapped types.

* Use context flags instead of a global
2018-02-08 13:35:00 -08:00
Alan Agius
7b9ceb85fa refactor: use union type in DateConstructor (#21757)
* refactor: use union type in `DateConstructor`

Add support for union types in `DateConstructor`

This will add support for something like the below;
`
let date; string | number;
const date = new Date(x);
`

Closes: #21758

* fix: date constructor can't be passed `string | Date`, but takes either individually

Closes: #20900
2018-02-08 12:22:37 -08:00
Sheetal Nandi
5915b6d3aa
Merge pull request #21558 from Microsoft/symbolAndTypesOfString
Emit the symbol information for declaration names
2018-02-08 11:09:45 -08:00
Sheetal Nandi
a0b8be0198 Merge branch 'master' into symbolAndTypesOfString 2018-02-08 11:09:26 -08:00
Mohamed Hegazy
4150a463e2
Fix #20805 (#21755)
* Add `-dev` to version patch number in master

* Refactor to handel non-identifier tokens for UMD modules

* Be more graceful handeling non-identifier tokens in import fixes

* Fix bad merge

* Remove check for isIdentifier
2018-02-08 10:32:08 -08:00
Andy
2a17825428
completions: Add assertions that symbols are defined (#21764)
* completions: Add assertions that symbols are defined

* Add assertion messages
2018-02-08 10:20:01 -08:00