30206 Commits

Author SHA1 Message Date
csigs
611dd22b9a
LEGO: Merge pull request 38655
LEGO: Merge pull request 38655
2020-05-18 21:11:16 -07:00
csigs
90b772a751 LEGO: check in for master to temporary branch. 2020-05-19 04:10:35 +00:00
csigs
6ba8c2725b
LEGO: Merge pull request 38650
LEGO: Merge pull request 38650
2020-05-18 15:11:15 -07:00
csigs
92dc5b8754 LEGO: check in for master to temporary branch. 2020-05-18 22:10:33 +00:00
csigs
160d201fe6
LEGO: Merge pull request 38639
LEGO: Merge pull request 38639
2020-05-18 09:11:35 -07:00
csigs
48d6e8dee5 LEGO: check in for master to temporary branch. 2020-05-18 16:10:40 +00:00
csigs
b58c9f4f8e
LEGO: Merge pull request 38633
LEGO: Merge pull request 38633
2020-05-18 03:11:09 -07:00
csigs
437d68d64b LEGO: check in for master to temporary branch. 2020-05-18 10:10:25 +00:00
Anders Hejlsberg
3c1f37e913
Use control flow analysis to check 'super(...)' call before 'this' access (#38612)
* Use CFA graph to check this/super accesses are preceded by super() call

* Accept cleaned-up API baselines

* Accept new baselines

* Add tests
2020-05-16 19:58:17 -07:00
csigs
bc0d2ec26c
LEGO: Merge pull request 38614
LEGO: Merge pull request 38614
2020-05-16 15:11:35 -07:00
csigs
d154b58406 LEGO: check in for master to temporary branch. 2020-05-16 22:10:40 +00:00
Eli Barzilay
33c3e9e2c6 Make processTaggedTemplateExpression visit a returned node
This problem was introduced in 70399e146e2 (from PR #23801), which added
a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`,
before that, it would fallback to the default of `visitNode`.  So re-add
that happen in `processTaggedTemplateExpression`.

Since it doesn't hurt, I left a `Debug.checkDefined(property.name)`
instead of `!`-ing it.

Fixes #38558.
2020-05-15 19:46:45 -04:00
Eli Barzilay
d7dd06e36d goToDefinition: find only the value if it's the RHS of an assignment 2020-05-15 18:55:57 -04:00
Jesse Trinity
1a15717bc4
Fix regression organize imports duplicates comments (#38599)
* delete import comments on organize imports

* add unit test

* accept new baseline

* respond to review comment
2020-05-15 14:25:11 -07:00
Ron Buckton
1cbe7ef000
Fix crash in JS declaration emit (#38508)
* Fix crash in JS decl emit

* Emit as class with private ctor
2020-05-15 14:00:59 -07:00
Wesley Wigham
7fc456f2d7
Include unknown in spread prop override check (#38577) 2020-05-14 14:36:38 -07:00
Daniel Rosenwasser
89f7797f7e
Merge pull request #38576 from wincent/typos
Fix (cosmetic) typos in checker.ts comments
2020-05-14 12:30:59 -07:00
Greg Hurrell
cfc4573c82 Fix (cosmetic) typos in checker.ts comments
Just some small things I noticed while looking at some recent PRs.
2020-05-14 19:40:41 +02:00
Anders Hejlsberg
c1f676dd3f
Perform intersection reduction before and after getApparentType (#38565)
* Perform intersection reduction before and after getApparentType

* Add regression tests
2020-05-13 20:57:17 -07:00
Alexander T
71711257ea
fix(33836): allow readonly modifier for a field with only get accessor (#36543) 2020-05-13 13:28:32 -07:00
Wenlu Wang
9725d623ce
Fix build type error (#38525) 2020-05-13 07:44:49 -04:00
Nathan Shively-Sanders
5ef22280a0
Merge pull request #38480 from typescript-bot/user-baseline-updates
🤖 User test baselines have changed for refs/heads/master
2020-05-12 14:10:29 -07:00
typescript-bot
c44759a553 Update user baselines 2020-05-12 20:21:01 +00:00
Daniel Rosenwasser
b682ee1a8a
Merge pull request #38489 from microsoft/removeDuplicateInfo
Remove duplicate JSDoc comments
2020-05-12 12:52:15 -07:00
Daniel Rosenwasser
c2b559403d
Merge pull request #38502 from alan-agius4/export-star-colon
fix: add missing semi-colon to `__exportStar` unnamed function
2020-05-12 10:59:03 -07:00
Sheetal Nandi
5d6a5d04ea
Fix detecting default project when file is part for more than one project but not part of default configured project (eg because its output of that projet) (#38429)
Fixes #38366
2020-05-12 10:16:59 -07:00
Nathan Shively-Sanders
3f06adf662
Merge pull request #38240 from a-tarasyuk/feat/add-outlining-spans-for-object-destructuring-elements
feat: Add outlining spans for object destructuring elements
2020-05-12 07:35:03 -07:00
Nathan Shively-Sanders
cbf15bb6ed
feat(38225): change diagnostic message for remove braces from arrow function body (#38226) 2020-05-12 07:27:09 -07:00
Alexander T
5895493815
fix(37877): include in NavigationBar default exported child items (#38255) 2020-05-12 07:26:31 -07:00
Alan Agius
7ec21e93fe fix: add missing semi-colon to __exportStar unnamed function
Fixes #38501
2020-05-12 13:27:01 +02:00
csigs
f4872eb493
LEGO: Merge pull request 38492
LEGO: Merge pull request 38492
2020-05-11 21:11:26 -07:00
csigs
0e37296396 LEGO: check in for master to temporary branch. 2020-05-12 04:10:41 +00:00
Daniel Rosenwasser
f9e1bcd0c4
Merge pull request #38439 from lissein/void-0-template-strings
Changed template strings to emit void 0 instead of undefined (#38430)
2020-05-11 17:09:28 -07:00
Daniel
355c28ea70 Update baselines. 2020-05-11 22:17:15 +00:00
Daniel
e9867a7353 Add and use the 'intersperse' helper function. 2020-05-11 22:17:01 +00:00
csigs
db0cd30898
LEGO: Merge pull request 38488
LEGO: Merge pull request 38488
2020-05-11 15:11:55 -07:00
csigs
27b9daf0a3 LEGO: check in for master to temporary branch. 2020-05-11 22:10:44 +00:00
Ron Buckton
d07e866a28
Fix for jsdoc modifiers on constructor params (#38403)
* Fix for jsdoc modifiers on constructor params

* Update Public API baseline and fix unique symbol grammar check for js
2020-05-11 15:07:43 -07:00
Daniel
74d6d04d70 Don't add duplicates of JSDoc comments. 2020-05-11 21:39:47 +00:00
Daniel
1450908e5c Added tests for union types with identical doc comments. 2020-05-11 21:36:43 +00:00
Nathan Shively-Sanders
1a88430a7e
Improve assert message in binder (#38270)
* Improve assert message in binder

Looking at the code, I don't think the assert can ever fire, but it
clearly does, or did in the past. This will make it easier for people to
create a repro.

* fix lint

* Use BindableStaticNameExpression not BindableStaticAccessExpression

This type does allow identifiers, but those are ruled out earlier, so I added
an assert for that case.
2020-05-11 13:40:54 -07:00
jeffy-g
fd71eb2c85
fix broken regex on "src/services/completions.ts#getCompletionData" (#37546)
* fix broken regex on src/services/completions.ts#840

* update forslash test

breaking changes fourslash test

Temporarily retain the before fix code for easy comparison

* regex

* fourslash test (Temporary code

* regex: more restrictive in terms of jsdoc format

fourslash test

* regex: max indent restriction

* achieved goal by partial match strategy (probably

* cleanup

* apply requested changes

* Change to a version with minimal modifications
2020-05-11 13:02:20 -07:00
Wenqi
1b7b3eb0f7
report error for duplicate @type declaration (#38340) 2020-05-11 12:47:49 -07:00
Alexander T
738b6b5b68
fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' (#38107) 2020-05-11 12:25:25 -07:00
TypeScript Bot
4109bba9e1
Update user baselines (#38472)
Co-authored-by: typescript-bot <typescript@microsoft.com>
2020-05-11 11:05:15 -07:00
TypeScript Bot
5653cecc17
Update user baselines (#38405)
Co-authored-by: typescript-bot <typescript@microsoft.com>
2020-05-11 09:00:10 -07:00
lissein
946abeadb0 Changed template strings to emit void 0 instead of undefined (#38430)
undefined is not a keyword in es5 and es3 so we now emit void 0 instead in template strings.
2020-05-09 04:53:14 +02:00
Wesley Wigham
7b03835b77
Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit (#38368)
* Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit

* Add special lookups test case, rename helper

* Accept slightly modified baselines
2020-05-08 10:46:28 -07:00
csigs
083dbe4b8c
LEGO: Merge pull request 38424
LEGO: Merge pull request 38424
2020-05-08 09:15:52 -07:00
csigs
92b7d8b6f2 LEGO: check in for master to temporary branch. 2020-05-08 16:13:19 +00:00