microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-11 20:37:46 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity
30,974 Commits 371 Branches 237 Tags
6101fbca39795c599cc9676615ea4da5c3b135b1
Commit Graph

5818 Commits

Author SHA1 Message Date
Alex T
6101fbca39 fix(40150): use parameter name for a Promise callback function (#40191) 2020-09-08 13:44:38 -07:00
Andrew Branch
f6f2d36ee3 Add optionalReplacementSpan to completions response (#40347) 
* Add optionalReplacementRange to completions response

* Get the name right

* Fix unit tests

* Fix comment typo

* Fix comment typo

* Baseline
 2020-09-04 13:09:52 -07:00
Alexander T
8384018e68 fix(26141): show completions for string parenthesized types (#39697) 2020-09-04 12:15:16 -07:00
Alexander T
db5f519514 fix(31126): show completions in nested namespace name (#39663) 2020-09-03 13:32:03 -07:00
Alexander T
38cedc5b5f fix(39410): don't remove variables with type definition during converting named export to default (#39505) 2020-09-02 17:00:43 -07:00
Andrew Branch
7a0f603b11 Fix extract symbol crash on unterminated literals; don’t offer to extract export = ... (#40272) 
* Don’t offer to extract export assignment

* Terminate unterminated literals when extracting them

* Add test with regular expression ending in backslash

* Add test for string literal ending in backslash

* Remove unused parameter default
 2020-08-31 14:17:09 -07:00
Andrew Branch
bfb00eb164 Fix misplaced comma in auto imported specifier (#40273) 2020-08-31 10:54:53 -07:00
Alexander T
01362a3ac1 feat(part of 40169): add spelling suggestion/quick fix for module/namespace exported members (#40211) 2020-08-29 01:01:06 -07:00
Alexander T
fa5e9807e8 fix(40010): add outlining for comments before variables statements (#40016) 2020-08-27 16:29:05 -07:00
Alexander T
9f3af67929 fix(10019): allow renaming labels (#40064) 2020-08-18 01:04:49 -07:00
Nathan Shively-Sanders
c3d41bbb73 Alias for commonjs require in JS (#39770) 
* First attempt at aliases for require

* test+initial support for const x=require

* 1st round of baseline improvements

* 2nd round of baseline updates

* support property access after require

* check @type tag on require

* forbid expando missing namespaces on aliases

taken from #39558 as soon as it was created

* accept error baselines that are good, actually

* Scribbling on d.ts emit code

* use getSpecifierForModuleSymbol

* hideous hack for module.exports of aliases

* Fix module.exports.x --> export list emit

* fix isLocalImport predicate

* require only creates aliases in JS

* re-handle json imports

* update fourslash baseline

* Cleanup in the checker

1. Simplify alias resolution.
2. Simplify variable-like checking.
3. Make binding skip require calls with type tags -- they fall back to
the old require-call code and then check from there.

I haven't started on the declaration emit code since I don't know what
is going on there nearly as well.

* Function for getting module name from require call

* First round of cleanup plus a new test

Found one missing feature, not sure it's worth adding.

* more small cleanup

* more cleanup, including lint

* use trackSymbol, not serializeTypeForDeclaration

* Code review comments, plus remove unneeded code

Ad-hoc type reference resolution for `require` isn't needed anymore.

* find all refs works

* remove old ad-hoc code

* make it clear that old behaviour is not that correct

* update api baselines

* remove outdated comment

* PR feedback

1. Fix indentation
2. Add comment for exported JSON emit
3. Add test case for nested-namespace exports.

* add a fail-case test (which passes!)
 2020-08-17 14:00:37 -07:00
Daniel Rosenwasser
97a072926f Revert "Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode (#40061)" (#40072) 
This reverts commit 2426eb4980.
 2020-08-17 11:45:39 -07:00
Daniel Rosenwasser
2426eb4980 Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode (#40061) 
* Add '(approximate)' to the beginning of quick info requests.

* Use 'approximation' instead of 'approximate'.
 2020-08-14 17:54:10 -07:00
Zen
0ed523bb60 fix jsx completions after attributes (#39859) 
closes #39530
 2020-08-13 16:14:12 -07:00
Sheetal Nandi
03d946d145 Revert to including only open files in partial semantic server mode (#40026) 2020-08-12 20:45:59 -07:00
Jesse Trinity
91a7c359b3 Insert auto imports after header comment (#39924) 
* place first import after header

* don't insert before non-header
 2020-08-06 13:33:29 -07:00
Andrew Branch
87a3b42d72 Handle empty package.json files (#39937) 2020-08-06 11:04:21 -07:00
Sheetal Nandi
da5ff57608 Renames in servermode per feedback (#39883) 
* Server mode renames as per feedback

* More renames
 2020-08-05 12:19:15 -07:00
Andrew Branch
7f4e1b699a Find tagless JSDoc as preceding token (#39912) 2020-08-05 10:09:45 -07:00
Sheetal Nandi
aee78acedb Add separate flag serverMode for server mode (#39735) 
* Add separate flag serverMode for server mode to allow back compatibility

* Addressed code review feedback.

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
 2020-08-02 18:18:26 -07:00
Andrew Branch
86a87c493c Limit auto import provider project size (#39855) 
* Limit auto import provider project size

* Add test

* Make option configurable

* Fix test

* Only bail when setting is auto

* Fix other test

* Update API baseline
 2020-08-02 17:47:49 -07:00
Orta Therox
faf128de15 Fix formatting scanner on JSX text that looks like trivia (#39718) 
* Fix formatting scanner on JSX text that looks like trivia

* Combine if statements

Co-authored-by: Andrew Branch <andrew@wheream.io>
 2020-07-30 13:56:14 -04:00
Andrew Branch
8f04f91ef5 Add diagnostic info to getNameForExportedSymbol crash (#39790) 
* Add diagnostic info to getNameForExportedSymbol crash

* Add JS indicator
 2020-07-28 12:53:56 -07:00
Sheetal Nandi
48e58f44db Handle unresolved baseType when trying to get completions for static member (#39731) 
* Handle unresolved baseType when trying to get completions for static member
Fixes  #38067

* Update src/services/completions.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* correct the condition

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-07-24 16:37:28 -07:00
Andrew Branch
ec33814616 Make AutoImportProviderProject work with symlinked monorepos (#39679) 
* Hack everything together

* Add test

* Remove realpath from program

* Ensure symlinked directories are directories

* Revert unnecessary change

* Update baselines

* Use host program realpath on AutoImportProviderProject files before program creation

* Which fixes hasRoots() too

* Apply suggestions from code review

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

* Lint

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
 2020-07-22 13:53:30 -07:00
Andrew Branch
b834096998 Fix emit/formatting issues in refactors (#39506) 
* Fix #37948

* Fix formatter skipping tab/space fixup on comments, handle trailing commas in list closing line count.

Fixes #37944

* Add newline between imports and main body of new file in moveToNewFile

Fixes #37941

* Update baseline (probably broken before?)
 2020-07-22 10:31:42 -07:00
Song
e76d17257a Fix 38219: signature helper works for optional function condition. (#39672) 
* fix optional fuction condition.

* Adds a test

Co-authored-by: Orta <git@orta.io>
 2020-07-22 12:30:21 -04:00
Song
d897646a4a fix 39453 (#39579) 
* fix 39453

* add restriction.

* add tests

* comment.

* fix as suggestion.
 2020-07-21 09:40:25 -07:00
Sheetal Nandi
667ba74c93 Resolve only relative references in open files on syntax server (#39476) 
* Resolve only relative references in open files on syntax server

* Support resolving tripleslash references only in the open file

* Apply suggestions from code review

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
 2020-07-16 14:31:24 -07:00
Alexander T
c07c885151 fix(39515): fix getting a position for an element before the line break CRLF/LF on the line that contains 'after' element (#39554) 2020-07-16 13:56:30 -07:00
Alexander T
6430211f8f fix(38868): add separator for type parameters (#39621) 2020-07-16 10:58:16 -07:00
Alexander T
ececf3b0a7 fix(33511): show jsx namespace default import quick fix if it does not exists in the current scope (#38419) 2020-07-14 15:43:18 -07:00
Jesse Trinity
17022388bd Add refactor convertToOptionalChainExpression (#39135) 
* add convertOptionalChain

* cover more cases

* expose containsMatchingReference

* clean up performing edits

* bound start position

* add tests

* refactor and handle edge cases

* update tests

* consider explicit requests for empty spans

* update fourslash to use trigger reason

* add tests cases for trigger reason

* fix errors

* remove type assertion

* fix non ampersand chains

* clean up some logic

* add ternary case

* add diagnostic message

* add nullish check for ternary expressions

* Update src/services/refactors/convertToOptionalChainExpression.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Update src/services/refactors/convertToOptionalChainExpression.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Update tests/cases/fourslash/refactorConvertToOptionalChainExpressionForTriggerReason3.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Update tests/cases/fourslash/refactorConvertToOptionalChainExpressionForTriggerReason1.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* reformat and remove unused checks

* allow any for ternary refactor

* add tests

* add tests

* check return and variable statements

* use isMatchingReference instead of containsMatchingReference

* allow partial selections

* fine tune selection ranges

* recurse for call expressions

* fix spellings

* add recursive cases

* remove isOrContainsMatchingReference

* cleanup

* more refactoring

* cleanup

* rename tests

* address PR comments

* check match syntactically

* handle another call expression case

* some renames

* inline some checks

* add test

* address comments

* add refactorNotAvailableReason

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-07-13 19:33:33 -07:00
Armando Aguirre
6279f981b3 Merge pull request #37029 from armanio123/AddToggleCommentFeature 
Add ToggleLineComment and ToggleMultilineComment service
 2020-07-13 17:48:50 -07:00
Andrew Branch
3c91133f97 Fix find-all-references on undefined (#39591) 
* Fix find-all-references on `undefined`

* Show references in input files in baseline

* Inline commentEachLine

* firstOrUndefined doesn’t take undefined
 2020-07-13 17:21:16 -07:00
Armando Aguirre
635ee24a3c Merge remote-tracking branch 'upstream/master' into AddToggleCommentFeature 2020-07-13 16:58:19 -07:00
Ron Buckton
2c08affa0d Merge pull request #39264 from microsoft/migrateMapsAndSets 
Migrate maps and sets
 2020-07-13 10:38:30 -07:00
Kenn Sarsaba
629dd6487b Fix typo (#39585) 2020-07-13 07:43:53 -07:00
Armando Aguirre
0d38f09e36 PR comments and minor bugs 2020-07-10 17:44:02 -07:00
Sheetal Nandi
8002473ea6 Add ClassExpression, FunctionExpression and ArrowFunction to check for cancellation token from classifier (#39557) 
Fixes #35364
 2020-07-10 13:39:09 -07:00
Armando Aguirre
a534f2aa97 Fixed syntax error 2020-07-09 22:15:02 -07:00
Armando Aguirre
ef81a0d0ee Merge remote-tracking branch 'upstream/master' into AddToggleCommentFeature 2020-07-09 21:55:36 -07:00
Armando Aguirre
b81f240e96 PR comments 2020-07-09 18:35:54 -07:00
Sheetal Nandi
b397d1fd4a Fixes searches for export * as 'identifier' (#39533) 
* Fixes searches for export * as 'identifier'
Fixes #39006

* Fix the context span to export declaration (was incorrectly set to sourceFile in prev commit)
 2020-07-09 13:45:43 -07:00
ShuiRuTian
bf1ea6508b fix static method reference non-static (#38730) 
* fix static method reference non-static

* fix contextRangeIndex

* fix lint.

* fix style.

* update according to suggestion.

* continue fix.

* use every rather than foreach

* format

* fix

* add comment.

* fix according to review suggestions.

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

Co-authored-by: Song Gao <song.gao@laserfiche.com>
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
 2020-07-09 12:21:12 -07:00
Jesse Trinity
8e9de9bed2 Fix39458 (#39508) 
* remove undefined from optional parameter

* accept baselines

* use getTypeWithFacts
 2020-07-09 11:17:18 -07:00
Andrew Branch
03c79d7422 Insert auto-imports in sorted order (#39394) 
* Sort auto-imports

* Avoid re-checking sort all the time

* Add comment
 2020-07-08 15:25:04 -07:00
Alexander T
48c19eebaf fix(25155): add space before optional parameters/properties (#38798) 2020-07-08 13:38:15 -07:00
Sheetal Nandi
0f86c04af3 Fixes searches for symbols exported using export * as (#39507) 
Fixes #39006
 2020-07-08 13:31:21 -07:00
Alexander T
ebac7ec08f fix(39421): omit prefix text for rest binding element (#39433) 2020-07-08 13:25:28 -07:00