microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-08 08:14:51 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix misplaced comma in auto imported specifier (#40273)

Browse Source
This commit is contained in:
Andrew Branch 2020-08-31 10:54:53 -07:00 committed by GitHub
parent 97f8b87e34
commit bfb00eb164
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/codefixes/importFixes.ts
View File

@ -700,7 +700,7 @@ namespace ts.codefix {
}
else if (existingSpecifiers?.length) {
for (const spec of newSpecifiers) {
changes.insertNodeAtEndOfList(sourceFile, existingSpecifiers, spec);
changes.insertNodeInListAfter(sourceFile, last(existingSpecifiers), spec, existingSpecifiers);
}
}
else {

24
tests/cases/fourslash/importNameCodeFix_trailingComma.ts Normal file
View File

@ -0,0 +1,24 @@
/// <reference path="fourslash.ts" />
// Bug #40219 only happens when existing import specifiers are unsorted.
// @Filename: index.ts
//// import {
//// T2,
//// T1,
//// } from "./types";
////
//// const x: T3/**/
// @Filename: types.ts
//// export type T1 = 0;
//// export type T2 = 0;
//// export type T3 = 0;
verify.importFixAtPosition([`import {
T2,
T1,
T3,
} from "./types";
const x: T3`]);