Commit Graph

24681 Commits

Author SHA1 Message Date
Andy
55a620c433 Don't crash on computed property in destructure (#26334) 2018-08-09 15:29:45 -07:00
Wesley Wigham
fce3d9f34d Check the ambientness of a symbol name before attempting to trim it (#26312)
* Check the ambientness of a symbol name before attempting to trim it

* Use find instead of forEach, remember to also exclude global augmentations
2018-08-09 13:20:37 -07:00
Wesley Wigham
f6af618ab9 Still generate signatures in SkipContextSensitive mode just to match on return types (#25937)
* Still generate signatures in SkipContextSensitive mode just to match on return types

* Add cache for context-free type of a signature node

* Accept post-merge baseline
2018-08-09 10:17:50 -07:00
Anders Hejlsberg
01f6093a9c Merge pull request #26143 from mattmccutchen/issue-26130
Have getAssignmentReducedType use the comparable relation instead of typeMaybeAssignableTo.
2018-08-09 07:43:46 -07:00
Anders Hejlsberg
20ebe1eb2b Merge pull request #26244 from Microsoft/fixThisAndContextualTypes
Revise logic that computes the contextual type for a parameter
2018-08-09 06:07:11 -07:00
Wesley Wigham
a36a53bfdb Actually add sorting of elaboration text to user baselines 2018-08-08 13:40:21 -07:00
Wesley Wigham
c6fd0c8d29 Ping ryan instead of mohammed for user PRs now 2018-08-08 13:36:03 -07:00
Ryan Cavanaugh
6210b7db54 Merge pull request #26245 from Kingwl/fix-compiler-crash
fix compiler crash (#26209)
2018-08-08 11:12:16 -07:00
Andy
1a05f13aef moveToNewFile: Don't remove empty named imports (#26265) 2018-08-07 12:54:46 -07:00
Andy
794f3a5e76 goToTypeDefinition: Go to function return type (#25952)
* goToTypeDefinition: Go to function return type

* Add more tests

* If a function returns 'void' or some other type with no definition, just return the function definition.
2018-08-07 12:54:19 -07:00
Andy
eaf0d59d35 Fix bug: symbol.valueDeclaration not guaranteed to be defined (#26267) 2018-08-07 12:13:45 -07:00
Wesley Wigham
32e99ba8f9 Add TEST-results.xml to the gitignore 2018-08-07 10:48:45 -07:00
Ryan Cavanaugh
3fde17e85c Merge pull request #26234 from RyanCavanaugh/noVoidTest
Disallow expressions of type `void` to be used in truthiness checks
2018-08-07 08:37:42 -07:00
王文璐
639190d607 fix compiler crash (#26209) 2018-08-07 10:09:26 +08:00
Andy
937afab4b0 Support signature help for contextual parameter type (#26022) 2018-08-06 16:46:30 -07:00
Anders Hejlsberg
eeb19c1e22 Merge pull request #26236 from Microsoft/fixCircularReturnType
Fix circular return type issue
2018-08-06 16:38:31 -07:00
Anders Hejlsberg
9d71023b5c Add fourslash tests 2018-08-06 16:33:21 -07:00
Ryan Cavanaugh
ca10b7a6fa Add checks for remaining truthiness positions 2018-08-06 16:11:43 -07:00
Anders Hejlsberg
bf19d214f3 Revise logic that computes the contextual type for a parameter 2018-08-06 16:10:10 -07:00
Wesley Wigham
2e017b8ce1 Hardcode xunit reporter output file into failed tests reporter 2018-08-06 14:09:41 -07:00
Ryan Cavanaugh
bad002cfb7 Merge pull request #26150 from Kingwl/CheckReturnUnknow
add check for function return unknow type
2018-08-06 13:52:14 -07:00
Andy
d0ed21cad1 completions: 'true' and 'false' are type keywords (#26237) 2018-08-06 12:42:56 -07:00
Klaus Meinhardt
7299bceafb infer number index signature in JS object literals (#26221)
Fixes: #26208
2018-08-06 11:52:51 -07:00
Wesley Wigham
16343208c8 If runner is xunit (as on CI) set output file 2018-08-06 11:41:27 -07:00
Anders Hejlsberg
cfa29ae2fa Merge branch 'master' into fixCircularReturnType
# Conflicts:
#	src/compiler/diagnosticMessages.json
2018-08-06 10:53:20 -07:00
Anders Hejlsberg
6a17f4d162 Merge branch 'master' into fixCircularReturnType
# Conflicts:
#	tests/baselines/reference/recursiveResolveDeclaredMembers.types
#	tests/baselines/reference/typeGuardsWithInstanceOfByConstructorSignature.types
2018-08-06 10:42:35 -07:00
Alexander T
37b9a6bca4 25840 - Add a more meaningful error message to the case when calling a public static method on an instance (#25922)
* add a more meaningful error message to the case when calling a public static method on an instance

* Fix tests
2018-08-06 10:24:48 -07:00
Anders Hejlsberg
9c3dc96dc1 Accept new baselines 2018-08-06 10:02:42 -07:00
Anders Hejlsberg
efdbbd1cf3 Add regression tests 2018-08-06 10:02:33 -07:00
Ryan Cavanaugh
14d3c69c72 Disallow exprs of type void to be used in truthiness checks 2018-08-06 09:40:22 -07:00
Anders Hejlsberg
dc34c5e719 Use getReturnTypeFromAnnotation instead of ad hoc checks 2018-08-06 06:51:45 -07:00
Anders Hejlsberg
c367b91da7 Accept new baselines 2018-08-05 08:48:17 -07:00
Anders Hejlsberg
ab7defa5ea Clean up return type checking logic 2018-08-05 08:47:55 -07:00
Anders Hejlsberg
faed2d2c33 Accept new baselines 2018-08-04 11:34:45 -07:00
Anders Hejlsberg
ee721225ae Ensure type parameters are erased in contextual signature from @type tag 2018-08-04 11:30:20 -07:00
Anders Hejlsberg
539775779e Erase type parameters when fetching return type from JSDoc @type tag 2018-08-04 09:13:22 -07:00
TypeScript Bot
d8cbe34a05 Update user baselines (#26186) 2018-08-04 00:23:14 -07:00
Anders Hejlsberg
a75fe5194e Accept new baselines 2018-08-03 14:44:48 -07:00
Anders Hejlsberg
e4443bb993 Properly catch and error on circular function return types 2018-08-03 14:03:30 -07:00
Sheetal Nandi
3ef067f7d9 Merge pull request #26194 from bterlson/patch-1
Update README.md: JavaScript has modules and classes
2018-08-03 12:02:50 -07:00
Brian Terlson
9d32c51cd4 Update README.md: JavaScript has modules and classes
So I made a slight tweak to the copy.
2018-08-03 11:46:26 -07:00
Sheetal Nandi
77e29b7f0e Merge pull request #26169 from Microsoft/largeFile
Do not read files greater than maxFileSize which is currently 4mb
2018-08-03 10:38:02 -07:00
Sheetal Nandi
b1878e62bf Merge pull request #26173 from Microsoft/compositeProjectGoToDefinition
Fixes to ensure getDefinitionAndBoundSpan works correctly when using composite projects
2018-08-03 10:35:32 -07:00
王文璐
c47a57fb76 remove useless test case 2018-08-03 16:12:56 +08:00
Sheetal Nandi
46d223dc1b Fixes to ensure getDefinitionAndBoundSpan works correctly when using composite projects
Project references need to be detached from the project when closing project
In SourceMapDecoder handle when the redirected file to project reference is set as the output of the project
Keep configured project alive if project it references has open ref
Fixes #26164
2018-08-02 16:36:50 -07:00
Sheetal Nandi
9df88316a2 Merge pull request #26137 from Microsoft/updateGraphIfDirty
Use updateGraphIfDirty to do quick check if project update is needed
2018-08-02 16:32:36 -07:00
Mohamed Hegazy
2ea0d16aa4 Merge pull request #26171 from Microsoft/portGeneratedLibFiles8-2-2
Port generated lib files
2018-08-02 15:12:17 -07:00
Mohamed Hegazy
613b07f9e4 Accept baselines 2018-08-02 14:44:37 -07:00
Mohamed Hegazy
5fbc7d92c2 Port generated lib files 2018-08-02 14:44:17 -07:00
Wesley Wigham
fefc47fae3 Flag JS Literals and ignore assignments/accesses to invalid props, instead of adding an index (#25996)
* Remove index signatures from js literals, use an object flag to indicate errors should be ignored instead

* Add focused test on the keyof problem

* Fix fourslash test

* Reenable errors with noImplicitAny flag

* Also disable excess property checks outside of noImplicitAny mode for js literals

* Edit and move comments
2018-08-02 13:40:44 -07:00