30229 Commits

Author SHA1 Message Date
Alexander T
4e945fbc98
fix(38299): use string literals as keys to creating rest result (#38600) 2020-05-20 13:52:52 -07:00
Nathan Shively-Sanders
68f8f22032
Merge pull request #38425 from dsherret/fixJSDocTagFactoryFuncReturnTypes
Fix some JSDoc factory function return types
2020-05-20 13:22:21 -07:00
Nathan Shively-Sanders
c526b425ef
Merge pull request #38498 from ShuiRuTian/make-atomics.notify-type-correct
make Atomics.notify last parameter optional
2020-05-20 11:55:01 -07:00
Anders Hejlsberg
a56960303d
Intersection check for empty object type shouldn't cause circularities (#38673)
* isEmptyAnonymousObjectType shouldn't require full member resolution

* Add regression test
2020-05-20 10:56:14 -07:00
Alexander T
2cea9d9d95
fix(38682): use stable typescript version (#38683) 2020-05-20 09:32:51 -07:00
Dmitry Makhnev
dbaeed5ad8
Add d.ts for Intl.RelativeTimeFormat (#36084)
* feat(lib/es2020.intl): Add `Intl.RelativeTimeFormat` (part of #29129);

* fix(lib/es2020.intl): fix for tests and linters `Intl.RelativeTimeFormat` (part of #29129);

* feat(lib/es2020.intl): Add TSDoc for `Intl.RelativeTimeFormat` by review request https://github.com/microsoft/TypeScript/pull/36084#issuecomment-584769420;

* fix(lib/es2020.intl): Fix for tests;

Co-authored-by: Dmitry Makhnev <dmitriy.makhnev@jugru.org>
2020-05-20 11:06:28 -04:00
Wesley Wigham
5f597e69b2
Support naming tuple members (#38234)
* Initial draft of named tuple members

* Show tuple labels and documentation in completions

* Swap allowed syntax to parameter-like

* Add quickfix for labeled tuple syntax mistakes

* Add refactoring to convert list of signatures to single overload

* Fix small bug in visitor verification

* Signature help for rest parameters which are unions of tuples are displayed as seperate entries now

* Expand sanity check test cases in conformance suite

* Add tests and code for preserving tuple names through spreads where possible

* More refactoring tests, some comment preservation and some fixed formatting of multiline tuples

* Handle missing parameter named in isValidDeclarationForTupleLabel

* Minor text fixes
2020-05-19 15:54:02 -07:00
csigs
24f53b06d2
LEGO: Merge pull request 38670
LEGO: Merge pull request 38670
2020-05-19 15:12:05 -07:00
csigs
0e4f1cb407 LEGO: check in for master to temporary branch. 2020-05-19 22:11:18 +00:00
Jack Works
7ec467e270
fix: extract const in jsx (#37912)
* fix: extract const in jsx

* Update src/services/refactors/extractSymbol.ts

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

* Update src/services/refactors/extractSymbol.ts

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
2020-05-19 14:29:49 -07:00
Daniel Rosenwasser
46f100f8ac
Merge pull request #38500 from a-tarasyuk/bug/38485
regression(38485): Unable to specify `rawText` when programmatically creating tagged template literals
2020-05-19 14:24:25 -07:00
Nathan Shively-Sanders
415b2e7969
Merge pull request #38656 from a-tarasyuk/bug/33233
fix(33233): Code Folding on es5 object functions does not work (getOutliningSpans)
2020-05-19 14:18:42 -07:00
Nathan Shively-Sanders
c5cca0ec18
Merge pull request #38659 from TimvdLippe/patch-3
Remove mentions of runtests-browser in CONTRIBUTING.md
2020-05-19 14:07:25 -07:00
Anders Hejlsberg
7ba0a6592d
No contextual types from circular mapped type properties (#38653)
* No contextual types from circular mapped type properties

* Add regression test
2020-05-19 13:42:30 -07:00
Nathan Shively-Sanders
2227ba749c
Merge branch 'master' into patch-3 2020-05-19 13:20:25 -07:00
Nathan Shively-Sanders
f7007174f6
Merge pull request #38660 from TimvdLippe/patch-4
Fix debug command for Node debugging
2020-05-19 13:18:03 -07:00
Andrew Branch
707e977056
Ensure formatter can always get a newline character (#38579)
* Ensure formatter can always get a newline character

* Make FormatContext.host optional since it’s not necessary if format options are all applied

* Make FormattingHost required again
2020-05-19 13:14:32 -07:00
Tim van der Lippe
77075df2d7
Fix debug command for Node debugging
If you would run with `--inspect=true`, the following error would be thrown:

[12:08:13] > node --inspect-brk=true TypeScript/node_modules/mocha/bin/_mocha -R scripts/failed-tests -O "reporter=mocha-fivemat-progress-reporter" -g "implementsJSDocReferencesDeclarationEmit" --colors -t 0 built/local/run.js
Unable to resolve "true": unknown node or service
2020-05-19 12:11:29 +01:00
Tim van der Lippe
e72e01d9ff
Remove mentions of runtests-browser in CONTRIBUTING.md
The gulp tasks were removed in #30054, but the contributing
guidelines weren't updated accordingly.
2020-05-19 12:06:09 +01:00
csigs
611dd22b9a
LEGO: Merge pull request 38655
LEGO: Merge pull request 38655
2020-05-18 21:11:16 -07:00
csigs
90b772a751 LEGO: check in for master to temporary branch. 2020-05-19 04:10:35 +00:00
csigs
6ba8c2725b
LEGO: Merge pull request 38650
LEGO: Merge pull request 38650
2020-05-18 15:11:15 -07:00
csigs
92dc5b8754 LEGO: check in for master to temporary branch. 2020-05-18 22:10:33 +00:00
csigs
160d201fe6
LEGO: Merge pull request 38639
LEGO: Merge pull request 38639
2020-05-18 09:11:35 -07:00
csigs
48d6e8dee5 LEGO: check in for master to temporary branch. 2020-05-18 16:10:40 +00:00
Alexander T
2b703d254a fix(33233): add outlining for comments before property access expression 2020-05-18 15:26:46 +03:00
csigs
b58c9f4f8e
LEGO: Merge pull request 38633
LEGO: Merge pull request 38633
2020-05-18 03:11:09 -07:00
csigs
437d68d64b LEGO: check in for master to temporary branch. 2020-05-18 10:10:25 +00:00
Anders Hejlsberg
3c1f37e913
Use control flow analysis to check 'super(...)' call before 'this' access (#38612)
* Use CFA graph to check this/super accesses are preceded by super() call

* Accept cleaned-up API baselines

* Accept new baselines

* Add tests
2020-05-16 19:58:17 -07:00
csigs
bc0d2ec26c
LEGO: Merge pull request 38614
LEGO: Merge pull request 38614
2020-05-16 15:11:35 -07:00
csigs
d154b58406 LEGO: check in for master to temporary branch. 2020-05-16 22:10:40 +00:00
Eli Barzilay
33c3e9e2c6 Make processTaggedTemplateExpression visit a returned node
This problem was introduced in 70399e146e2 (from PR #23801), which added
a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`,
before that, it would fallback to the default of `visitNode`.  So re-add
that happen in `processTaggedTemplateExpression`.

Since it doesn't hurt, I left a `Debug.checkDefined(property.name)`
instead of `!`-ing it.

Fixes #38558.
2020-05-15 19:46:45 -04:00
Eli Barzilay
d7dd06e36d goToDefinition: find only the value if it's the RHS of an assignment 2020-05-15 18:55:57 -04:00
Jesse Trinity
1a15717bc4
Fix regression organize imports duplicates comments (#38599)
* delete import comments on organize imports

* add unit test

* accept new baseline

* respond to review comment
2020-05-15 14:25:11 -07:00
Ron Buckton
1cbe7ef000
Fix crash in JS declaration emit (#38508)
* Fix crash in JS decl emit

* Emit as class with private ctor
2020-05-15 14:00:59 -07:00
Wesley Wigham
7fc456f2d7
Include unknown in spread prop override check (#38577) 2020-05-14 14:36:38 -07:00
Daniel Rosenwasser
89f7797f7e
Merge pull request #38576 from wincent/typos
Fix (cosmetic) typos in checker.ts comments
2020-05-14 12:30:59 -07:00
Greg Hurrell
cfc4573c82 Fix (cosmetic) typos in checker.ts comments
Just some small things I noticed while looking at some recent PRs.
2020-05-14 19:40:41 +02:00
Anders Hejlsberg
c1f676dd3f
Perform intersection reduction before and after getApparentType (#38565)
* Perform intersection reduction before and after getApparentType

* Add regression tests
2020-05-13 20:57:17 -07:00
Alexander T
71711257ea
fix(33836): allow readonly modifier for a field with only get accessor (#36543) 2020-05-13 13:28:32 -07:00
Wenlu Wang
9725d623ce
Fix build type error (#38525) 2020-05-13 07:44:49 -04:00
Nathan Shively-Sanders
5ef22280a0
Merge pull request #38480 from typescript-bot/user-baseline-updates
🤖 User test baselines have changed for refs/heads/master
2020-05-12 14:10:29 -07:00
typescript-bot
c44759a553 Update user baselines 2020-05-12 20:21:01 +00:00
Daniel Rosenwasser
b682ee1a8a
Merge pull request #38489 from microsoft/removeDuplicateInfo
Remove duplicate JSDoc comments
2020-05-12 12:52:15 -07:00
Daniel Rosenwasser
c2b559403d
Merge pull request #38502 from alan-agius4/export-star-colon
fix: add missing semi-colon to `__exportStar` unnamed function
2020-05-12 10:59:03 -07:00
Sheetal Nandi
5d6a5d04ea
Fix detecting default project when file is part for more than one project but not part of default configured project (eg because its output of that projet) (#38429)
Fixes #38366
2020-05-12 10:16:59 -07:00
Nathan Shively-Sanders
3f06adf662
Merge pull request #38240 from a-tarasyuk/feat/add-outlining-spans-for-object-destructuring-elements
feat: Add outlining spans for object destructuring elements
2020-05-12 07:35:03 -07:00
Nathan Shively-Sanders
cbf15bb6ed
feat(38225): change diagnostic message for remove braces from arrow function body (#38226) 2020-05-12 07:27:09 -07:00
Alexander T
5895493815
fix(37877): include in NavigationBar default exported child items (#38255) 2020-05-12 07:26:31 -07:00
Alan Agius
7ec21e93fe fix: add missing semi-colon to __exportStar unnamed function
Fixes #38501
2020-05-12 13:27:01 +02:00