17694 Commits

Author SHA1 Message Date
Daniel Rosenwasser
6f06fd0d46 Use a more direct error. 2018-06-28 16:06:55 -07:00
Wesley Wigham
2a19580144
Introduce more caching and deferral into jsx checking (#25302)
* Introduce more caching and deferral into jsx checking

* Accept baseline with removed duplicated error
2018-06-28 14:43:20 -07:00
Wesley Wigham
53e163df0b
Add codes and categories to related information, officially (#25304) 2018-06-28 14:41:21 -07:00
Wesley Wigham
297f12e92c
Add bailout case to sourcemap searching code (#25212)
* Add bailout case to sourcemap searching code

* Also skip sourcemappy comments like sourceURL
2018-06-28 11:40:31 -07:00
Andy
3a023ed7d6
Remove dead code testing result of resolveProjectReferencePath (#25284) 2018-06-28 10:50:39 -07:00
Nathan Shively-Sanders
5c2eeb20b1
Destructuring declaration prefers type annotation type (#25282)
* Destructuring declaration prefers type annotation type

Previously, getTypeForBindingElement would always union the declarations type and
the type of the default initializer. Now, if the declaration has a type
annotation, it does not union with the initializer type. The type
annotation's type is the one used.

* Small cleanup in parentDeclarationHasTypeAnnotation

* Refactoring based on PR comments

* Combine getCombined*Flags into a single helper function

Retain the individual functions since they are used a lot.

* Remove unneeded temp
2018-06-28 10:41:38 -07:00
Daniel Rosenwasser
950593b669
Merge pull request #25251 from Microsoft/betterAlwaysTrueFalseErrors
Better "always true/false" errors
2018-06-27 21:57:25 -07:00
Daniel Rosenwasser
1f8ad2d318 indicates -> indicate 2018-06-27 17:20:24 -07:00
Andy
16f045b7f5
Add test for goto-definition with project references (#24867)
* Add test for goto-definition with project references

* Assert that the declaration file is what we emit
2018-06-27 15:56:04 -07:00
Ryan Cavanaugh
4d43a3a3c0
Merge pull request #25281 from RyanCavanaugh/fixMapFilename
Don't look for a file called 2.map
2018-06-27 14:11:14 -07:00
Andy
fd8b7f3da5
Remove redundant checks in getNameOfDeclaration (#25244) 2018-06-27 13:56:31 -07:00
Ryan Cavanaugh
e207f25ee2 Don't look for a file called 2.map 2018-06-27 13:35:29 -07:00
Andy
1cb691f52d
findPrecedingToken: default includeJsDocComment to true (#25262)
* findPrecedingToken: default includeJsDocComment to true

* Add exception for smartIndenter
2018-06-27 12:14:41 -07:00
Andy
c9d44ce395
getTouchingToken: default includeJsDocComment to true (#25258) 2018-06-27 11:15:15 -07:00
Andy
c35cb86192
When renaming at a tsx opening/closing tag, just rename the current element (#25273) 2018-06-27 11:01:38 -07:00
Andy
d957b1c8c2
fixUnusedIdentifier: Remove arguments corresponding to unused parameters (#25011)
* fixUnusedIdentifier: Remove arguments corresponding to unused parameters

* Update API (#24966)

* Fix handling of deletions: Make a list of things to delete and don't delete until the end

* Remove dummy test

* Bug fixes

* Update API (#24966)

* Move code to textChanges
2018-06-27 09:26:47 -07:00
Andy
c8c547a706
Only add completion for a symbol if it is accessible (#25096) 2018-06-26 18:03:07 -07:00
Andy
ab9e913af3
getEditsForFileRename: Test both before and after the rename (#25074) 2018-06-26 16:55:51 -07:00
Andy
13bc46d970
getTokenAtPosition: default includeJsDocComment to true (#25015)
* getTokenAtPosition: default includeJsDocComment to true

* Update API (#24966)

* Flip meaning of parameter

* Update API (#24966)

* Remove all `ignoreJsDocComment` uses (fixes #25162)
2018-06-26 16:20:44 -07:00
Daniel Rosenwasser
4ca7aa4c37 Update error code expectations. 2018-06-26 15:54:06 -07:00
Daniel Rosenwasser
62e1e9d159 semanitc -> semantic 2018-06-26 15:52:52 -07:00
Mohamed Hegazy
4febcdf1cb
Merge pull request #25231 from timocov/fix25225
Remove @internal from Program::isSourceFileDefaultLibrary
2018-06-26 15:33:58 -07:00
Daniel Rosenwasser
63a52cd21e Give a better message up-front for incompatible equality errors. 2018-06-26 15:11:41 -07:00
Wesley Wigham
fc37b7926d
Stop not emitting mappings for function and class names (#25210) 2018-06-26 15:05:34 -07:00
Mohamed Hegazy
b59824ad9f
Merge pull request #25190 from mprobst/fix-generic-type-emit
Fix decorator design:types emit for type variables.
2018-06-26 14:04:37 -07:00
Nathan Shively-Sanders
9025bc7c69
Fix control flow loop in yield expression (#25228)
* Fix control flow loop in yield expression

Yet again, the fix is to stop using checkExpressionCached.

* Update lib in test to reduce number of errors
2018-06-26 12:50:29 -07:00
Nathan Shively-Sanders
9044589377
Fix duplicate errors in js special assignments (#24508)
* Fix duplicate errors in js special assignments

* Simplify checkExpressionCached call to checkExpression

* Accept baselines after merge

* Use Map for deferredNodes and improve NoDeferredCheck comment

I added an assert when a duplicate was added, but it caused 18 failures
in our test suite.

* Remove NoDeferredCheck
2018-06-26 12:40:58 -07:00
Wesley Wigham
a7be62f9db
Track name scope aloneside lexical scope 2018-06-26 12:24:55 -07:00
Nathan Shively-Sanders
133bb9f78d
Add name to jsDocParsing link tag test (#25229) 2018-06-26 10:50:59 -07:00
Eugene Timokhov
ff28ffab9f Remove @internal from Program::isSourceFileDefaultLibrary
Fixes #25225
2018-06-26 20:40:11 +03:00
Ryan Cavanaugh
e38aad8b79
Merge pull request #25202 from RyanCavanaugh/addChakraAPIs
Add Chakra APIs for tsc.exe --build
2018-06-26 09:29:25 -07:00
Martin Probst
6a24eabd18 Set current scope for classes. 2018-06-26 16:33:36 +02:00
Martin Probst
f1fe0b8116 use better scope 2018-06-26 15:51:37 +02:00
Anders Hejlsberg
70975cd08f
Merge pull request #24897 from Microsoft/restTuples
Tuples in rest parameters and spread expressions
2018-06-25 19:26:35 -07:00
Ron Buckton
bc3268b654
Merge pull request #25211 from Microsoft/gulpBrowserify
Clean up browserify task, remove unused 'debugMode.js' script
2018-06-25 16:56:47 -07:00
Ron Buckton
78bf10ad80
Merge pull request #25004 from Microsoft/trackFailedTests
Adds failed test tracking
2018-06-25 16:55:43 -07:00
Ron Buckton
5ed96ec072 Clean up browserify task, remove unused 'debugMode.js' script 2018-06-25 16:21:28 -07:00
Nathan Shively-Sanders
99ebcd788f
Treat link tag as comment (#25206)
* First attempt at parsing. Doesn't work

But my machine is dying, so this is an emergency commit.

* Parsing sort of works

But it's not right yet; the test I added fails. See the TODO I added.

* Parse link tag as comment
2018-06-25 15:27:49 -07:00
Ryan Cavanaugh
fa9f071c14 Don't try to write --pretty results to unsupported consoles in --build 2018-06-25 14:10:27 -07:00
Ryan Cavanaugh
d474603844 Pipe through Chakra APIs for tsc.exe --build 2018-06-25 14:10:07 -07:00
Anders Hejlsberg
d7443f04fd Contextual typing by tuple rest elements 2018-06-25 10:45:02 -10:00
Andy
0b5b7ef547
Fix removal of default import (#25200) 2018-06-25 12:41:32 -07:00
Andy
f52c881ab1
Improve verify.renameLocations (#25192) 2018-06-25 12:41:12 -07:00
Mohamed Hegazy
9c71eaf590
Merge pull request #25194 from Vimal-Raghubir/master
Fix issue regarding WeakMap constructor
2018-06-25 12:27:57 -07:00
Andy
6cd27a3217
Support doc comment template at function expression (#25050) 2018-06-25 11:40:45 -07:00
Andy
4c326b2b6c
Simplify addJSDocComment (#25196)
* Simplify addJSDocComment

* Add assert
2018-06-25 11:36:37 -07:00
Andy
62e5541a66
parseJSDocCommentWorker: Don't need result (#25197) 2018-06-25 11:34:20 -07:00
Andy
9aa60f27eb
goToDefinition: Don't add duplicate definitions for PropertyAssignment and ArrowFunction at m: () => {} (#24995)
* goToDefinition: Don't add duplicate definitions for PropertyAssignment and ArrowFunction at `m: () => {}`

* Just use !isCallLikeExpression
2018-06-25 11:33:47 -07:00
Ron Buckton
52fa900b5c Merge branch 'master' into trackFailedTests 2018-06-25 11:26:08 -07:00
Andy
e8e80d2bbd
Don't crash on property access with type (#25170)
* Don't crash on property access with type

* Move test
2018-06-25 11:25:52 -07:00