microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-27 04:48:33 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

goToDefinition: Don't add duplicate definitions for PropertyAssignment and ArrowFunction at m: () => {} (#24995)

Browse Source 
* goToDefinition: Don't add duplicate definitions for PropertyAssignment and ArrowFunction at `m: () => {}`

* Just use !isCallLikeExpression
This commit is contained in:
Andy
2018-06-25 11:33:47 -07:00
committed by GitHub
parent e8e80d2bbd
commit 9aa60f27eb
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/goToDefinition.ts
View File

@@ -99,7 +99,7 @@ namespace ts.GoToDefinition {
*/
function symbolMatchesSignature(s: Symbol, calledDeclaration: SignatureDeclaration) {
return s === calledDeclaration.symbol || s === calledDeclaration.symbol.parent ||
isVariableDeclaration(calledDeclaration.parent) && s === calledDeclaration.parent.symbol;
!isCallLikeExpression(calledDeclaration.parent) && s === calledDeclaration.parent.symbol;
}
export function getReferenceAtPosition(sourceFile: SourceFile, position: number, program: Program): { fileName: string, file: SourceFile } | undefined {

4
tests/cases/fourslash/goToDefinitionSignatureAlias.ts
View File

@@ -14,6 +14,9 @@
////[|/*useI*/i|]();
////[|/*useJ*/j|]();
////const o = { m: /*m*/() => 0 };
////o.[|/*useM*/m|]();
verify.goToDefinition({
useF: "f",
useG: ["g", "f"],
@@ -21,4 +24,5 @@ verify.goToDefinition({
useI: "i",
useJ: ["j", "i"],
useM: "m",
});