* Fix conditional type type parameter leak
* Monkey with comment text per code review
* Conditionally clone type param
* Reuse input array and avoid making mapper where possible
* Handle nonmaster branches in user suite tests
* Fix remaining changed default branches, vscode & vue-next docker install scripts
* NPM reformats these on install now, comitting so it doesnt need to be ignored
* Accept current user suite baselines
* Fix many trivially fixable user suite tests
* Rename SyntaxKind.JSDocComment -> JSDoc
Early on, I made the mistake of using the syntax kind JSDocComment for
the type JSDoc. This arose because
I hadn't decided on the terminology of "jsdoc" for the C-style comment
that is attached to a declaration. "comment"
for the text that follows a tag. By the time I settled on those terms
consistently, a version had already shipped with `interface JSDoc`
having `SyntaxKind.JSDocComment`.
However, there is now a `type JSDocComment` that represents the possible
contents of the comment text (strings and various kinds of `@link`), so
it's doubly confusing that this type has a union of four kinds instead
of SyntaxKind.JSDocComment.
Although this is a public API break, I don't think it's hard to recover
from, and the JSDoc API has accessors for individual tag types, so I
suspect few people refer directly to SyntaxKind.JSDocComment.
* Add deprecate JSDocComment alias to JSDoc
For backward compatibility
* Make JSDoc an alias of JSDocComment
Improves output of JSDocParsing tests without having to make its code
smarter.
* update API baselines
They were using the same helpers as FAR and rename, but they actually behave differently. Decoupling them helps avoid some unnecessary work and will make it easier to clean up FAR in the future.
Scoping NavTo results to a single project (rather than, e.g. all loaded projects) makes the behavior more logical and the implementation simpler.
* fix this type validations for protected fields
* update previous baselines
* add new tests and baselines
* ClassOrInterface can be returned as enclosingClass
* inline function code and remove unnecessary blank lines
* refactor enclosingClass checks
* Note git's core.longpaths in CONTRIBUTING
So people will be able to clone the repo on Windows.
However, I'm not sure whether this addresses running tests.
* Address PR comments
In short, the fix I submitted looked at the union ofproperties, but it
really should have looked at the intersection.
Two sytlistic notes. I couldn't find the best way to get the unique
strings of an array like `[...new Set()]` would, so I created a small
helper function, but didn't put it in a great place. Also, before the
second concatenated array of discriminators at least matched the first
in complexity, but now it's much worse. I don't think that section is
particularly easy to read, but I also don't see a significantly reusable
part.
fixes#41759
* Add import assertions for type-only imports and import types to change resolver modes
* By popular request, only allow mode assertions on top-level type only imports
* Add specifier options parameter to specifier generation
* Use full `isReadonlySymbol` check rather than declaration flags
* Limit subtype readonly consistency check to strict subtype relation
* Update comment
* add Intl.Locale param type to locales argument in BigInt, Number, and Date methods
* update baselines
* add test for locales object arguments
* fix indentation
