13280 Commits

Author SHA1 Message Date
Andy
31ce6cfba6 Minor cleanups to ScriptVersionCache (#16983) 2017-07-07 10:49:59 -07:00
Andy
dcc3e72636 Use decodeSpan more (#16990) 2017-07-07 10:37:18 -07:00
Andy
ee48c1b4cc Minor cleanups to EditWalker (#16980) 2017-07-07 10:36:46 -07:00
Andy
d3f4447657 Minor cleanups to LineIndexSnapshot (#16981) 2017-07-07 10:35:21 -07:00
Andy
e6256d43c4 Inline getDestructuringParameterName (#16973) 2017-07-07 10:34:50 -07:00
Andy
17578e8a5d Use Map<true> for sets (#16972) 2017-07-07 10:34:36 -07:00
Andy
2d802a62c4 Have isObjectBindingPatternElementWithoutPropertyName return the binding element (#16956) 2017-07-07 10:34:11 -07:00
Andy
81f8151e3a Use 'push' and 'pop' methods instead of using array.length (#16979) 2017-07-07 10:22:59 -07:00
Andy
ba53b42663 Clean up findChildIndex (#16984) 2017-07-07 10:15:04 -07:00
Andy
ba8e5a7e24 Never return undefined from getExportsOfModule (#17013) 2017-07-07 10:06:12 -07:00
Andy
d4c11bfa1b Clean up creation of 'args' in client.ts (#17009) 2017-07-07 08:09:59 -07:00
Andy
e7dc2a67ca Enable "object-literal-shorthand" lint rule (#16987) 2017-07-07 07:26:58 -07:00
Wesley Wigham
4b19eb3200 Remove duplicate entries from tsconfig files (#16991) 2017-07-06 15:56:34 -07:00
Wesley Wigham
07e8263204 Start using a union for FunctionLike things (#16988)
* Start using a union for FunctionLike things

* Rename to shorter name
2017-07-06 14:46:15 -07:00
Wesley Wigham
4e6b2f3c93 Created a branded type for identifier-escaped strings (#16915)
* Created a branded type for escaped strings

Then flowed it throughout the compiler, finding and fixing a handful of
bugs relating to underscore-prefixed identifiers in the process.
Includes a test for two cases noticed - diagnostics from conflicting
symbols from export *'s, and enum with underscore prefixed member emit.

* Correctly double underscores WRT mapped types

* Add fourslash tests for other fixed issues

* use function call over cast

* Update forEachEntry type accuracy

* Just use escaped names for ActiveLabel

* Remove casts from getPropertyNameForPropertyNameNode

* This pattern has occurred a few times, could use a helper function.

* Remove duplicated helper

* Remove unneeded check, use helper

* Identifiers list is no longer escaped strings

* Extract repeated string-getting code into helper

* Rename type and associated functions

* Make getName() return UnderscoreEscapedString, add getUnescapedName()

* Add list of internal symbol names to escaped string type to cut back on casting

* Remove outdated comments

* Reassign interned values to nodes, just in case

* Swap to string enum

* Add deprecated aliases to escapeIdentifier and unescapeIdentifier

* Add temp var

* Remove unsafe casts

* Rename escaped string type as per @sandersn's suggestion, fix string enum usages

* Reorganize double underscore tests

* Remove jfreeman from TODO

* Remove unneeded parenthesis
2017-07-06 14:45:50 -07:00
Arthur Ozga
ad291d924d Merge pull request #16748 from aozgaa/implementOptionCrash
visit question token
2017-07-06 13:51:15 -07:00
Arthur Ozga
dc08c5f241 Merge branch 'master' into caretPositionInFourslash 2017-07-06 10:44:59 -07:00
Arthur Ozga
86894f3a6f i++ 2017-07-05 14:26:59 -07:00
Arthur Ozga
a200aa9329 non-default args 2017-07-05 12:54:42 -07:00
Arthur Ozga
2857bb9703 remove fixCaretPosition 2017-07-05 12:47:32 -07:00
Arthur Ozga
b5e069816d consolidate function call 2017-06-30 19:50:09 -07:00
Arthur Ozga
5652b0677e update caret position based on edit range 2017-06-30 19:40:56 -07:00
Ron Buckton
2a6aacd0ef Merge pull request #16696 from Microsoft/fix15663
Ignore jsdoc when inferring rest args in JavaScript
2017-06-30 14:27:55 -07:00
Nathan Shively-Sanders
9048c0ae47 Merge pull request #16844 from Microsoft/codefix-spelling-correction-for-typeparameters
Spelling code fix: suggestions from apparent type
2017-06-30 12:56:18 -07:00
Yui
a7fe9db746 Merge pull request #16847 from Microsoft/master-RWC
[master] fix RWC runner
2017-06-30 12:08:23 -07:00
Kanchalai Tanglertsampan
67faecc32c remove BOM 2017-06-30 11:52:00 -07:00
Nathan Shively-Sanders
e0bf267029 spelling:getPropertiesOfType instead of objectType
This provides suggestions for more types based on their apparent type:
unions, type parameters with constraints, primitives.
2017-06-30 10:11:00 -07:00
Arthur Ozga
4e6e1d1b8b Merge pull request #16657 from aozgaa/formatOnOpenCurly
Format on open curly
2017-06-30 10:04:57 -07:00
Nathan Shively-Sanders
2eec7f3565 Dedupe some utility code
1. convertToArray is a duplicate of arrayFrom
2. inferFromParameterTypes delegates immediately to inferFromTypes
3. One usage of arrayFrom instantiated a whole iterator only to take the
first element, which is the same as calling `next`.
2017-06-30 09:23:00 -07:00
Arthur Ozga
25abf8a9e8 respond ot comments 2017-06-29 17:31:41 -07:00
Kanchalai Tanglertsampan
2e13c3a7a6 Update RWC runner 2017-06-29 16:55:46 -07:00
Kanchalai Tanglertsampan
0ffbb75503 check error early and return null to indicate that everything is going well 2017-06-29 16:53:37 -07:00
Nathan Shively-Sanders
b1af566396 Remove unused code in bindWorker 2017-06-29 16:30:44 -07:00
Nathan Shively-Sanders
f45df8fb69 Spelling code fix:suggestions from apparent type
The code fix for spelling correction needs to provide suggestions based
on the apparent type since sometimes the type at a location will be a type
parameter. One such example is `this`.

Fixes #16744
2017-06-29 16:21:00 -07:00
Ryan Cavanaugh
ec00bb9b72 Merge pull request #16697 from RyanCavanaugh/preserveMethodComments
Preserve method comments in JS->ES6 conversion.
2017-06-29 15:40:16 -07:00
Andrew Casey
ac72803bb2 Merge pull request #16684 from amcasey/Vsts434619
Watch for the creation of missing files
2017-06-29 13:41:18 -07:00
Andrew Casey
569ecabb0a Address PR feedback
Make Program.getMissingFilePaths required

Assume getMissingFilePaths always returns a defined value

Make getMissingFilePaths internal

Replace nullable-bool with enum

Update type to reflect possibility of undefined

Use deepEqual to simplify tests

Make condition const

Don't bother cleaning up map before freeing it

Switch from foreach to for-of to simplify debugging

Use a Map, rather than a FileMap, to track open FileWatchers

Fix compilation errors

Introduce and consume arrayToSet

Fix lint warnings about misplaced braces

Delete incorrect comment

Delete from map during iteration

Eliminate unnecessary type annotations
2017-06-29 11:29:19 -07:00
Arthur Ozga
60b78c618f only format open curly up to the open curly 2017-06-29 11:13:44 -07:00
Andy
179a3e10b5 Handle depth in all readDirectory implementations (#16646) 2017-06-29 11:04:33 -07:00
Ryan Cavanaugh
8b7402f9f8 Merge pull request #16833 from ltearno/master
Comments incorrectly read 'TypeFlags' instead of 'ObjectFlags' at some places
2017-06-29 10:40:50 -07:00
Andrew Casey
0f683ac2ad Add missing file unit tests
1. Test `Program.getMissingFilePaths`
2. Test program structure reuse (i.e. that the appearance of a missing
file prevents complete reuse)
2017-06-29 10:39:32 -07:00
Andrew Casey
6d200bffbd Watch files through the host
Call `this.projectService.host.watchFile`, rather than
`ts.sys.watchFile` so that it gets mocked correctly in the unit tests.
Repair two failing tests.
2017-06-29 10:39:32 -07:00
Andrew Casey
4652fc491f Confirm method is defined before calling 2017-06-29 10:39:32 -07:00
Andrew Casey
a39e969338 Clean up file watchers on project close 2017-06-29 10:39:31 -07:00
Andrew Casey
4863ada22c Track missing files
1. Expose missing files from the `Program`.
2. In `tsc --watch` and `tsserver`, add file watchers to missing files.
3. When missing files are created, schedule compilation (tsc) or refresh
the containing projects (tsserver).
2017-06-29 10:39:31 -07:00
Andrew Casey
587309d029 Update error case check
`getTouchingWord` indicates failure by returning the sourceFile node,
rather than `undefined`.
2017-06-29 10:39:30 -07:00
Andy
977525b37e getSymbolOfEntityNameOrPropertyAccessExpression: combine common code from PropertyAccessExpression and QualifiedName cases (#16827) 2017-06-29 10:07:08 -07:00
Andy
d73b05cc63 Fix typo (#16826) 2017-06-29 10:06:35 -07:00
Arnaud Tournier
9ccf8ca6b0 Comments incorrectly read 'TypeFlags' instead of 'ObjectFlags' at some places 2017-06-29 17:54:34 +02:00
t_
51fb7e9a81 Add alwaysStrict option (#16562)
* Add alwaysStrict option

* Enable alwaysStrict

* Fix for strict mode

* keep whitespace
2017-06-28 19:44:15 -07:00