microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-11 15:48:14 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #16696 from Microsoft/fix15663

Browse Source 
Ignore jsdoc when inferring rest args in JavaScript
This commit is contained in:
Ron Buckton
2017-06-30 14:27:55 -07:00
committed by GitHub
parent 9048c0ae47 8d9e66badd
commit 2a6aacd0ef
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@@ -6398,7 +6398,7 @@ namespace ts {
undefined;
// JS functions get a free rest parameter if they reference `arguments`
let hasRestLikeParameter = hasRestParameter(declaration);
if (!hasRestLikeParameter && isInJavaScriptFile(declaration) && !hasJSDocParameterTags(declaration) && containsArgumentsReference(declaration)) {
if (!hasRestLikeParameter && isInJavaScriptFile(declaration) && containsArgumentsReference(declaration)) {
hasRestLikeParameter = true;
const syntheticArgsSymbol = createSymbol(SymbolFlags.Variable, "args");
syntheticArgsSymbol.type = anyArrayType;

4
tests/baselines/reference/argumentsObjectCreatesRestForJs.types
View File

@@ -35,13 +35,13 @@ someRest(1, 2, 3);
* @param {number} x - a thing
*/
function jsdocced(x) { arguments; }
>jsdocced : (x: number) => void
>jsdocced : (x: number, ...args: any[]) => void
>x : number
>arguments : IArguments
jsdocced(1);
>jsdocced(1) : void
>jsdocced : (x: number) => void
>jsdocced : (x: number, ...args: any[]) => void
>1 : 1
function dontDoubleRest(x, ...y) { arguments; }