Commit Graph

19933 Commits

Author SHA1 Message Date
Andy
2b566b9a53 Add exported members of all project files in the global completion list (#19069)
* checker.ts: Remove null check on symbols

* tsserverProjectSystem.ts: add two tests

* client.ts, completions.ts, types.ts: Add codeActions member to CompletionEntryDetails

* protocol.ts, session.ts: Add codeActions member to CompletionEntryDetails protocol

* protocol.ts, session.ts, types.ts: add hasAction to CompletionEntry

* session.ts, services.ts, types.ts: Add formattingOptions parameter to getCompletionEntryDetails

* completions.ts: define SymbolOriginInfo type

* completions.ts, services.ts: Add allSourceFiles parameter to getCompletionsAtPosition

* completions.ts, services.ts: Plumb allSourceFiles into new function getSymbolsFromOtherSourceFileExports inside getCompletionData

* completions.ts: add symbolToOriginInfoMap parameter to getCompletionEntriesFromSymbols and to return value of getCompletionData

* utilities.ts: Add getOtherModuleSymbols, getUniqueSymbolIdAsString, getUniqueSymbolId

* completions.ts: Set CompletionEntry.hasAction when symbol is found in symbolToOriginInfoMap (meaning there's an import action)

* completions.ts: Populate list with possible exports (implement getSymbolsFromOtherSourceFileExports)

* completions.ts, services.ts: Plumb host and rulesProvider into getCompletionEntryDetails

* completions.ts: Add TODO comment

* importFixes.ts: Add types ImportDeclarationMap and ImportCodeFixContext

* Move getImportDeclarations into getCodeActionForImport, immediately after the implementation

* importFixes.ts: Move createChangeTracker into getCodeActionForImport, immediately after getImportDeclarations

* importFixes.ts: Add convertToImportCodeFixContext function and reference it from the getCodeActions lambda

* importFixes.ts: Add context: ImportCodeFixContext parameter to getCodeActionForImport, update call sites, destructure it, use compilerOptions in getModuleSpecifierForNewImport

* importFixes.ts: Remove moduleSymbol parameter from getImportDeclarations and use the ambient one

* importFixes.ts: Use cachedImportDeclarations from context in getCodeActionForImport

* importFixes.ts: Move createCodeAction out, immediately above convertToImportCodeFixContext

* Move the declaration for lastImportDeclaration out of the getCodeActions lambda into getCodeActionForImport

* importFixes.ts: Use symbolToken in getCodeActionForImport

* importFixes.ts: Remove useCaseSensitiveFileNames altogether from getCodeActions lambda

* importFixes.ts: Remove local getUniqueSymbolId function and add checker parameter to calls to it

* importFixes.ts: Move getCodeActionForImport out into an export, immediately below convertToImportCodeFixContext

* completions.ts: In getCompletionEntryDetails, if there's symbolOriginInfo, call getCodeActionForImport

* importFixes.ts: Create and use importFixContext within getCodeActions lambda

* importFixes.ts: Use local newLineCharacter instead of context.newLineCharacter in getCodeActionForImport

* importFixes.ts: Use local host instead of context.host in getCodeActionForImport

* importFixes.ts: Remove dummy getCanonicalFileName line

* Filter symbols after gathering exports instead of before

* Lint

* Test, fix bugs, refactor

* Suggestions from code review

* Update api baseline

* Fix bug if previousToken is not an Identifier

* Replace `startsWith` with `stringContainsCharactersInOrder`
2017-10-17 10:20:11 -07:00
csigs
3a84b661b5 LEGO: Merge pull request 19248
LEGO: Merge pull request 19248
2017-10-17 09:10:23 -07:00
csigs
1af25ae9f1 LEGO: check in for master to temporary branch. 2017-10-17 16:10:05 +00:00
csigs
fcb48dd906 LEGO: Merge pull request 19241
LEGO: Merge pull request 19241
2017-10-16 21:10:23 -07:00
csigs
92d191990a LEGO: check in for master to temporary branch. 2017-10-17 04:10:06 +00:00
Mohamed Hegazy
3c452057c2 Add release-2.6 to covered branches 2017-10-16 16:09:16 -07:00
Ron Buckton
06fd5e0bfe Merge pull request #19230 from Microsoft/fix18186
Do not reduce subtypes of awaited union type
2017-10-16 15:17:30 -07:00
Ron Buckton
169b8e436a Merge pull request #19232 from Microsoft/fix19187
Fix generated name scope when emitting async functions
2017-10-16 15:17:14 -07:00
csigs
95715603bc LEGO: Merge pull request 19234
LEGO: Merge pull request 19234
2017-10-16 15:11:04 -07:00
csigs
fd86cd5a2e LEGO: check in for master to temporary branch. 2017-10-16 22:10:47 +00:00
Ron Buckton
eebb0447ab Fix generated name scope when emitting async functions 2017-10-16 14:47:43 -07:00
Ron Buckton
9563246993 Do not reduce subtypes of awaited union type 2017-10-16 14:26:16 -07:00
Sheetal Nandi
5de6366e8a Merge pull request #19222 from Microsoft/projectCompilerOptions
Add getCompilerOptions method to project
2017-10-16 14:23:35 -07:00
Wesley Wigham
aea7e9a7a8 Fix instantiated generic mixin declaration emit (#19144)
* Fix #18545, dont use declared type of class expression

* Accept API Baselines

* Add thus far unused flag from node builder

* Accept baseline update
2017-10-16 14:17:55 -07:00
Arthur Ozga
63074bcba0 Merge pull request #16695 from aozgaa/fixIifeIndentation
Fix indentation for function argument in call expression
2017-10-16 14:03:25 -07:00
Sheetal Nandi
734bda833c Add comments about why we need two methods that return compilerOptions 2017-10-16 13:06:15 -07:00
Andy
2cb0403e2d Support 'package.json' not in package root (#19133)
* Support 'package.json' not in package root

* Test "foo/@bar"

* More tests, and don't use "types" from the root package.json if not loading the root module
2017-10-16 13:02:15 -07:00
Wesley Wigham
40222d1a77 Fix for-in emit under systemjs (#19223) 2017-10-16 12:57:23 -07:00
Andy
bac30fc1a2 In convertFunctionToEs6Class.ts, share code for getting symbol (#19160) 2017-10-16 11:41:35 -07:00
Sheetal Nandi
3c27e782da Add getCompilerOptions method to project
Fixes #19218
2017-10-16 11:22:49 -07:00
csigs
8d47ef60a9 LEGO: Merge pull request 19217
LEGO: Merge pull request 19217
2017-10-16 09:10:42 -07:00
csigs
9306543431 LEGO: check in for master to temporary branch. 2017-10-16 16:10:13 +00:00
Anders Hejlsberg
d4c0377395 Merge pull request #19185 from Microsoft/fixMappedTypesKeyofAny
Fix 'any' and 'keyof any' in mapped types
2017-10-14 12:12:25 -07:00
Mohamed Hegazy
abe45ed2b9 Merge branch 'RyanCavanaugh-fix11857' 2017-10-14 11:33:21 -07:00
Mohamed Hegazy
1f63fbbc08 Merge branch 'fix11857' of https://github.com/RyanCavanaugh/TypeScript into RyanCavanaugh-fix11857 2017-10-14 11:31:39 -07:00
Anders Hejlsberg
8e47c18636 Accept new baselines 2017-10-14 11:13:52 -07:00
Anders Hejlsberg
ee0715a073 Add tests 2017-10-14 11:13:40 -07:00
Anders Hejlsberg
fa65bd2062 Mapped type { [P in any]: T } should yield { [x: string]: T } 2017-10-14 09:53:51 -07:00
csigs
48d380f328 LEGO: Merge pull request 19181
LEGO: Merge pull request 19181
2017-10-13 21:10:21 -07:00
csigs
40cb9656f9 LEGO: check in for master to temporary branch. 2017-10-14 04:10:04 +00:00
Anders Hejlsberg
07ff0fdb81 Properly handle mapped types with 'keyof any' 2017-10-13 16:54:57 -07:00
Daniel Rosenwasser
144026cd3b Merge pull request #19174 from Microsoft/correctlyScopedtaggedTemplates-master
Fix uniqueness for tagged template variables
2017-10-13 16:54:47 -07:00
Mohamed Hegazy
faa04a2402 Update generated files (#19177) 2017-10-13 16:47:40 -07:00
Daniel Rosenwasser
258c4e0bcc Accepted baselines. 2017-10-13 15:40:32 -07:00
Daniel Rosenwasser
50085bab27 Create truly unique names for tagged template strings. 2017-10-13 15:40:32 -07:00
Daniel Rosenwasser
16f7f6f2e9 Added test case. 2017-10-13 15:40:31 -07:00
csigs
e537a7bdf5 LEGO: Merge pull request 19171
LEGO: Merge pull request 19171
2017-10-13 15:10:41 -07:00
csigs
fadf4914bb LEGO: check in for master to temporary branch. 2017-10-13 22:10:24 +00:00
Andy
769d202d4c In getContextuallyTypedParameterType, skip a this parameter when counting parameter index (#19155) 2017-10-13 14:53:52 -07:00
Nathan Shively-Sanders
22769d95e1 Merge pull request #18747 from Microsoft/refactor-jsdoc-types-to-typescript
Refactor jsdoc types to typescript
2017-10-13 10:21:54 -07:00
Nathan Shively-Sanders
4cf06bbb02 Fix spacing lint 2017-10-13 10:02:04 -07:00
Nathan Shively-Sanders
84e3507151 return more Debug.fails instead of undefined. 2017-10-13 09:45:41 -07:00
Nathan Shively-Sanders
c83daa6481 JSDoc->type refactor:Renames+improve never handling 2017-10-13 09:38:01 -07:00
csigs
027528e9b8 LEGO: Merge pull request 19157
LEGO: Merge pull request 19157
2017-10-13 09:10:27 -07:00
csigs
c3a2dc3f44 LEGO: check in for master to temporary branch. 2017-10-13 16:10:06 +00:00
Andy
6099b09a6e Create source files lazily in tests (#19143) 2017-10-13 07:17:17 -07:00
Andrew Casey
d940cdadfe Merge pull request #19141 from amcasey/MissingNewlineAtEOF
Insert a line break before a function at EOF if needed
2017-10-12 15:28:37 -07:00
Wesley Wigham
de0e475c64 Recreate old decorator metadata behavior (#19089)
* Emulate pre 2.4 metadata behavior of eliding null and undefined from unions without strictNullChecks

* Accept baseline

* Update comment

* Update for second old baseline

* Respect strict
2017-10-12 15:05:04 -07:00
Nathan Shively-Sanders
f35764d4ec Fix duplicated JSDoc comments
Incorporate suppressLeadingAndTrailingTrivia just added by @amcasey.
2017-10-12 14:28:34 -07:00
Andrew Casey
2ea4cfe23b Insert a line break before a function at EOF if needed
This is a pre-existing issue that became more obvious after refining
trivia handling.
2017-10-12 14:19:36 -07:00