6243 Commits

Author SHA1 Message Date
Andy
f945b26b54 Forbid type assertions in '.js' files (#17503) 2017-07-29 05:41:08 -07:00
Andy
2efaa7c9e2 Forbid non-null assertion in '.js' files (#17481) 2017-07-28 16:40:20 -07:00
Daniel Rosenwasser
4315c2a25f Added failing test case. 2017-07-27 18:11:34 -07:00
Anders Hejlsberg
06cfe51a45 Merge pull request #17430 from Microsoft/inferenceExcessProperties
Fix inference with excess properties
2017-07-27 17:35:37 -07:00
Anders Hejlsberg
e7e6475440 Merge pull request #17382 from Microsoft/fixPartialTypeRelations
Fix partial type relations
2017-07-27 17:31:55 -07:00
Daniel Rosenwasser
935b895ac1 Added/augmented tests. 2017-07-27 14:55:29 -07:00
Daniel Rosenwasser
e9330d4994 Add test case for code fixes on qualified names used instead of indexed access types. 2017-07-27 12:40:57 -07:00
Daniel Rosenwasser
c14ff00bcf Added test case. 2017-07-27 11:22:12 -07:00
Mine Starks
89994111bd Missing import code fix - include export assignment properties when looking for module exports (#17376)
* Include export assignment properties when looking for module exports

* Create new API function for tryGetMemberInModuleExportsAndProperties

* Cleanup based on review feedback
2017-07-26 16:17:01 -07:00
Andy
cc8399dc41 Escape string literal before looking it up in enum's symbol table (#17441) 2017-07-26 16:00:34 -07:00
Wesley Wigham
b080aa9440 Fix #16778 - use previous type and not declared type (#17381)
* Fix #16778 - use previous type to check discriminable type and not declared type

* Rename prevType -> computedType
2017-07-26 15:27:02 -07:00
Nathan Shively-Sanders
fdb44651a3 Merge pull request #17352 from Microsoft/jsdoc-param-type-literals
Parse jsdoc `@param` type literals
2017-07-26 15:17:31 -07:00
Wesley Wigham
61c6ecbb2d Tests for #17371 (#17373) 2017-07-26 11:48:22 -07:00
Nathan Shively-Sanders
9fd90e7e02 Merge branch 'master' into jsdoc-param-type-literals 2017-07-26 11:09:24 -07:00
Nathan Shively-Sanders
9e59dacbfa Update baselines 2017-07-26 10:59:08 -07:00
Wesley Wigham
5b77ef8b4d Fix infinite loop in jsdoc parsing (#17420)
* Test case

* Move parameter fix to apply to jsdoc (and all lists)

* Inline function, generalize comment
2017-07-26 10:12:59 -07:00
Anders Hejlsberg
a14144be9c Add regression test 2017-07-26 07:16:26 -07:00
Andy
a59db13004 Fix typo: Infered -> inferred (#17417) 2017-07-26 07:16:26 -07:00
Nathan Shively-Sanders
c55a043767 Address PR comments from Andy
I'll take a look at Wesley's next and see if those require any changes.
2017-07-25 14:14:12 -07:00
Ron Buckton
d74cb24640 Merge pull request #17354 from weswigham/fix-parameter-parsing-infinite-loop
Fix parameter parsing infinite loop
2017-07-24 18:21:10 -07:00
Anders Hejlsberg
1d9c3e1c22 Add repro 2017-07-24 17:07:24 -07:00
Anders Hejlsberg
f6ed29df3a Add tests 2017-07-24 17:06:45 -07:00
Wesley Wigham
7040df2094
Tests covering the bug 2017-07-21 17:30:01 -07:00
Nathan Shively-Sanders
e942bbb6f2 Test: jsdoc @param type literals 2017-07-21 14:49:07 -07:00
Mine Starks
441daa4e19 Merge pull request #17302 from minestarks/removeimportfix
Bugs in missing import codefix
2017-07-21 10:22:24 -07:00
Mine Starks
9f6ec635a4 Cleaner path splitting, refine file extension and case sensitivity handling 2017-07-20 16:12:07 -07:00
Armando Aguirre
fe86d2fc06 Merge pull request #17257 from armanio123/FixNodeModulesTodos
Added node_modules path check on getTodoComments method.
2017-07-20 14:58:36 -07:00
Ron Buckton
8fa1d2e3e6 Merge pull request #17141 from Microsoft/master-17060
Fix 17060 : incorrect emit for dynamic import inside elements of  export class declaration
2017-07-20 12:11:10 -07:00
Wesley Wigham
7cb8ce4346 Fix exceptions on empty tuple errors (#17311)
* Fix exceptions on empty tuple errors

* Remove bonus semicolon

* Invert condition
2017-07-20 10:09:55 -07:00
gcnew
0654fa285c Added tests 2017-07-20 02:59:33 +03:00
Armando Aguirre
9bdd17e842 Added explanation comment for excluding files. 2017-07-19 15:42:01 -07:00
Mine Starks
15d294d350 Bugs in missing import codefix
- We didn't locate the package.json correctly in cases where the module to be imported is in a subdirectory of the package
- We didn't look at the types element in package.json (just typings)
- We didn't remove /index.js from the path if the main module was in a subdirectory

Fixes #16963
2017-07-19 11:02:49 -07:00
Andy
cfa94c2d34 Binder: handle JS property assignment that comes after a method declaration with the same name (#16830) 2017-07-19 09:11:50 -07:00
Wesley Wigham
8075353356 Appropriately parenthesize keyof and typeof queries in array types (#17272)
* Appropriately parenthesize keyof and typeof queries when they are array types

* Fix test and then the same bug in the symbol writer
2017-07-18 15:08:53 -07:00
Nathan Shively-Sanders
fb89d47508 Merge pull request #17252 from Microsoft/contextually-type-this-in-object-literals-in-javascript
Contextually type this in object literals in JS
2017-07-18 10:18:10 -07:00
Nathan Shively-Sanders
95f5bc1ee0 Add unknown property to test of contextual this type 2017-07-18 10:01:22 -07:00
Wesley Wigham
695514290f Fix #17023 (#17180)
* Fix #17023

* Be more general when handling matching references through binding elements

* Better cache key, PR feedback

* Deeper tests, better cache key handling
2017-07-18 09:12:25 -07:00
Nathan Shively-Sanders
7d7a06dbc2 Merge pull request #17250 from Microsoft/quickfix-jsdoc-in-ts
Quickfix jsdoc in Typescript files
2017-07-18 08:59:19 -07:00
Nathan Shively-Sanders
1b7faf10ac Merge pull request #17254 from Microsoft/generic-Object-jsdoc-creates-index-signature
JSDoc:Object<string, T> creates index signature
2017-07-18 08:48:56 -07:00
Wesley Wigham
8a1cd33451 Use jsdoc casts (#17251)
* Allow jsdoc casts of parenthesized expressions

* Feedback from #17211
2017-07-17 23:39:20 -07:00
Armando Aguirre
6f28f83f18 Added node_modules path check on getTodoComments method. 2017-07-17 17:35:46 -07:00
Nathan Shively-Sanders
10a91c5426 JSDoc:Object<string, T> creates index signature
And `Object<number, T>` creates a numeric index signature. Other uses
still create `any` as before.
2017-07-17 16:14:42 -07:00
Nathan Shively-Sanders
08ae02263a Contextually type this in object literals in JS
Previously, `this` would only get a contextual type inside object
literals with `--noImplicitThis` turned on in Typescript files.
2017-07-17 15:59:18 -07:00
Nathan Shively-Sanders
cbe7b4dba3 Update jsdoc codefix tests; test function(...) syntax 2017-07-17 14:11:06 -07:00
Andy
6cf30fbccf Fix bug in importTracker: getExportNode must verify that we are on the LHS of a VariableDeclaration (#17205) 2017-07-17 12:29:29 -07:00
Nathan Shively-Sanders
f9e5576d58 Codefix for ?! pre/postfix JSDoc types
For ?, provide two code fixes, one for jsdoc/closure semantics
(`?t -> t | null)` and one for flow semantics
(`?t -> t | null | undefined`).

The current way of doing this is the hackiest thing you can imagine, but
it was easier than lifting everything into the list monad for a code fix
that I might not actually keep.
2017-07-17 11:06:20 -07:00
Nathan Shively-Sanders
3776b0b58b Codefix for Array.<number> -> Array<number> 2017-07-17 10:33:04 -07:00
Nathan Shively-Sanders
e98ac8d970 Merge branch 'parse-jsdoc-with-ts-type-parser' into quickfix-jsdoc-in-ts 2017-07-17 08:42:00 -07:00
Nathan Shively-Sanders
3f60364a64 Improve test of jsdoc literal type parsing 2017-07-17 08:29:40 -07:00
Nathan Shively-Sanders
a3a6862d43 Add simple jsdoc code fix changes 2017-07-14 16:27:09 -07:00