microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-04-23 01:10:18 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Forbid type assertions in '.js' files (#17503)

Browse Source
This commit is contained in:
Andy
2017-07-29 05:41:08 -07:00
committed by GitHub
parent b0435d8490
commit f945b26b54
6 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/checker.ts
View File

@@ -16384,10 +16384,6 @@ namespace ts {
}
function checkNonNullAssertion(node: NonNullExpression) {
if (isInJavaScriptFile(node)) {
error(node, Diagnostics.non_null_assertions_can_only_be_used_in_a_ts_file);
}
return getNonNullableType(checkExpression(node.expression));
}

10
src/compiler/program.ts
View File

@@ -1196,10 +1196,14 @@ namespace ts {
case SyntaxKind.EnumDeclaration:
diagnostics.push(createDiagnosticForNode(node, Diagnostics.enum_declarations_can_only_be_used_in_a_ts_file));
return;
case SyntaxKind.TypeAssertionExpression:
const typeAssertionExpression = <TypeAssertion>node;
diagnostics.push(createDiagnosticForNode(typeAssertionExpression.type, Diagnostics.type_assertion_expressions_can_only_be_used_in_a_ts_file));
case SyntaxKind.NonNullExpression:
diagnostics.push(createDiagnosticForNode(node, Diagnostics.non_null_assertions_can_only_be_used_in_a_ts_file));
return;
case SyntaxKind.AsExpression:
diagnostics.push(createDiagnosticForNode((node as AsExpression).type, Diagnostics.type_assertion_expressions_can_only_be_used_in_a_ts_file));
return;
case SyntaxKind.TypeAssertionExpression:
Debug.fail(); // Won't parse these in a JS file anyway, as they are interpreted as JSX.
}
const prevParent = parent;

17
tests/baselines/reference/jsFileCompilationTypeAssertions.errors.txt
View File

@@ -1,14 +1,15 @@
error TS5055: Cannot write file 'tests/cases/compiler/a.js' because it would overwrite input file.
Adding a tsconfig.json file will help organize projects that contain both TypeScript and JavaScript files. Learn more at https://aka.ms/tsconfig.
tests/cases/compiler/a.js(1,10): error TS17008: JSX element 'string' has no corresponding closing tag.
tests/cases/compiler/a.js(1,27): error TS1005: '</' expected.
/src/a.js(1,6): error TS8016: 'type assertion expressions' can only be used in a .ts file.
/src/a.js(2,10): error TS17008: JSX element 'string' has no corresponding closing tag.
/src/a.js(3,1): error TS1005: '</' expected.
!!! error TS5055: Cannot write file 'tests/cases/compiler/a.js' because it would overwrite input file.
!!! error TS5055: Adding a tsconfig.json file will help organize projects that contain both TypeScript and JavaScript files. Learn more at https://aka.ms/tsconfig.
==== tests/cases/compiler/a.js (2 errors) ====
==== /src/a.js (3 errors) ====
0 as number;
~~~~~~
!!! error TS8016: 'type assertion expressions' can only be used in a .ts file.
var v = <string>undefined;
~~~~~~
!!! error TS17008: JSX element 'string' has no corresponding closing tag.
!!! error TS1005: '</' expected.

9
tests/baselines/reference/jsFileCompilationTypeAssertions.js Normal file
View File

@@ -0,0 +1,9 @@
//// [a.js]
0 as number;
var v = <string>undefined;
//// [a.js]
0;
var v = <string>undefined;
</>;

1
tests/cases/compiler/jsFileCompilationNonNullAssertion.ts
View File

@@ -1,5 +1,4 @@
// @allowJs: true
// @checkJs: true
// @filename: /src/a.js
// @out: /bin/a.js
0!

6
tests/cases/compiler/jsFileCompilationTypeAssertions.ts
View File

@@ -1,3 +1,5 @@
// @allowJs: true
// @filename: a.js
var v = <string>undefined;
// @filename: /src/a.js
// @out: /lib/a.js
0 as number;
var v = <string>undefined;