4945 Commits

Author SHA1 Message Date
Daniel Rosenwasser
c77fcf217b
Merge pull request #28932 from j-oliveras/No-es2015-usages
Change es2015 usages to existing ts functions
2018-12-10 17:11:28 -08:00
Jordi Oliveras Rovira
599a963493
Add newline 2018-12-09 20:42:46 +01:00
Jordi Oliveras Rovira
4e43dcdc05 Change usages of String.prototype.endsWith to ts.endsWith. 2018-12-09 20:25:17 +01:00
Anders Hejlsberg
992513791d Fix findAllReferences for 'this' parameter declarations 2018-12-08 11:03:37 -08:00
Nathan Shively-Sanders
ee987a25e2
Revert over-eager bailout when trailing whitespace (#28848) 2018-12-04 12:45:00 -08:00
Sheetal Nandi
c85460bc44
Merge pull request #28818 from Cow258/master
Move await keyword to inside of function
2018-12-04 12:36:13 -08:00
Nathan Shively-Sanders
594430f113
Infer from arrows from usage. (#28832)
* Infer from arrows from usage.

Previously only function expressions were, and only those with an easily
accessible name. Now any arrow function or function expression will
infer from usage.

* remove isApplicableFunctionForInference

*all* functions are applicable for inference now.
2018-12-04 09:03:08 -08:00
dreamran43@gmail.com
a2851d2ddc Move await keyword to inside of function and test 2018-12-04 03:01:56 +08:00
dreamran43@gmail.com
f2d297fd1f Move await keyword to inside of function and test 2018-12-04 02:40:43 +08:00
dreamran43@gmail.com
8eefaf48f5 Move await keyword to inside of function (Recovery & try test) 2018-12-04 01:50:02 +08:00
dreamran43@gmail.com
0a6380c6df Move await keyword to inside function 2018-12-04 00:32:33 +08:00
Sheetal Nandi
23abcc02a3 Use compilerOptionsIndicateEs6Modules over program contains es6 modules for determining auto import offering. Also dont depend on uncheck js file for this.
Fixes #28696
2018-11-29 11:58:32 -08:00
Sheetal Nandi
dc03115d14
Merge pull request #28585 from Microsoft/isTypeOnlyCompletion
Properly set symbolMeanings when calling getSymbolsInScope
2018-11-19 08:50:41 -08:00
Sheetal Nandi
eeaa8bb527
Merge pull request #28533 from Microsoft/generateGetAndSet_noFindAllRefs
generateGetAccessorAndSetAccessor: Don't use FindAllReferences
2018-11-19 08:47:12 -08:00
Andy Hanson
59c014ba32 Properly set symbolMeanings when calling getSymbolsInScope 2018-11-16 17:04:29 -08:00
Andy
12f3d0d54c
Enable --strictPropertyInitialization (#27558)
* Enable --strictPropertyInitialization

* Code review
2018-11-16 16:02:23 -08:00
Nathan Shively-Sanders
ea8ccc2ce4
In JS, constructor functions infer from call+construct (#28353)
* constructor functions infer from call+construct

Also fix an incorrect combining of inferences for rest parameters: the
inferred types will be arrays in the body of the function and the
arguments from outside the function will be the element type.

* All functions infer from call+construct contexts
2018-11-16 09:51:07 -08:00
Andy
a6ef176dbb
Consistently return 'void' from ChangeTracker methods (#28563) 2018-11-16 08:58:00 -08:00
Andy
b059135c51
When adding relative completions with rootDirs, still add completions for regular relative imports (#28561) 2018-11-15 15:11:27 -08:00
Klaus Meinhardt
1ad7b0fe69 forEachToken: correctly handle JSDocTag (#28369)
* forEachChild: handle JSDocTags and all their children

* fix codefix for unused identifier

* fix lint

* fix build

* Fix test failures
2018-11-15 13:22:25 -08:00
Nathan Shively-Sanders
6cee7c3080
Better nameless parameter implicit any error (#28554)
* Initial version, doesn't work for primitives yet.

Need to find out why.

* Primitives now work, plus improve error message

null and void don't even parse without parameter names so they are not
tested.

* Codefix: Add names to nameless parameters

* Improve error wording

* Add detail to error message
2018-11-15 12:45:39 -08:00
Nathan Shively-Sanders
7a7328a17f
string|number inferences are low priority (#28381)
* string|number inferences are low priority

Also, refactor unifyFromContext to explicitly handle priorities

* string/number/strnum are not mutually exclusive

* Assert that high/low can't apply to same element
2018-11-15 08:32:28 -08:00
Andy
2600250a24
Add 'bigint' to type keywords (#28537) 2018-11-14 22:18:05 -08:00
Daniel Rosenwasser
fe263708be
Merge pull request #27019 from iliashkolyar/codefix_add_missing_new_operator
Codefix: add quick fix for missing 'new' operator
2018-11-14 16:53:25 -08:00
Andy Hanson
643678bb54 generateGetAccessorAndSetAccessor: Don't use FindAllReferences 2018-11-14 15:05:46 -08:00
Andy
da37457c72
When renaming an imported symbol, rename only in current file (#28406)
* When renaming an imported symbol, rename only in current file

* Improve re-export references

* Remember to use 'range' in for loop

* Uncomment tests
2018-11-14 09:09:00 -08:00
Wesley Wigham
d99de73e85
Handle type argument lists as jsx completion starts (#28493)
* Handle type argument lists as jsx completion starts

* preceeding -> preceding
2018-11-12 16:30:04 -08:00
Wesley Wigham
11eee2b6ee
Slightly improve missing property errors (#28298)
* Slightly improve missing property errors

* Add missing quote

* Fix jsx case

* Add related span

* Fix crash (why can declarations be undefined)

* Only skip top elaboration when no variant message is provided
2018-11-12 14:31:15 -08:00
Andy
fe1ba9bee3
Improvements to generateTypes (#28458)
* Improvements to generateTypes

* createProperty only if necessary
2018-11-12 11:50:48 -08:00
Andy
0077016c63
Reduce duplicate code in getListByRange (#28455) 2018-11-12 09:43:40 -08:00
Sheetal Nandi
d569743640
Merge pull request #28194 from iliashkolyar/add_missing_apostrophe_in_codefix
Add missing apostrophe to codefix suggestion
2018-11-12 09:31:24 -08:00
Sheetal Nandi
d6df82a77c
Merge pull request #28454 from Microsoft/codeFixAfterPrologue
Include code fix after prologue
2018-11-09 16:56:43 -08:00
Sheetal Nandi
c60ff902f1 Include code fix after prologue
Fixes #15515
2018-11-09 16:02:16 -08:00
iliashkolyar
047b76f979 Merge branch 'master' into codefix_add_missing_new_operator 2018-11-10 01:45:11 +02:00
Daniel Rosenwasser
02ca5bebbf
Merge pull request #28340 from saschanaz/listindent-revive
List position based formatting
2018-11-09 15:34:16 -08:00
Ron Buckton
50a0174582
Merge pull request #27629 from Microsoft/sourceMapGenerator
Simplify source map generation
2018-11-09 14:50:22 -08:00
Daniel Rosenwasser
2585ccbe39
Merge pull request #28281 from ryanclarke/master
Add codefix for 'convert to unknown' diagnostic
2018-11-09 14:43:25 -08:00
Andy
e335a360c8
Change 'if' in combined switch case to two separate cases (#28444) 2018-11-09 12:48:47 -08:00
Ron Buckton
151dc074a8 Merge branch 'master' into sourceMapGenerator 2018-11-09 11:50:51 -08:00
Andy
aaf1d8055b
Support finding references at module in module.exports = or export in export = (#28221)
* Support finding references at `module` in `module.exports =` or `export` in `export =`

* Add json test
2018-11-09 09:38:45 -08:00
Markus Wolf
499bed540b
Better reference usage detection 2018-11-09 09:45:20 +01:00
Markus Wolf
6bd298b884
add test for remove modifier and parameter 2018-11-09 09:45:12 +01:00
Markus Wolf
13e85ac3a9
add more modifiers 2018-11-09 09:45:12 +01:00
Markus Wolf
de7faa1b7e
Remove obsolte ts namespace 2018-11-09 09:45:11 +01:00
Markus Wolf
e6e71978df
Correct codefix by removing private modifier
In case of private attribute and private constructor parameter with
assignment in the constructor body, the parameter is flagged as unused.
This is caused by the private modifier which is shadowed by the
explicity assignment in the body.
This commit updates the codefix to just remove the private modifier in
this cases.

Closes #24931
2018-11-09 09:45:11 +01:00
Kagami Sascha Rosylight
7995f9153a apply suggested changes 2018-11-09 11:26:58 +09:00
Sheetal Nandi
c0587191fc
Merge pull request #28418 from ajafff/internal-comments
remove even more internal comments
2018-11-08 14:58:33 -08:00
Sheetal Nandi
b534fb4849
Merge pull request #27980 from EECOLOR/leading-slash-imports
match leading slash imports with path mappings - fixes #13730
2018-11-08 09:20:45 -08:00
Ryan Clarke
ecb88f5a3e Fix comments on pull request 2018-11-07 21:43:02 -05:00
EECOLOR
1a9c20949e path mappings now supports rooted disk paths and urls - fixes #13730 2018-11-07 22:19:04 +01:00