Commit Graph

22427 Commits

Author SHA1 Message Date
Josh Goldberg
0dbebec28f Feedback: correct order in watch.ts; DRY tests 2018-04-04 13:21:19 -04:00
Josh Goldberg
cf0a0ec001 Fixed unit tests for error counts 2018-04-01 22:57:38 -07:00
Josh Goldberg
d268279c8e Merge branch 'master' into pretty-watch-error-summaries 2018-04-01 21:44:55 -07:00
Anders Hejlsberg
b3829523b2 Merge pull request #23039 from Microsoft/fixConditionalConstraints
Improve conditional type constraints
2018-03-31 11:56:05 -07:00
Wesley Wigham
9b558f9535 Remove _this, _super, and _newTarget name conflict errors (#22890)
* Add new generated name kind for reused transpiler variables

* Remove error on _super or _newTarget conflict

* Add test with super helper conflict

* Remove error on _this conflict

* Fix lint

* Use flags instead of generated kinds, inline some things

* Accept rename

* Remove trailing whitespace

* Move helper emit into printer, rather than emitter"

* passthru module and target

* New test, accept baselines

* Make members private
2018-03-30 17:43:37 -07:00
Wesley Wigham
8543d30372 Add union check to improved error message (#23027) 2018-03-30 16:23:24 -07:00
Anders Hejlsberg
3d91736f6c Accept new baselines 2018-03-30 16:21:23 -07:00
Anders Hejlsberg
b84e05e669 Add tests 2018-03-30 16:21:16 -07:00
Wesley Wigham
a53f9e8ec3 Call ensureModifiers on private property modifiers (#23026) 2018-03-30 16:07:09 -07:00
Arthur Ozga
9dd3ef4205 Merge pull request #22849 from aozgaa/dev/aozgaa/cSharpObjLiteralFormatting
CSharp Style Object Literal Formatting
2018-03-30 15:45:46 -07:00
Anders Hejlsberg
6f681d276a Constraint of 'T extends U ? T : F' should be 'T & U | F' 2018-03-30 15:28:01 -07:00
Andy
e14964169a Combine getDocumentationComment implementations (#22722) 2018-03-30 09:43:12 -07:00
Andy
a5df301dec Simplify getPropertySymbolsFromBaseTypes (#23004) 2018-03-30 09:42:49 -07:00
Mohamed Hegazy
31c3ef51d3 Merge pull request #22251 from jack-williams/jack-williams/no-implicit-symbol-to-string
Fix #19666: Check for symbol types in template expressions
2018-03-30 09:32:11 -07:00
Mohamed Hegazy
849ecdf50a Merge pull request #22981 from a-tarasyuk/bug/advanced-options-do-not-work-with---init
Allow using Advanced_Options with --init
2018-03-30 09:22:49 -07:00
Alexander T
75df5456a2 Allow using Advanced_Options with --init. Exclude all possible Advanced_Options in tsconfig.json which were NOT defined in command line 2018-03-30 07:49:16 +03:00
Anders Hejlsberg
7714a2bb5b Merge pull request #22989 from Microsoft/fixImpliedConstraint
Fix implied constraints in conditional types
2018-03-29 17:06:16 -07:00
Mohamed Hegazy
b47c1fd5a1 Merge pull request #22593 from Kingwl/module-spelling-fix
add spelling suggestion support for module
2018-03-29 16:56:43 -07:00
Wesley Wigham
6b7bf5e22c Do not rely on ElementAttributeProperty if it is not present (#22936)
* Do not rely on ElementAttributeProperty if it is not present

* Fix bug

* Fix nits and lint
2018-03-29 16:19:55 -07:00
Wesley Wigham
1ed30c6d4d Elide type reference comments which are also imported (#22752)
* Elide type reference comments which are also imported

* Explicit undefined

* Accept reordered symbols
2018-03-29 16:15:55 -07:00
Arthur Ozga
8c88ce712b update baselines 2018-03-29 16:11:17 -07:00
Arthur Ozga
95a69cbeb4 Merge branch 'master' into dev/aozgaa/cSharpObjLiteralFormatting 2018-03-29 16:10:33 -07:00
Wesley Wigham
1e5641ba8e Mangle comment for sorcery (#23006) 2018-03-29 16:05:31 -07:00
Wesley Wigham
3189d1732c Handful more usages of emitIfPresent on optional nodes (#22274) 2018-03-29 15:45:17 -07:00
Andy
09cfc0f9ef Remove unused method (#23000) 2018-03-29 15:44:06 -07:00
Andy
5cef6274c3 Remove duplicate helper function (#23001) 2018-03-29 15:43:31 -07:00
Mohamed Hegazy
e3f02b5608 Merge pull request #22275 from delftswa2018/21617-detailed-error-forof-iterators
Fix #21617: Give detailed message on `for-of` of iterators without downlevelIteration
2018-03-29 15:43:00 -07:00
Mohamed Hegazy
24dbc9e2eb Merge pull request #22506 from EcoleKeine/patch-2
Fix some Constructor's signature missing null type
2018-03-29 15:41:41 -07:00
Andy
4a39caffd4 Use isExternalModuleImportEquals in one more place (#22417) 2018-03-29 15:40:25 -07:00
Arthur Ozga
5fb5ff7bf3 add option for object literal indent 2018-03-29 15:40:23 -07:00
Wesley Wigham
ea8904e33d Propagate noDefaultLib comment into emitted declaration files (#23003) 2018-03-29 15:38:29 -07:00
Benjamin Lichtman
d2d0f86831 Merge pull request #20374 from uniqueiniquity/symlinkTypeReferenceDirective
Handle failure to properly resolve type reference directives
2018-03-29 15:26:30 -07:00
Ryan Cavanaugh
5af72b5f02 Merge pull request #22993 from dhruvrajvanshi/issue-22785
Issue 22785
2018-03-29 15:10:04 -07:00
Andy
4309c0e7f8 Fix bug: ClassDeclaration not guaranteed to be first declaration of a class (#22983)
* Fix bug: ClassDeclaration not guaranteed to be first declaration of a class

* fix test
2018-03-29 14:55:22 -07:00
Wesley Wigham
793f4696a4 Fall back to check expression if resolving an export assigned entity name fails (#22928)
* Fall back to check expression if resolving an export assigned entity name fails

* Comments from code review

* Add back in assertion

* Remove nameNotFoundMessage check from resolveName isReferenced check (rely on just isUse instead)
2018-03-29 13:54:12 -07:00
Wesley Wigham
3acafe5f42 Consider property accesses in heritage clauses as type-space references for calculating type reference directives (#22746) 2018-03-29 13:51:52 -07:00
Andy
c861fa9202 Use 'map.get' instead of 'has' (#22998) 2018-03-29 13:48:24 -07:00
Wesley Wigham
43a482f03f Emit amd-module and amd-dependency comments in emitter if printing declaration comments (#22740)
* Emit amd-module and amd-dependency comments in emitter if printing declaration comments

* Move code a bit

* Move again
2018-03-29 13:43:31 -07:00
Wesley Wigham
509a53fea7 Propagate CheckFlags.Late through instantiateSymbol (#22749) 2018-03-29 13:42:26 -07:00
Wesley Wigham
411c59a8ef Copy comments from inferred types to generated nodes (#22730) 2018-03-29 13:38:36 -07:00
Wesley Wigham
64ee623fd6 NodeBuilder only preserves parameter modifiers for constructors (#22706) 2018-03-29 13:34:07 -07:00
Andy
9d713b6db6 Error on rest parameter with trailing comma (#22262)
* Error on rest parameter with trailing comma

* Error on binding patterns and improve error location
2018-03-29 13:12:23 -07:00
Sheetal Nandi
a0fe072fa7 Merge pull request #22613 from Microsoft/configFileErrors
Make config file parsing errors available through program and expose API
2018-03-29 13:08:03 -07:00
Andy
d5a7dc1053 fixAddMissingMember: Remove special-casing for 'this' (#22987)
* fixAddMissingMember: Remove special-casing for 'this'

* Update type of 'call'
2018-03-29 12:54:17 -07:00
Wesley Wigham
51a4fe6d20 Handle ts-only declaration export aliases in system transformer (#22919)
* handle ts declarations export alises in system transformer

* Retain end of declaration marker
2018-03-29 12:50:29 -07:00
Wesley Wigham
3365272f69 Dont follow aliases when looking for default exported symbol (#22995) 2018-03-29 12:46:31 -07:00
Wesley Wigham
51d44b6097 Move JSX props support check and make syntactic (#22970)
* Move JSX props support check and make syntactic

* Make parameter required
2018-03-29 12:36:42 -07:00
Andy
e4a73f3981 Assert argument is provided to diagnostic (#22992) 2018-03-29 12:28:37 -07:00
Andy
a9aca81601 Error on for (const x in never) (#22988)
* Error on `for (const x in never)`

* Update diagnostic

* Provide argument to diagnostic
2018-03-29 11:39:30 -07:00
Dhruv Rajvanshi
866c542522 Adding trailing newline to a baseline test file 2018-03-30 00:00:18 +05:30