32753 Commits

Author SHA1 Message Date
TypeScript Bot
55e13e9115 Bump version to 4.5.5 and LKG v4.5.5 2022-01-20 00:53:53 +00:00
TypeScript Bot
c5ce1706f4
Cherry-pick PR #47500 into release-4.5 (#47514)
Component commits:
43c3f45fd0 Modify debug assertion to avoid crashing on SyntaxList

9570a59da4 PR changes

e9a2355e80 More PR feedback

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
2022-01-19 15:05:28 -08:00
TypeScript Bot
84509012f3
Cherry-pick PR #47433 into release-4.5 (#47515)
Component commits:
fce282b5bd Add failing test.

ea2c290ba8 Update failing test.

d954948394 Finalized failing test case.

f476e8426b Separate our usages of utilities that expect variables initialized to require(...) and require(...).foo.

9f0810c26d Renamed types and utilities, removed accidental indentation.

bf708bfde7 Renamed both utilitiy functions uniformly.

Co-authored-by: Daniel Rosenwasser <drosen@microsoft.com>
2022-01-19 15:05:16 -08:00
Jake Bailey
8a8048fb62
Rewrite logic for JSX attribute completion detection [4.5 cherry pick] (#47413) 2022-01-14 10:15:58 -08:00
TypeScript Bot
14016a7851
Cherry-pick PR #47395 into release-4.5 (#47421)
Component commits:
f230a5af47 Add failing test.

3ba84692c6 Guard against undefined module bodies in navbar/navtree.

Co-authored-by: Daniel Rosenwasser <drosen@microsoft.com>
2022-01-13 12:16:36 -08:00
TypeScript Bot
0854a93040
Cherry-pick PR #47136 into release-4.5 (#47379)
Component commits:
e61702c7df Fix extract type crash

Co-authored-by: Andrew Branch <andrew@wheream.io>
2022-01-12 11:26:13 -08:00
TypeScript Bot
a5ebd5382b
Cherry-pick PR #47348 into release-4.5 (#47349)
Component commits:
755e1cbc88 Add minimal failing test

d52b9d3cee Fix checker initialization crash with esModuleInterop global merges resolving to ImportEquals aliases

Co-authored-by: Andrew Branch <andrew@wheream.io>
2022-01-12 11:20:19 -08:00
TypeScript Bot
1bc124e635 Bump version to 4.5.4 and LKG v4.5.4 2021-12-11 00:10:14 +00:00
TypeScript Bot
1d4ec40130
Cherry-pick PR #47096 into release-4.5 (#47105)
Component commits:
191aa682f8 Disable JSX attribute snippet if attribute is acutally the HTML tag

1786d5e278 Add more tests of text before and after

7ac5e596ce Big comment

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
2021-12-10 15:47:23 -08:00
TypeScript Bot
002c79bf50 Bump version to 4.5.3 and LKG v4.5.3 2021-12-07 23:41:28 +00:00
TypeScript Bot
ae448625b0
Cherry-pick PR #46599 into release-4.5 (#46974)
Component commits:
ddc106b854 Decrease recursion depth limit to 3 + smarter check for recursion

86185ad96b Accept new baselines

52e10d3a98 Always set last type id

5f37d89c88 Keep indexed access recursion depth check

9df07a8482 Less expensive and corrected check for broadest equivalent keys

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
2021-12-07 15:19:19 -08:00
TypeScript Bot
c63f0cf7d2
Cherry-pick PR #46973 into release-4.5 (#47005)
Component commits:
0612e180c2 Fix checker initialization crash

2064b74c2d Move checks to a place that makes more sense

Co-authored-by: Andrew Branch <andrew@wheream.io>
2021-12-07 15:16:27 -08:00
TypeScript Bot
d710e39921
🤖 Pick PR #47007 (Use features for selected module re...) into release-4.5 (#47016)
* Cherry-pick PR #47007 into release-4.5

Component commits:
48b9027927 Use features for selected module resolution rather than all features for type reference directives, since they can add restrictions to resolutions

* Update baselines for error in stable release versions

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
Co-authored-by: Andrew Branch <andrew@wheream.io>
2021-12-07 15:16:18 -08:00
TypeScript Bot
c1758b555d
Cherry-pick PR #46951 into release-4.5 (#47058)
Component commits:
e19aed36d8 Fix Awaited<T> for onfulfilled callbacks with more than one argument

f4b3ef2f95 Merge branch 'main' into fix46934

Co-authored-by: Ron Buckton <rbuckton@microsoft.com>
2021-12-07 15:15:57 -08:00
Andrew Branch
49b1acc126
Pin chalk to ^4.1 (#46985) (#47014)
* Pin chalk to ^4.1

* Revert #46931

Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
2021-12-03 14:38:39 -08:00
TypeScript Bot
7893f689fe Bump version to 4.5.2 and LKG v4.5.2 2021-11-12 00:09:49 +00:00
TypeScript Bot
460515fb4b
Cherry-pick PR #46787 into release-4.5 (#46789)
Component commits:
931b504836 Revert "Fix RWC missing file detection (#46673)"
This reverts commit 4a065f524c1f843df297f6ee01313c6bc31d4f65.

afef282bb3 Revert "Pass absolute path to directoryExists (#46086)"
This reverts commit 55b4928e820c0a16698eff41ba08bfe550a75604.

f1a20b34a2 Revert "Reduce exceptions (#44710)"
This reverts commit c0d5c29080e242f85a55e52e42f61065042d1730.

56842cd3bc Add back system watcher limit

Co-authored-by: Andrew Branch <andrew@wheream.io>
2021-11-11 15:49:10 -08:00
TypeScript Bot
ec158f913c
Cherry-pick PR #46767 into release-4.5 (#46769)
Component commits:
1c07983418 Removed replacement from jsx completions

20c24b970c Fixed tests

Co-authored-by: Armando Aguirre <armando.aguirre@microsoft.com>
2021-11-11 09:05:39 -08:00
TypeScript Bot
32786412de
Cherry-pick PR #46737 into release-4.5 (#46742)
Component commits:
74cd7a5c6c fix extra newline

8df5bef4bd Merge branch 'main' into gabritto/issue46609

67d631cb28 fix test

Co-authored-by: Gabriela Araujo Britto <gabrielaa@microsoft.com>
2021-11-09 12:10:03 -08:00
TypeScript Bot
2857273281
Cherry-pick PR #46670 into release-4.5 (#46671)
Component commits:
615a82c6b9 Make specifier generation from export map information conditional on module resolution mode

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
2021-11-04 17:13:44 -07:00
Daniel Rosenwasser
b8ee3307b2
[release-4.5] Exclude identity relation from mapped type relation check (#46635)
* Exclude identity relation from mapped type relation check

* Add regression test

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
2021-11-04 17:13:04 -07:00
TypeScript Bot
df53f4def2
Cherry-pick PR #46628 into release-4.5 (#46676)
Component commits:
9f9f3edc60 fix(46615): remove useless assertion. change error suggestion for rest params

Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
2021-11-03 15:08:09 -07:00
TypeScript Bot
0651bd3ada
Cherry-pick PR #46614 into release-4.5 (#46675)
Component commits:
e77514a53b Add failing test.

3c0d51b3ed Check for type parameters on the original type when asking for the type argument constraint.

e7c8095935 Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts

Co-authored-by: Daniel Rosenwasser <drosen@microsoft.com>
2021-11-03 15:07:23 -07:00
TypeScript Bot
e4a2494065
Cherry-pick PR #46594 into release-4.5 (#46667)
Component commits:
cd33fc8c27 fix(46589): omit ? in method signature completion for optional methods

Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
2021-11-03 14:08:49 -07:00
Andrew Branch
9b802322da
Properly check whether union type contains only primitive types (#46645) (#46649)
* Properly check whether union type contains only primitive types

* Add regression test

* Remove 'export' modifier from test

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
2021-11-02 17:20:45 -07:00
Daniel Rosenwasser
5764cdc8ec Bump version to 4.4.1-rc and LKG v4.5-rc 2021-10-31 19:35:06 +00:00
Daniel Rosenwasser
4113279327 Merge remote-tracking branch 'origin/main' into release-4.5 2021-10-31 19:23:30 +00:00
csigs
bf6d164bd5
LEGO: Merge pull request 46601
LEGO: Merge pull request 46601
2021-10-29 22:17:49 -07:00
Gabriela Araujo Britto
6b1e8f7baf
remove placeholders in class member snippets (#46598) 2021-10-29 16:55:59 -07:00
csigs
e3fab9fc20
LEGO: Merge pull request 46597
LEGO: Merge pull request 46597
2021-10-29 16:13:23 -07:00
Andrew Branch
7742cf2180
Set hasAddedOrRemovedSymlinks when discovering an existing file by its link (#46569)
* Set hasAddedOrRemovedSymlinks when discovering an existing file by its link

* Make it optional
2021-10-29 15:47:48 -07:00
Andrew Branch
eeaa595196
Enable auto imports in member snippet completions (#46592) 2021-10-29 14:43:32 -07:00
Anders Hejlsberg
b0ab2a54bb
Fix mapped type instantiation circularity (#46586)
* Don't obtain constraint if doing so would cause circularity

* Add regression test

* Address CR feedback
2021-10-29 14:01:27 -07:00
Wesley Wigham
28e3cd3a80
Add error on new module/moduleResolution modes when used in non-nightly TS (#46557)
* Add error on new module/moduleResolution modes when used in non-nightly TS

* Update diagnostic
2021-10-29 11:46:19 -07:00
Jack Bates
9b1ba8f1e3
Fix react-jsx spread children invalid emit (#46565)
* Fix react-jsx spread children invalid emit

* Update Baselines and/or Applied Lint Fixes

* Change childrenLength parameter -> isStaticChildren

Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
2021-10-29 10:54:46 -07:00
Andrew Casey
325435891a
Update GDPR comment formatting (#46585)
...so that they are picked up properly by the tooling.
2021-10-29 10:48:28 -07:00
Gabriela Araujo Britto
9cdbb7248b
Improve errors on module: node12 and extensionless relative imports (#46486)
* add new error + suggestions

* push down assert defined

* remove comment

* fix esm module import detection, update baselines

* add and update new tests

* fix review comments

* remove renamed baseline references

* update node modules test baselines

* fix error message, add new tests

* update old tests with new error message
2021-10-29 10:25:03 -07:00
csigs
f1a69ec93e
LEGO: Merge pull request 46584
LEGO: Merge pull request 46584
2021-10-29 10:14:21 -07:00
Gabriela Araujo Britto
fd620c93f6
Add method signature completions (#46370)
* prototype creation for method override completion snippet

* WIP: start using codefix `addNewNodeForMemberSymbol` to create method decl node

* update type of addNewNodeForMemberSymbol

* add more tests and support more cases

* add more tests and fix some details

* wip: more fixes and tests

* expose check override modifier in checker

* fix test

* WIP: add snippet support

* WIP: snippet support on emitter, adding snippets in completions

* make add snippets work with overloads (not synced)

* fix snippet adding

* rebase

* WIP: try to add snippet escaping in emitter

* support escaping in snippets

* small fixes; fixed tests

* more tests and fixes

* fix new tests

* fix modifier inheritance for overloads

* merge conflict fixes; remove comments

* throw error if setOptions is called but not implemented

* fix newline handling

* fix weird stuff

* fix tests

* fix more tests

* Fix unbound host.getNewLine

* fix isParameterDeclaration changes

* rename diagnostic to status and remove snippets from public api

* rename emitter functions + fix indentation

* check completion kind before calling isclasslikemembercompletion

* fix missing type parameters

* Revert "fix missing type parameters"

This reverts commit 7bdeaa86dae61822a8ee46c13a3680708c6928af.

* add isAmbient flag to addNewNodeForMemberSymbol

* add test for abstract overloads

* refactor snippet escaping support

* add user preference flag for enabling class member snippets

* update API baseline

* update tabstop order

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
2021-10-28 16:05:36 -07:00
csigs
566758d6cb
LEGO: Merge pull request 46566
LEGO: Merge pull request 46566
2021-10-28 10:13:44 -07:00
TypeScript Bot
4e237ed66f
🤖 Update TypeScript DOM Libs (#46222)
Co-authored-by: orta <orta@users.noreply.github.com>
2021-10-28 09:14:26 -07:00
TypeScript Bot
8173afbb8a Update package-lock.json 2021-10-28 06:06:31 +00:00
Daniel Rosenwasser
f494742ce9
Check for array types when instantiating mapped type constraints with any (#46218)
* Added/updated tests.

* Accepted baselines.

* Update test.

* Update instantiateMappedType to work specially when 'any' replaced an array.

* Accepted baselines.

* Ensure check works when constraint is a union of arrayish types, just like in `Promise.all`.

* Accepted baselines.

* Update test for indirect instantiation of a mapped type.

* Accepted baselines.

* Update test comment.

* Accepted baselines.

* Added tuple test case.

* Accepted baselines.

* Don't add special behavior for tuples.

* Accepted baselines.

* Revert "Don't add special behavior for tuples."

This reverts commit f01ae16e6589ec42a931b018ffea03453df60e35.

* Accepted baselines.
2021-10-27 15:03:01 -07:00
Wesley Wigham
abfd537503
Support resolveJsonModule in new module modes (#46434)
* Support resolveJsonModule in new module modes

* Formatting feedback
2021-10-27 12:30:06 -07:00
Zzzen
8a68c8616d
allow typeof this after for-loops (#46181) 2021-10-27 10:26:05 -07:00
Anders Hejlsberg
f424dfc18a
Slightly less conservative check in isConstraintPosition (#46526)
* Slight adjustment to check in isConstraintPosition

* Add regression test
2021-10-26 11:54:46 -07:00
Anders Hejlsberg
44c63a757e
Always cache relations involving intersection types (#46523)
* Always cache relations involving intersection types

* Accept new baselines

* Add regression test
2021-10-26 09:36:19 -07:00
Anders Hejlsberg
658764e499
Bypass caching in removeStringLiteralsMatchedByTemplateLiterals (#46525)
* Bypass caching in removeStringLiteralsMatchedByTemplateLiterals

* Add regression test
2021-10-26 09:34:15 -07:00
TypeScript Bot
e1a2c2c5a9 Update package-lock.json 2021-10-26 06:07:59 +00:00
Andrew Branch
3519af0bab
Fix crash pulling on global types before they're initialized (#46471)
* Add failing test

* Dumb fix

* Compute error message info more lazily

* One more laziness
2021-10-25 10:53:41 -07:00