29634 Commits

Author SHA1 Message Date
Andrew Casey
c76c973d2d
Merge pull request #39987 from amcasey/pinned-release-3.8
Make release-3.8 buildable
2020-08-10 20:21:51 -07:00
Andrew Casey
f9a3708f8a Update GH action 2020-08-10 17:54:47 -07:00
Andrew Casey
bfb239bd2d Make release-3.8 buildable
With this change, you can build the branch using `npm ci && npm run
build`.
2020-08-10 17:38:18 -07:00
TypeScript Bot
650889e2f7
🤖 Pick PR #37264 (Fix longer type-only property acces...) into release-3.8 (#37299)
* Cherry-pick PR #37264 into release-3.8

Component commits:
2669ce7c46 Fix longer type-only property access in non-emitting heritage clauses

eced0e0039 Rename misnomer function

* Update unrelated baseline difference between master and 3.8

Co-authored-by: Andrew Branch <andrew@wheream.io>
2020-03-09 15:55:35 -07:00
Andrew Branch
8d6f004aca
Fix lint error? (#37305) 2020-03-09 14:46:03 -07:00
TypeScript Bot
712967b278 Bump version to 3.8.3 and LKG v3.8.3 2020-02-28 21:33:01 +00:00
Andrew Branch
d8765643fe
Cherry-pick #37064 into release-3.8 (#37096)
* Fix renaming an ExportSpecifier name when propertyName is present (#36790)

* Fix renaming exportSpecifier name when propertyName is present

* Add baseline test for name without propertyName too

* Set correct pos for NamespaceExport (#36794)

* Set correct pos for NamespaceExport

* Update tests

* Cherry-pick PR #37064 into release-3.8
2020-02-28 08:26:28 -08:00
Orta
963c1f0fce
Cherry picks 36880 into 3.8 (#37082)
* Adds floating block comments to the outlining spans response

* Only use one route for grabbing outline nodes, which now includes special casing the EOF token
2020-02-28 08:01:35 -05:00
TypeScript Bot
80a84c3fd8
Cherry-pick PR #37010 into release-3.8 (#37072)
Component commits:
4605c3498f fix(36989): omit 'async' modifier for methods in declaration files.

c144e5e94e Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/36989

fb7fd4260c remove useless condition

c2b709a047 Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/36989

Co-authored-by: Alexander T. <alexander.tarasyuk@outlook.com>
2020-02-27 11:03:09 -08:00
Sheetal Nandi
6def346b4e
Allow --composite false or --composite null on the command line (#36997) (#37062)
* Add tests for specifying composite as command line option

* Allow passing --composite false on commandline

* Add test to verify tsc --composite false from command line

* Handle "undefined" as option value to be set to undefined for that option

* Support "null" as option to be converted to undefined which is normally end result from our config file as well

* Support null as option for any tsconfig only option as well, and dont support undefined

* Fix public api test case

* Validates objects instead of stringify result

* Add composite true to base source
2020-02-26 16:33:53 -08:00
TypeScript Bot
9bf60580af
Cherry-pick PR #37059 into release-3.8 (#37060)
Component commits:
724c7555d0 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command Fixes #35034

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
2020-02-26 15:26:02 -08:00
Wesley Wigham
622c2060e7
Ignore data- props when excess property checking (#36952) (#37031) 2020-02-25 16:29:46 -08:00
TypeScript Bot
c6866c117f
Cherry-pick PR #37021 into release-3.8 (#37025)
Component commits:
864c2d43c7 Check for undefined `source.symbol`
Fixes #37014

Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>
2020-02-25 14:15:10 -08:00
TypeScript Bot
d76a45a6aa
Cherry-pick PR #36993 into release-3.8 (#37020)
Component commits:
7721570861 Harden telemetryOnOpenFile

9535e7b258 Merge branch 'master' of https://github.com/RyanCavanaugh/TypeScript into fix36984

Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>
2020-02-25 11:32:41 -08:00
TypeScript Bot
98fc0753f5
Cherry-pick PR #36996 into release-3.8 (#37002)
Component commits:
888ebf4b2d Fix crash on aliased,exported @enum tag in jsdoc
THe code to bind `@enum` and `@typedef` didn't handle the case that the
`@enum` was on a property assignment to an alias of module.exports.
Specifically, `x` needs to be correctly aliased to the file's symbol in
the example below:

```
var x = module.exports = {};
/** @enum {string} */
x.E = {
  A: "A"
};
```

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-02-24 16:35:56 -08:00
TypeScript Bot
af614ccea1
Update user baselines (#36815) v3.8.2 2020-02-19 12:57:35 -08:00
Daniel Rosenwasser
870cd7b603 Update LKG for 3.8.2. 2020-02-14 15:41:36 -08:00
Daniel Rosenwasser
203ed3ec44 Bump version to '3.8.2'. 2020-02-14 15:39:03 -08:00
TypeScript Bot
1f660074f4
🤖 Cherry-pick PR #36807 into release-3.8 (#36810)
Component commits:
ec495ab121 Fix organizeImports with type-only imports

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
2020-02-14 15:38:06 -08:00
Klaus Meinhardt
051eee00c9 Exempt ambient private properties from noImplicitAny (#36640) 2020-02-14 15:04:35 -08:00
Andrew Branch
5a2fa49205
Cherry-pick release bugs (#36804)
* Fix renaming an ExportSpecifier name when propertyName is present (#36790)

* Fix renaming exportSpecifier name when propertyName is present

* Add baseline test for name without propertyName too

* Set correct pos for NamespaceExport (#36794)

* Set correct pos for NamespaceExport

* Update tests
2020-02-14 13:44:37 -08:00
TypeScript Bot
e7fec6d565
🤖 Cherry-pick PR #36785 into release-3.8 (#36786)
Component commits:
206d39e9b5 Add/convert to failing tests.

11e827ba84 Stop offering to convert single string literals to template expressions.

7d3ad0c8f6 Ensure we're actually testing for single quotes.

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
2020-02-13 12:23:16 -08:00
TypeScript Bot
1986a5faa3
🤖 Cherry-pick PR #36751 into release-3.8 (#36757)
Component commits:
ebbba5bd8f fix(36416): empty import path causes server crash

Co-authored-by: Alexander T. <alexander.tarasyuk@outlook.com>
2020-02-12 14:49:54 -08:00
Sheetal Nandi
5f623b2e21
Handle walkThroughSnippet:/ and untitled:/ as dynamic files (#36722) (#36760)
Handle walkThroughSnippet:/ and untitled:/ as dynamic files
Fixes #36681
2020-02-12 14:02:58 -08:00
TypeScript Bot
94b98f41d8
Update user baselines (#36729) 2020-02-10 16:43:22 -08:00
TypeScript Bot
ae8dc2f610
Cherry-pick PR #36663 into release-3.8 (#36726)
Component commits:
6aaf9845e7 Allow intersections (and substitutions) to be checks against discriminable unions

Co-authored-by: Wesley Wigham <wwigham@gmail.com>
2020-02-10 16:00:56 -08:00
Andrew Casey
fb868964fc
Make Response.performanceData public (#36621) 2020-02-05 13:34:23 -08:00
Daniel Rosenwasser
0026225e78 Update LKG. v3.8-rc 2020-02-05 13:06:35 -08:00
Orta
eaf97e057c De-duplicate indentations in JSX Texts (#36552)
* WIP on making the JSX text node not include whitespace

* Scans to the last newline for JSX correctly

* Handle JSX closing element wrapping

* Offload all jsx text indentation handling to indentMultilineCommentOrJsxText

* Switch from find node -> find inde in formatting

Co-authored-by: Wesley Wigham <wwigham@gmail.com>
2020-02-05 13:03:09 -08:00
Daniel Rosenwasser
e6f4a0f59c Update LKG. 2020-02-05 12:24:47 -08:00
Andrew Branch
ede2f43c80
Fix crash when trying to import a non-exported type (#36619) (#36634)
* Fix crash when trying to import a non-exported type

* Add related info on each declaration
2020-02-05 12:03:43 -08:00
Wesley Wigham
68cbe9e7b4
Also edit the cherry-pick script to handle non-master base branches while we are here 2020-02-05 11:02:49 -08:00
Wesley Wigham
212edf8948
Patch cherry pick script for new octokit 2020-02-05 11:02:31 -08:00
TypeScript Bot
0d93d67615
Update user baselines (#36568) 2020-02-03 12:56:36 -08:00
Daniel Rosenwasser
6396f8e4a5 Update LKG. 2020-01-31 18:20:33 -08:00
Daniel Rosenwasser
e842d8d6f9 Bump version to 3.8.1-rc 2020-01-31 18:15:30 -08:00
Daniel Rosenwasser
2a5ba1d7ef Merge branch 'master' into release-3.8 2020-01-31 18:13:44 -08:00
Andrew Branch
ef8eb0c876
Fix contextually typed object literal completions where the object being edited affects its own inference (#36556)
* Conditionally elide a parameter from contextual type signature calculation

* Slightly different approach to forbid inference to specific expressions

* Handle nested literals and mapped types correctly

* Delete unused cache

* Rename ContextFlags.BaseConstraint and related usage

* Add tests from my PR

* Update ContextFlags comment

Co-Authored-By: Wesley Wigham <wwigham@gmail.com>

* Update comments and fourslash triple slash refs

Co-authored-by: Wesley Wigham <wwigham@gmail.com>
2020-01-31 15:37:18 -08:00
Nathan Shively-Sanders
ad249043da
resolvedJSDocType should cache on node, not symbol (#36561) 2020-01-31 15:19:45 -08:00
Andrew Branch
86556d6c03
Fix export * that resolves to something type-only (#36558)
* Fix `export *` that resolves to something type-only

* Add same tests but non-tsserver
2020-01-31 15:09:27 -08:00
Ron Buckton
8db1d7bc6d
Do not adjust location for import/export keywords with more than one possible binding (#36560) 2020-01-31 14:58:30 -08:00
Ron Buckton
9a357c19f3
Fix wrong script info used to resolve line/offset for call hierarchy items (#36559) 2020-01-31 14:41:25 -08:00
Ron Buckton
01af3aa483
Support 'find references' on most declaration-related keywords (#36490)
* Allow 'find references' to work on most declaration keywords

* Add support for rename

* Add more keywords, move logic out of checker and into services

* Add additional type and expression keywords
2020-01-31 11:53:57 -08:00
Ron Buckton
afddaf090a
Fix declaration for Array.prototype[Symbol.unscopables] (#36540) 2020-01-31 10:42:02 -08:00
Ron Buckton
fcf28506aa
Fix overzealous renaming of emit helpers in es module emit (#36541) 2020-01-31 10:41:47 -08:00
Ron Buckton
24d8f795b2
Fix crash in emitTokenWithComment (#36542) 2020-01-31 10:41:09 -08:00
Sheetal Nandi
80ad0de87e
Fixes to handle file names in module resolution watching and createGetCanonicalFileName (#36106)
* Add test case to verify directory casing preservation when watching

* Fix unicode file name handling when watching failed lookup locations

* Add special file name lower conversion routine and use that instead of toLowerCase
Fixes #31819 and #35559

* Remove unicode from code

* Replace toLocaleLowerCase on filenames with ts.toFileNameLowerCase

* Make the intent of using toFileNameLowerCase more clear and why we make the restriction on turkish I with dot on top of it

* Update baselines for newly added tests in master
2020-01-31 10:40:57 -08:00
Eli Barzilay
ad8feb5f90 Filter out private fields in string literal property completions.
Also some minor simplifications.

Fixes 36082.
2020-01-30 22:42:32 -05:00
Eli Barzilay
75d1ead3fd Improvements based on @sandersn's notes 2020-01-30 22:42:04 -05:00
Eli Barzilay
1a1ed7464d Add a similar test for target.symbol.valueDeclaration
(With the same question still open.)
2020-01-30 22:42:04 -05:00