18960 Commits

Author SHA1 Message Date
Andrew Casey
3813fb1ebe
Merge pull request #20171 from RyanCavanaugh/fixTypingsInstallerAgain
Always send a response to installTypings even if all types are cached
2017-11-20 18:04:33 -08:00
Ryan Cavanaugh
f3257d4b04 Always send a response to installTypings even if all types are cached 2017-11-20 14:43:25 -08:00
Bill Ticehurst
3d5712dee9
Merge pull request #20109 from Microsoft/dev/billti/fixMinifiedLibraries
Moved minified file exclusion
2017-11-17 13:08:42 -08:00
Bill Ticehurst
c391c7c23b Fixed internal safelist 2017-11-17 12:49:56 -08:00
Bill Ticehurst
b72ba94a33 Moved minified file exclusion 2017-11-17 11:38:51 -08:00
Ryan Cavanaugh
465a2c5563
Merge pull request #20083 from RyanCavanaugh/port20048_2.5
Port20048 2.5
2017-11-17 09:58:49 -08:00
Ryan Cavanaugh
63b08f0f4b Port the actual JSON file 2017-11-16 17:32:43 -08:00
Ryan Cavanaugh
03e6d60eb8 Remove incorrect baseline file 2017-11-16 17:05:38 -08:00
Ryan Cavanaugh
789a2dccf0 Fix merge 2017-11-16 16:27:11 -08:00
Ryan Cavanaugh
c964f220e7 Port PR #20048 2017-11-16 15:01:26 -08:00
Ryan Cavanaugh
9d5b07e445 Squash port of PR #19542 2017-11-16 14:58:04 -08:00
Bill Ticehurst
6d1932631b Merge pull request #19228 from Microsoft/dev/billti/fixScriptKindsTypeChecked
Stop error checking script blocks
2017-10-16 14:59:09 -07:00
Bill Ticehurst
7566760911 Set the scriptKind from the host configuration if present 2017-10-16 13:38:28 -07:00
Mohamed Hegazy
94b4f8b79e Update LKG v2.5.3 2017-09-22 12:55:18 -07:00
Ryan Cavanaugh
aa40be6553 Merge pull request #18673 from RyanCavanaugh/port18603
Report external files in initial case
2017-09-21 17:41:00 -07:00
Ryan Cavanaugh
6281b05179 Report external files in initial case 2017-09-21 17:29:33 -07:00
Andy
5538770c77 Look at correct 'package.json' location for a scoped package (#18580) (#18651)
* Look at correct 'package.json' location for a scoped package

* Update baseline
2017-09-21 10:13:38 -07:00
Andrew Casey
acfd67022f Merge pull request #18617 from amcasey/NoModifiers25
JavaScript: handle lack of modifiers on extracted method
2017-09-20 16:23:39 -07:00
Andrew Casey
9630c46ea7 JavaScript: handle lack of modifiers on extracted method
The emitter expects undefined, rather than empty.  This only affects JS,
because TS applies `private` to all extracted methods.
2017-09-20 14:48:11 -07:00
Ryan Cavanaugh
7b5247f3ac Merge pull request #18605 from RyanCavanaugh/portExternalFilesFixes
Port plugin fixes from master
2017-09-20 11:40:06 -07:00
Ryan Cavanaugh
6ed9badb56 Port plugin fixes from master 2017-09-20 11:16:51 -07:00
Andrew Casey
e9a9d2c36d Merge pull request #18518 from amcasey/ExtractMethodFixes25
Port Extract Method fixes from master
2017-09-20 10:58:17 -07:00
Andrew Casey
27bede8ef1 Stop requiring that the full range of a declaration fall within the
selection

Fixes #18546

(cherry picked from commit af49c60a2cb415e9481dec58285c497bd7f49fed)
2017-09-19 17:33:37 -07:00
Andrew Casey
f0b78437f8 Merge pull request #18508 from amcasey/ExtractSingleToken
Re-enable extraction of a single token

(cherry picked from commit 47b61ac18c304028036914bba1cc65220b4732f9)
2017-09-19 17:31:20 -07:00
Andrew Casey
063e8a72ec Merge pull request #18427 from amcasey/GH17869
Forbid extraction of empty spans

(cherry picked from commit be5c00f4c9626848fe8e812aad32b86020c296bc)
2017-09-19 17:31:20 -07:00
Andrew Casey
fbb6cd57c0 Merge pull request #18448 from amcasey/NestedReturn
Only introduce return properties at the top level

(cherry picked from commit 288a57c16dbf2b55070ed350d139de618953d9ef)
2017-09-19 17:31:19 -07:00
Andrew Casey
a667b0455d Merge pull request #18423 from amcasey/GH18188
Call getShorthandAssignmentValueSymbol rather than getSymbolAtLocation

(cherry picked from commit aade97111affde82044cfc1384746f141efd0694)
2017-09-19 17:31:19 -07:00
Andrew Casey
334125ed23 Merge pull request #18343 from amcasey/InsertionPosition
Improve insertion position of extracted methods

(cherry picked from commit 40e459117aeb0b792a23d6805af884b594dd42c4)
2017-09-19 17:31:18 -07:00
Andrew Casey
12d1ea50ca Merge pull request #18165 from amcasey/GH18144
Simplify and correct PermittedJumps computation

(cherry picked from commit deefb01c9d53020a46a1692bf73b34696dad5c0c)
2017-09-19 17:31:18 -07:00
Andrew Casey
2dd647d08c Merge pull request #18164 from amcasey/GH18140
Handle the combination of a write and a void return

(cherry picked from commit 02cfb81ac0c9b870d31be14b16b0a08ea24ed32a)
2017-09-19 17:31:17 -07:00
Matt Bierner
d36f254f5e Fix extract method for anon class expressions (#18168)
Check `scope.name` when trying to extract from an anon class

(cherry picked from commit c7b4ed3a91964915b953b34ad2ae72f36e7d6efe)
2017-09-19 17:31:17 -07:00
Andrew Casey
f80995653a Tidy up Extract Method fourslash tests
Partial port of ea4fdc5a9
2017-09-19 17:31:17 -07:00
Mohamed Hegazy
4a63ed7afa Update LKG 2017-09-19 16:12:13 -07:00
Mohamed Hegazy
dac383e402 Fix the version of ts to 2.5 2017-09-19 16:11:29 -07:00
Andy
387fc205d0 Ensure that emitter calls callbacks for empty blocks (#18547) (#18550)
* Ensure that emitter calls callbacks for empty blocks (#18547)

* Fix action description
2017-09-18 11:17:06 -07:00
Andrew Casey
839145cd79 Merge pull request #18517 from amcasey/RequestCountDecr25
Only decrement activeRequestCount on SetTypings responses
2017-09-18 11:00:55 -07:00
Andrew Casey
6ad8adcdfe Drop Debug.fail
...from `release-2.5`.  I'm not 100% confident it won't be hit and we'll
recover if we do.  It's still in master, so dogfooding should flush out
any remaining issues before 2.6.
2017-09-15 15:34:24 -07:00
Andrew Casey
ebee7c62be Only decrement activeRequestCount on SetTypings responses
InvalidateCache responses are triggered by file watchers, rather than by
requests.
2017-09-15 15:32:10 -07:00
Andy
9639b52fcd Fixes to emit / format for codeFix (#18486) 2017-09-14 14:57:03 -07:00
Nathan Shively-Sanders
b62d5f6696 Use createMissingNode for sentinel node 2017-09-14 13:05:56 -07:00
Nathan Shively-Sanders
1cffd5f8aa Add missed baselines 2017-09-14 13:05:30 -07:00
Nathan Shively-Sanders
86d5311feb Don't parse param init when = is required but missing
Makes another test case pass that was taking exponential time to parse,
because now it notices that the = is not present and doesn't even try to
parse the initialiser expression.
2017-09-14 13:05:03 -07:00
Nathan Shively-Sanders
3a25650f1d Fail spec parsing lambdas on parameter missing a =
Fail speculative parsing of arrow function expressions whenever it has a
parameter with an initialiser that is missing '='. Ordinarily this is
allowed for better error recovery in the language service, but for
speculative parsing, the errors can compound. When the initialiser is an
error, and when the '=>' is missing (which is also allowed), what is
putatively an arrow function may actually be something else.

For example, `(a / 8) + function ()
{ }` is currently parsed as if someone had intended to write

`(a = /8)+function()/) => { }` but they forgot the `=` of the
initialiser, the `=>` of the lambda, forgot to close the regular
expression, and mistakenly inserted a newline right after the regular
expression.
2017-09-14 13:04:57 -07:00
Andy
39ecfc0db2 When loading a module from node_modules, get packageId even in the loadModuleFromFile case (#18185) (#18326)
* When loading a module from node_modules, get packageId even in the `loadModuleFromFile` case

* Support packageId for <reference types> too
2017-09-14 11:51:32 -07:00
Andrew Casey
14c860b9cb Don't get typings for projects with disabled language services (#18324) 2017-09-14 11:51:23 -07:00
Andrew Casey
cab65ba4cb Limit the number of unanswered Typings Installer requests (#18321)
* Document ThrottledOperations.schedule

* Limit the number of unanswered typings installer requests

If we send them all at once, we (apparently) hit a buffer limit in the
node IPC channel and both TS Server and the typings installer become
unresponsive.

* Fix lint issues

* Add explanatory comment
2017-09-14 11:51:10 -07:00
Andy
74a7588f4d extractMethod: Don't try to extract an ExpressionStatement consisting of a single token (#18450) (#18473)
* extractMethod: Don't try to extract an ExpressionStatement consisting of a single token

* Move to unit test
2017-09-14 11:35:38 -07:00
Mohamed Hegazy
a2c56e0f9d Update LKG 2017-09-09 22:27:47 -07:00
Andy
b1e9446ee0 extractMethod: Don't try to extract a single token (#18090)
* extractMethod: Don't try to extract a single token

* Update tests
2017-09-09 22:24:55 -07:00
Mohamed Hegazy
1c7a29eeb3 Port fixes from master into release-2.5 (#18361)
* Test: parsing of two-line @typedef jsdoc

* Fix forEachChild's visit of JSDocTypedefTag

Also remove JSDocTypeLiteral.jsdocTypeTag, which made no sense since it
was only useful when storing information for its parent `@typedef` tag.

* Update baselines

* Inline variable to aid control flow

* Improved caching scheme for anonymous types

* Fix signature help

* Optimize caching of type literals

* Accept new baselines

* Fix linting errors

* Use canonicalized forms when comparing signatures

* Minor changes

* Document ThrottledOperations.schedule

* Limit the number of unanswered typings installer requests

If we send them all at once, we (apparently) hit a buffer limit in the
node IPC channel and both TS Server and the typings installer become
unresponsive.

* Fix lint issues

* Add explanatory comment
2017-09-09 12:54:30 -07:00