19044 Commits

Author SHA1 Message Date
Kanchalai Tanglertsampan
1ac95c29e4 Add tests and update baselines 2017-07-07 15:53:55 -07:00
Kanchalai Tanglertsampan
7e395c2f88 import keyword a left-hand-side expression 2017-07-07 15:53:24 -07:00
Andy
e4a69174db LineNode.add: return value never used (#17016) 2017-07-07 14:00:09 -07:00
Andy
31ce6cfba6 Minor cleanups to ScriptVersionCache (#16983) 2017-07-07 10:49:59 -07:00
Andy
dcc3e72636 Use decodeSpan more (#16990) 2017-07-07 10:37:18 -07:00
Andy
ee48c1b4cc Minor cleanups to EditWalker (#16980) 2017-07-07 10:36:46 -07:00
Andy
d3f4447657 Minor cleanups to LineIndexSnapshot (#16981) 2017-07-07 10:35:21 -07:00
Andy
e6256d43c4 Inline getDestructuringParameterName (#16973) 2017-07-07 10:34:50 -07:00
Andy
17578e8a5d Use Map<true> for sets (#16972) 2017-07-07 10:34:36 -07:00
Andy
2d802a62c4 Have isObjectBindingPatternElementWithoutPropertyName return the binding element (#16956) 2017-07-07 10:34:11 -07:00
Andy
81f8151e3a Use 'push' and 'pop' methods instead of using array.length (#16979) 2017-07-07 10:22:59 -07:00
Andy
ba53b42663 Clean up findChildIndex (#16984) 2017-07-07 10:15:04 -07:00
Andy
ba8e5a7e24 Never return undefined from getExportsOfModule (#17013) 2017-07-07 10:06:12 -07:00
Andy
d4c11bfa1b Clean up creation of 'args' in client.ts (#17009) 2017-07-07 08:09:59 -07:00
Andy
e7dc2a67ca Enable "object-literal-shorthand" lint rule (#16987) 2017-07-07 07:26:58 -07:00
ikatyang
a79240fbc6 Add missing docs for module: 'none' in tsc --init 2017-07-07 18:25:22 +08:00
Wesley Wigham
dc81b456e2 gulp-typescript does handles config extension correctly now (#16992) 2017-07-06 15:58:22 -07:00
Wesley Wigham
2a4b9c70e7 Use correct source root for tests (#16982)
I noticed my error messages while testing were names like `"E:\Github\compiler\binder.ts"` - with this change, they originate from the correct location (are are thus clickable links in the console). The previous path may have been required as a workaround for some old version of the tools we use, but is apparently no longer needed.
2017-07-06 15:56:59 -07:00
Wesley Wigham
4b19eb3200 Remove duplicate entries from tsconfig files (#16991) 2017-07-06 15:56:34 -07:00
Wesley Wigham
07e8263204 Start using a union for FunctionLike things (#16988)
* Start using a union for FunctionLike things

* Rename to shorter name
2017-07-06 14:46:15 -07:00
Wesley Wigham
4e6b2f3c93 Created a branded type for identifier-escaped strings (#16915)
* Created a branded type for escaped strings

Then flowed it throughout the compiler, finding and fixing a handful of
bugs relating to underscore-prefixed identifiers in the process.
Includes a test for two cases noticed - diagnostics from conflicting
symbols from export *'s, and enum with underscore prefixed member emit.

* Correctly double underscores WRT mapped types

* Add fourslash tests for other fixed issues

* use function call over cast

* Update forEachEntry type accuracy

* Just use escaped names for ActiveLabel

* Remove casts from getPropertyNameForPropertyNameNode

* This pattern has occurred a few times, could use a helper function.

* Remove duplicated helper

* Remove unneeded check, use helper

* Identifiers list is no longer escaped strings

* Extract repeated string-getting code into helper

* Rename type and associated functions

* Make getName() return UnderscoreEscapedString, add getUnescapedName()

* Add list of internal symbol names to escaped string type to cut back on casting

* Remove outdated comments

* Reassign interned values to nodes, just in case

* Swap to string enum

* Add deprecated aliases to escapeIdentifier and unescapeIdentifier

* Add temp var

* Remove unsafe casts

* Rename escaped string type as per @sandersn's suggestion, fix string enum usages

* Reorganize double underscore tests

* Remove jfreeman from TODO

* Remove unneeded parenthesis
2017-07-06 14:45:50 -07:00
Arthur Ozga
ad291d924d Merge pull request #16748 from aozgaa/implementOptionCrash
visit question token
2017-07-06 13:51:15 -07:00
Arthur Ozga
53a5abca27 Merge pull request #16878 from aozgaa/caretPositionInFourslash
Caret position in fourslash
2017-07-06 11:43:00 -07:00
Arthur Ozga
dc08c5f241 Merge branch 'master' into caretPositionInFourslash 2017-07-06 10:44:59 -07:00
Arthur Ozga
86894f3a6f i++ 2017-07-05 14:26:59 -07:00
Arthur Ozga
a200aa9329 non-default args 2017-07-05 12:54:42 -07:00
Wesley Wigham
296660a2a0 Add package lock to gitignore (#16770) 2017-07-05 12:51:32 -07:00
Arthur Ozga
2857bb9703 remove fixCaretPosition 2017-07-05 12:47:32 -07:00
Charles Pierce
228ce06461 #15214 Remove nonpublic members from destructuring completion lists 2017-07-05 10:03:56 -07:00
Anders Hejlsberg
f18a177c97 Merge branch 'master' into optimizeTypeRelations 2017-07-05 07:01:38 -10:00
Anders Hejlsberg
7b9f5b3b66 Merge branch 'master' into optimizeForEachChild 2017-07-05 06:52:49 -10:00
Arthur Ozga
b5e069816d consolidate function call 2017-06-30 19:50:09 -07:00
Arthur Ozga
d661622e19 update tests 2017-06-30 19:41:09 -07:00
Arthur Ozga
5652b0677e update caret position based on edit range 2017-06-30 19:40:56 -07:00
Ron Buckton
2a6aacd0ef Merge pull request #16696 from Microsoft/fix15663
Ignore jsdoc when inferring rest args in JavaScript
2017-06-30 14:27:55 -07:00
Nathan Shively-Sanders
9048c0ae47 Merge pull request #16844 from Microsoft/codefix-spelling-correction-for-typeparameters
Spelling code fix: suggestions from apparent type
2017-06-30 12:56:18 -07:00
Yui
a7fe9db746 Merge pull request #16847 from Microsoft/master-RWC
[master] fix RWC runner
2017-06-30 12:08:23 -07:00
Kanchalai Tanglertsampan
67faecc32c remove BOM 2017-06-30 11:52:00 -07:00
Nathan Shively-Sanders
abec46ce48 Test:spelling suggestions for more types
Test spelling suggestions for primitives, unions/intersections and type
parameters with constraints.
2017-06-30 10:12:02 -07:00
Nathan Shively-Sanders
e0bf267029 spelling:getPropertiesOfType instead of objectType
This provides suggestions for more types based on their apparent type:
unions, type parameters with constraints, primitives.
2017-06-30 10:11:00 -07:00
Arthur Ozga
4e6e1d1b8b Merge pull request #16657 from aozgaa/formatOnOpenCurly
Format on open curly
2017-06-30 10:04:57 -07:00
Nathan Shively-Sanders
48f4408405 Merge pull request #16862 from Microsoft/dedupe-some-utility-code
Dedupe some utility code
2017-06-30 09:47:07 -07:00
Nathan Shively-Sanders
2eec7f3565 Dedupe some utility code
1. convertToArray is a duplicate of arrayFrom
2. inferFromParameterTypes delegates immediately to inferFromTypes
3. One usage of arrayFrom instantiated a whole iterator only to take the
first element, which is the same as calling `next`.
2017-06-30 09:23:00 -07:00
Nathan Shively-Sanders
f172f72e76 Merge pull request #16846 from Microsoft/remove-unused-bindWorker-code
Remove unused code in bindWorker
2017-06-30 07:14:19 -07:00
Arthur Ozga
25abf8a9e8 respond ot comments 2017-06-29 17:31:41 -07:00
Kanchalai Tanglertsampan
2e13c3a7a6 Update RWC runner 2017-06-29 16:55:46 -07:00
Kanchalai Tanglertsampan
0ffbb75503 check error early and return null to indicate that everything is going well 2017-06-29 16:53:37 -07:00
Nathan Shively-Sanders
b1af566396 Remove unused code in bindWorker 2017-06-29 16:30:44 -07:00
Nathan Shively-Sanders
f45df8fb69 Spelling code fix:suggestions from apparent type
The code fix for spelling correction needs to provide suggestions based
on the apparent type since sometimes the type at a location will be a type
parameter. One such example is `this`.

Fixes #16744
2017-06-29 16:21:00 -07:00
Ryan Cavanaugh
ec00bb9b72 Merge pull request #16697 from RyanCavanaugh/preserveMethodComments
Preserve method comments in JS->ES6 conversion.
2017-06-29 15:40:16 -07:00