21685 Commits

Author SHA1 Message Date
Sheetal Nandi
f32c2eac65 Some changes to incremental tests 2019-10-17 11:46:54 -07:00
Andrew Casey
f39b49d756 Update another writeFile call-site 2019-10-17 11:36:45 -07:00
Nathan Shively-Sanders
f5dbcb78af
Resolve more jsdoc value references as types (#34515)
* Resolve more jsdoc value references as types

* add test
2019-10-17 11:21:34 -07:00
Nathan Shively-Sanders
262ec6171d
Make ImageData(Uint8ClampedArray)'s 3rd param optional (#34519)
It can be inferred from the first two.

Fixes #33266

Baseline update from microsoft/TSJS-lib-generator#790
2019-10-17 11:14:07 -07:00
Andrew Branch
f41b7b59ce
Fix quick info for methods whose contextual type is a mapped type property (#33930) 2019-10-17 10:54:01 -07:00
Andrew Branch
a95a25b9a7
Fix completions of optional properties in generic positions (#33937)
* fixes #30507

* Add test case for generic Partial type

* Fixes #28470

* Simplify contextFlags binary check

* Add string literal completion test

* Fix ContextFlags typings

* Speed up inference expression for completion

* Fix baseline merge

* Make contextFlags internal

* Reapply readonly array changes

* accept baselines

* Fix generic completion tests

* Re-merge ContextFlags

* Don’t change type during inference

* Fix typos and superfluous undefined arguments

* Add test for completions in unconstrained generic object literal
2019-10-17 10:45:40 -07:00
Klaus Meinhardt
45d0ef9441 factory: parenthesize for-of expression when necessary (#34229)
Fixes: #33856
2019-10-17 10:17:33 -07:00
Orta
5d20c573a6
Merge pull request #34524 from orta/fix_32675
Does not add a duplicate completion when offering an export which was re-declared as a global
2019-10-17 13:08:32 -04:00
Orta Therox
85010fa6fe Make sure that global module re-exports are short-cutted to be added to completions 2019-10-17 12:33:01 -04:00
Nathan Shively-Sanders
f3a234caac
Dedupe inherited jsdoc comments (#34522)
JSDoc on own properties was already deduped, but inherited jsdoc was
incorrectly not deduped.

Fixes #32708
2019-10-16 15:56:01 -07:00
Sheetal Nandi
1531c9ec21 Fix lint rules 2019-10-16 15:42:53 -07:00
Sheetal Nandi
9fa7d8b3b9 Use getNormalizedAbsolutePath to combine basePath and config value for file names
Fixes #34502 by being consistent in path normalization
2019-10-16 15:38:29 -07:00
csigs
0709bde718 LEGO: check in for master to temporary branch. 2019-10-16 22:10:29 +00:00
Sheetal Nandi
a4044ca684 Add test for #34502 2019-10-16 14:32:18 -07:00
Sheetal Nandi
66ea16a23a Sample to baseline output 2019-10-16 14:05:07 -07:00
Orta Therox
c40ddb183e Does not add a duplicate completion when offering an export which was re-declared as a global - fixes #32675 2019-10-16 17:02:35 -04:00
Sheetal Nandi
e54d5cae60 outFile to baseline 2019-10-16 12:51:41 -07:00
Sheetal Nandi
5390c644c9 rootDir tests are baselined 2019-10-16 12:19:26 -07:00
Sheetal Nandi
928a4e799c resolveJsonModule as baseline test 2019-10-16 12:12:12 -07:00
Sheetal Nandi
4b13406baf transitiveReferences as baseline 2019-10-16 11:52:46 -07:00
Sheetal Nandi
25db0b0bf0 Merge baselining and tsc logic into one 2019-10-16 11:39:40 -07:00
Sheetal Nandi
e3cc4f4730 missingExtendedConfig to baseline test 2019-10-16 11:39:04 -07:00
Sheetal Nandi
7c0cc4a3b9 empty files to baseline test 2019-10-16 11:37:43 -07:00
Sheetal Nandi
c2eabddf5c Write ExitStatus as enumng-rootDir-is-in-the-tsconfig.js 2019-10-16 11:37:35 -07:00
Andrew Casey
b6659e5d6e Inline function to tidy up control flow 2019-10-16 11:34:38 -07:00
Andrew Casey
4ed80b62df Stop pre-emptively creating directories
Checking for directory existence is expensive and frequently indicates
success.  Instead of pre-emptively creating the directory containing a
file to be written, attempt to create the file and only do the directory
scaffolding if the write fails.

Appears to reduce file write time by 10-20% for a file-I/O heavy partner
build.

Thanks to @rbuckton for the suggestion!
2019-10-16 11:24:24 -07:00
Klaus Meinhardt
178417f431 factory: correctly parenthesize conditional head (#34227)
Fixes: #34109
2019-10-16 10:41:52 -07:00
Sheetal Nandi
348735a755 Demo as baseline test instead 2019-10-16 09:10:33 -07:00
Sheetal Nandi
c8e6f1c2eb Convert some more tests into baselines 2019-10-16 09:10:30 -07:00
Sheetal Nandi
333436b9a8 Some changes to incremental tests 2019-10-16 09:10:22 -07:00
csigs
510639218a LEGO: check in for master to temporary branch. 2019-10-16 16:10:11 +00:00
Martin Johns
408b17649a doc(lib/es5): Fix grammar in DateConstructor.UTC documentation (#34509)
This fixes #34507.
2019-10-16 08:33:22 -07:00
Sheetal Nandi
2c4cf0d1d5 Do not write build info if there are no files to emit 2019-10-16 08:28:23 -07:00
Sheetal Nandi
aaadb17afe
Merge pull request #34495 from microsoft/forceDts
Add forceDtsEmit flag to getEmitOutput
2019-10-16 08:14:47 -07:00
Sheetal Nandi
f24db4ccf4
Merge pull request #33921 from sQVe/refactor/correct-misspelled-response
refactor(spelling): correct misspelled response
2019-10-16 08:07:25 -07:00
Oskar Grunning
2f48ff37fd
refactor(spelling): correct misspelled response 2019-10-16 08:44:14 +02:00
Eli Barzilay
22c15a2e6e
Merge pull request #34365 from elibarzilay/fix-exit-code-on-bogus-build-file
Fix exit code on bogus build file
2019-10-15 15:09:45 -07:00
Nathan Shively-Sanders
ab56cc0c6b
Remove property-override-method error (#34494)
Originally removed incorrectly along with method-override-property error
in #24343, then both were restored in #33509. Only
method-override-property should be an error, since it doesn't actually
work at runtime.
2019-10-15 14:11:51 -07:00
Nathan Shively-Sanders
d8d5ead83b
Restore 'type' and 'namespace' to All completion filter (#34491)
Vote in the comments below if you think I should restore other keywords!
Remember to like and subscribe!
2019-10-15 14:06:47 -07:00
Nathan Shively-Sanders
29f9493d87
Fix crash when exporting+aliasing globalThis inside declare global (#34408)
* global module:Fix crash when exporting+aliasing globalThis

* Fix another globalThis crash

find-all-refs assumed that an export inside a `declare x` was always an
ambient module, but it is not -- `declare global` does not allow
`export`, so find-all-refs shouldn't return any refs for this error case.
2019-10-15 14:05:39 -07:00
Eli Barzilay
730a52bf82 Better format for the exit code test 2019-10-15 15:35:08 -04:00
Eli Barzilay
cd34808a14 Fixes missing error exit code when a bogus input file is specified
Fixes #33849.
2019-10-15 15:35:07 -04:00
Eli Barzilay
f25575e5fe Typofix: ..._OutputsSkupped -> ..._OutputsSkipped 2019-10-15 15:13:11 -04:00
Anders Hejlsberg
a685ac426c
Merge pull request #34212 from microsoft/fix34021
Fix control flow analysis for --noFallthroughCasesInSwitch
2019-10-15 12:10:53 -07:00
Anders Hejlsberg
cbcb59c95c Properly attach alias symbol to readonly T[] types 2019-10-15 11:11:14 -07:00
Sheetal Nandi
850d16e45f Add forceDtsEmit flag to getEmitOutput
Fixes #33936
2019-10-15 10:07:19 -07:00
Anders Hejlsberg
3438681d6b CR feedback + Consistent error spans on case/default clauses 2019-10-15 08:40:16 -07:00
Sheetal Nandi
bb4872b063 Do not write build info if there are no files to emit 2019-10-15 08:37:23 -07:00
Sheetal Nandi
758bd99879 Add test for #30457 2019-10-14 15:05:56 -07:00
Sheetal Nandi
4b10145340 Make sure commandline options are absolute paths so they dont conflict with tsbuildinfo paths
Fixes #33667
2019-10-14 14:44:47 -07:00