microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Use getNormalizedAbsolutePath to combine basePath and config value for file names

Browse Source 
Fixes #34502 by being consistent in path normalization
This commit is contained in:
Sheetal Nandi 2019-10-16 15:38:29 -07:00
parent a4044ca684
commit 9fa7d8b3b9
3 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/commandLineParser.ts
View File

@ -2533,7 +2533,7 @@ namespace ts {
function normalizeNonListOptionValue(option: CommandLineOption, basePath: string, value: any): CompilerOptionsValue {
if (option.isFilePath) {
value = normalizePath(combinePaths(basePath, value));
value = getNormalizedAbsolutePath(value, basePath);
if (value === "") {
value = ".";
}

3
src/tsc/executeCommandLine.ts
View File

@ -241,10 +241,9 @@ namespace ts {
}
const currentDirectory = sys.getCurrentDirectory();
const getCanonicalFileName = createGetCanonicalFileName(sys.useCaseSensitiveFileNames);
const commandLineOptions = convertToOptionsWithAbsolutePaths(
commandLine.options,
fileName => toPath(fileName, currentDirectory, getCanonicalFileName)
fileName => getNormalizedAbsolutePath(fileName, currentDirectory)
);
if (configFileName) {
const configParseResult = parseConfigFileWithSystem(configFileName, commandLineOptions, sys, reportDiagnostic)!; // TODO: GH#18217

2
tests/baselines/reference/tsc/incremental/no-change-run/when-passing-rootDir-is-in-the-tsconfig.js
View File

@ -3,5 +3,3 @@
exitCode:: ExitStatus.Success
//// [/src/project/built/src/main.js] file written with same contents
//// [/src/project/built/tsconfig.tsbuildinfo] file written with same contents