32012 Commits

Author SHA1 Message Date
Sheetal Nandi
f628bf8e24
Fix casing for wild card keys for implicit globs to get wild card directories to watch (#39049)
* Test showing how wild card directory is not watched because of mismatch in key case

* Fix casing for wild card keys for implicit globs
Fixes #36532
2020-06-12 14:21:51 -07:00
Nathan Shively-Sanders
4cf0afe266 DOM update 2020-06-12 2020-06-12 13:55:40 -07:00
Tierney Cyren
b4735c0b3b
fix(a11y): make ISSUE_TEMPLATE/Bug_report.md more accessible for folks with screen readers (#39013) 2020-06-12 13:39:34 -07:00
Ron Buckton
b2afa7b657
Update request-pr-review script to latest version of octokit (#39031) 2020-06-11 18:04:21 -07:00
Nathan Shively-Sanders
45e6805e66
Merge pull request #38688 from microsoft/fix-implements-tag-emit
Fix @implements emit for namespaced base types
2020-06-11 17:08:07 -07:00
Nathan Shively-Sanders
b1dfb68d35 pin version of octokit 2020-06-11 16:46:18 -07:00
Nathan Shively-Sanders
a26e60eb2c skip implements types with no symbols 2020-06-11 16:34:32 -07:00
Nathan Shively-Sanders
9f872c01e1 Merge branch 'master' into fix-implements-tag-emit 2020-06-11 16:05:21 -07:00
Nathan Shively-Sanders
1704b2f112
Merge pull request #39025 from microsoft/isDynamicName-skip-parens
isDynamicName skips parentheses for element access
2020-06-11 10:07:59 -07:00
Nathan Shively-Sanders
a64166de14 isDynamicName skips parentheses for element access
Neither `x[0]` nor `x[(0)]` should be dynamic names. Previously, the
latter was because `isDynamicName` didn't skip parentheses.

Since the binder treats dynamic names in property assignments as
assignment declarations, this incorrectly tried to create a binding for
expressions like `x[(0)] = 1`.

This caused an assert because `x[(0)]` would not take the dynamic name
code path during binding (`hasDynamicName` returned false), but the
normal code path for static names.
2020-06-11 09:08:51 -07:00
Eli Barzilay
ffa35d3272 Allow e: unknown in catch arguments
In addition, allow an explicit `any`; anything else throws an error.

Also adjust and reorganize existing tests.

Fixes #36775.
2020-06-10 18:24:20 -04:00
Wesley Wigham
08cb0b23e8
Serialize (noncontextual) keyword named namespace members with export declarations in both declaration emitters (#38982)
* fix(38750): create unique names for keywords and re-export them with original names

* Serialize (noncontextual) keyword named namespace members with export declarations in both declaration emitters

* Add exhaustive keyword emit test for js declaration emitter and fix it up

Co-authored-by: Alexander T <alexander.tarasyuk@outlook.com>
2020-06-10 14:42:49 -07:00
Wesley Wigham
58330d05a1
Patch to use this.timeout() > 0 rather than this.enableTimeout() to work with mocha 8+ 2020-06-10 14:26:22 -07:00
Wesley Wigham
2287dbc7e2
Handle missing return type nodes and nested type references missing type arguments in existing jsdoc node serialization (#39011)
* Handle missing return type nodes and nested type references missing type arguments in existing jsdoc node serialization

* Accept updated baselines
2020-06-10 12:42:38 -07:00
Andrew Branch
852e7a0b60
Add containerName to CallHierarchyItem (#38997)
* Add containerName to CallHierarchyItem

* Update public APIs

* Update test to demonstrate nested namespace working
2020-06-10 11:56:03 -07:00
Andrew Branch
0d6ae004d7
Fix isSameEntityName (#38999)
* Fix isSameEntityName

* Add baseline

* Fix baseline
2020-06-10 10:53:02 -07:00
rockcs1992
74b4b5640a
Fix typo for 'blocklist' (#39001) 2020-06-10 08:27:16 -07:00
Andrew Branch
895b3c3e20
Update baselines (#39000) 2020-06-09 16:52:22 -07:00
Daniel Rosenwasser
e832e04fa7
Merge pull request #37727 from Kingwl/logical_assignment
Add logical assignment operator
2020-06-09 14:44:08 -07:00
Wesley Wigham
f41398e100
Make isEntityNameVisible duplicate the node builder logic to always consider type parameters as visible if they are the resolution result (#38921) 2020-06-09 13:40:17 -07:00
Sheetal Nandi
a72ed0a2f5
Schedule failed lookup updates (#38560)
* Schedule failed lookup updates

* Tests
2020-06-09 12:00:37 -07:00
Sheetal Nandi
83f41deff2
Remove non null assertion on oldSourceFile.resolvedModules (#38984)
Fixes #37938
2020-06-09 11:52:39 -07:00
Nathan Shively-Sanders
d841971347
Merge pull request #38358 from a-tarasyuk/bug/38081
fix(38081): 'Debug Failure. Invalid cast.' for convert import quick fix
2020-06-09 08:50:56 -07:00
蜗牛老湿
3c49fb0d9f
use blocklist instead of blacklist (#38988) 2020-06-09 08:10:18 -07:00
csigs
a96c8ece9c
LEGO: Merge pull request 38957
LEGO: Merge pull request 38957
2020-06-05 15:11:37 -07:00
csigs
9d8b61256f LEGO: check in for master to temporary branch. 2020-06-05 22:10:52 +00:00
Sheetal Nandi
0dc338281a
Deprecate reloadFs so the tests are more clear in what they are achieving and its easier to track changed behaviour (#38954) 2020-06-05 13:43:34 -07:00
csigs
093e08396d
LEGO: Merge pull request 38949
LEGO: Merge pull request 38949
2020-06-05 09:11:24 -07:00
csigs
9d4327f0f4 LEGO: check in for master to temporary branch. 2020-06-05 16:10:39 +00:00
csigs
a5818e47a2
LEGO: Merge pull request 38943
LEGO: Merge pull request 38943
2020-06-04 21:11:28 -07:00
csigs
4933bdb55e LEGO: check in for master to temporary branch. 2020-06-05 04:10:43 +00:00
Eli Barzilay
3151e2a365 Make hasCorrectArity handle tuples properly
This completes the work that started in PR #33069, and fixes #32835.

There are probably two additional related changes that are needed to
make this more complete:

* Fix the code that composes the error message (see the first two
  `FIXME`s in `callWithSpread3.ts`).

* Fix the code that checks the argument types (second two `FIXME`s).

* There is also an error in `genericRestParameters1.ts` which changed
  but should not be an error in the first place.  Added a `FIXME` there
  too.  (Probably will work if the previous iterm is done.)

In addition, `getEffectiveCallArguments` munges the arguments in case of
a spread in the last argument which might be better to avoid.  (I think
that there are cases where it wouldn't work anyway, such as a spread of
an array followed by a spread of an empty array.)
2020-06-04 23:46:56 -04:00
rchaser53
261386d48b fix error when use spread arguments twice 2020-06-04 23:46:56 -04:00
Eli Barzilay
4ee013d1a7 Fix merging of JS value & TS type decl
Fixes #38383
2020-06-04 19:28:33 -04:00
csigs
077a2a9c94
LEGO: Merge pull request 38938
LEGO: Merge pull request 38938
2020-06-04 15:11:33 -07:00
csigs
68315a0e29 LEGO: check in for master to temporary branch. 2020-06-04 22:10:50 +00:00
Eli Barzilay
a4c14a2cdc getSymbolDisplayPartsDocumentationAndSymbolKind: use actual symbol.flags for getAliasedSymbol
Fixes #35347.
2020-06-04 13:50:33 -04:00
csigs
55d4592f4e
LEGO: Merge pull request 38931
LEGO: Merge pull request 38931
2020-06-04 09:11:45 -07:00
csigs
3a55473eb1 LEGO: check in for master to temporary branch. 2020-06-04 16:10:54 +00:00
csigs
aceb8d601a
LEGO: Merge pull request 38926
LEGO: Merge pull request 38926
2020-06-03 21:11:35 -07:00
csigs
fdae7ee0ea LEGO: check in for master to temporary branch. 2020-06-04 04:10:42 +00:00
Jesse Trinity
3b15b35b37
Merge pull request #38378 from jessetrinity/refactorTriggerReason
Add RefactorTriggerReason
2020-06-03 11:18:08 -07:00
Nathan Shively-Sanders
51bf887167
Merge pull request #38536 from typescript-bot/user-baseline-updates
🤖 User test baselines have changed for refs/heads/master
2020-06-03 10:05:59 -07:00
Eli Barzilay
073fb308bf Fix two tests
* `docCommentTemplateInSingleLineComment`: Accidentally dropped space, fixes #38651

* `codeFixCorrectReturnValue13`: Bogus test code copied
2020-06-03 12:59:16 -04:00
typescript-bot
7a9e8fc8ec Update user baselines 2020-06-03 04:38:50 +00:00
csigs
c52aee57c7
LEGO: Merge pull request 38908
LEGO: Merge pull request 38908
2020-06-02 21:11:25 -07:00
csigs
d8091de532 LEGO: check in for master to temporary branch. 2020-06-03 04:10:42 +00:00
Jesse Trinity
d88ea4e1f8 address PR comments 2020-06-02 19:06:12 -07:00
Jesse Trinity
463f8e10b9
Merge pull request #38734 from a-tarasyuk/bug/34934
fix(34934): Completions for private members appear in JavaScript files
2020-06-02 12:47:17 -07:00
Sheetal Nandi
9fbcb99a33
Emit build info even on noEmitOnError or tsc --build (#38853)
* Emit buildinfo when there are errors with noEmitOnError?
TODO: --build mode

* Always emit tsbuild info even if there are non syntax errors in tsc --build mode

* Sort affectedFilesPendingEmit for consistent build info text
2020-06-02 12:38:40 -07:00