microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Make isEntityNameVisible duplicate the node builder logic to always consider type parameters as visible if they are the resolution result (#38921)

Browse Source
This commit is contained in:
Wesley Wigham 2020-06-09 13:40:17 -07:00 committed by GitHub
parent a72ed0a2f5
commit f41398e100
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 79 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/checker.ts
View File

@ -4064,6 +4064,9 @@ namespace ts {
const firstIdentifier = getFirstIdentifier(entityName);
const symbol = resolveName(enclosingDeclaration, firstIdentifier.escapedText, meaning, /*nodeNotFoundErrorMessage*/ undefined, /*nameArg*/ undefined, /*isUse*/ false);
if (symbol && symbol.flags & SymbolFlags.TypeParameter && meaning & SymbolFlags.Type) {
return { accessibility: SymbolAccessibility.Accessible };
}
// Verify if the symbol is accessible
return (symbol && hasVisibleDeclarations(symbol, /*shouldComputeAliasToMakeVisible*/ true)) || {

27
tests/baselines/reference/declarationEmitTypeParamMergedWithPrivate.js Normal file
View File

@ -0,0 +1,27 @@
//// [declarationEmitTypeParamMergedWithPrivate.ts]
export class Test<T> {
private get T(): T {
throw "";
}
public test(): T {
return null as any;
}
}
//// [declarationEmitTypeParamMergedWithPrivate.js]
export class Test {
get T() {
throw "";
}
test() {
return null;
}
}
//// [declarationEmitTypeParamMergedWithPrivate.d.ts]
export declare class Test<T> {
private get T();
test(): T;
}

19
tests/baselines/reference/declarationEmitTypeParamMergedWithPrivate.symbols Normal file
View File

@ -0,0 +1,19 @@
=== tests/cases/compiler/declarationEmitTypeParamMergedWithPrivate.ts ===
export class Test<T> {
>Test : Symbol(Test, Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 0))
>T : Symbol(T, Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 18), Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 22))
private get T(): T {
>T : Symbol(T, Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 18), Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 22))
>T : Symbol(T, Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 18), Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 22))
throw "";
}
public test(): T {
>test : Symbol(Test.test, Decl(declarationEmitTypeParamMergedWithPrivate.ts, 3, 5))
>T : Symbol(T, Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 18), Decl(declarationEmitTypeParamMergedWithPrivate.ts, 0, 22))
return null as any;
}
}

19
tests/baselines/reference/declarationEmitTypeParamMergedWithPrivate.types Normal file
View File

@ -0,0 +1,19 @@
=== tests/cases/compiler/declarationEmitTypeParamMergedWithPrivate.ts ===
export class Test<T> {
>Test : Test<T>
private get T(): T {
>T : T
throw "";
>"" : ""
}
public test(): T {
>test : () => T
return null as any;
>null as any : any
>null : null
}
}

11
tests/cases/compiler/declarationEmitTypeParamMergedWithPrivate.ts Normal file
View File

@ -0,0 +1,11 @@
// @declaration: true
// @target: es6
export class Test<T> {
private get T(): T {
throw "";
}
public test(): T {
return null as any;
}
}