28264 Commits

Author SHA1 Message Date
Ron Buckton
62264392d2 Support accessors in interfaces in the language service 2019-08-08 17:58:05 -07:00
Ron Buckton
4e8ffd8e4f Add basic test cases for accessors in interfaces and ambient classes 2019-08-07 16:26:08 -07:00
Ron Buckton
77fc6f3b2e Allow and emit accessors on interfaces 2019-08-07 11:38:45 -07:00
Ron Buckton
37c4f24ef3 Allow accessors in ambient classes 2019-08-07 11:22:32 -07:00
Wesley Wigham
f333684179
Fix unicode escapes in jsx identifiers and extended unicode characters in jsdoc (#32716)
* Fix unicode escapes in jsx identifiers and extended unicode characters in jsdoc

* Support unicode escapes in JSDoc

* Add tests for extended escapes
2019-08-06 15:14:32 -07:00
Nathan Shively-Sanders
480b73915f
Improve excess property checking for intersections (#32582)
* Improve excess property checking for intersections

Still a draft, the implementation needs improvement

* Use mutable isIntersection in checkTypeRelatedTo

This makes parameter lists a lot shorter. Seems like a slight
improvement, although I can revert if I change my mind.

* Fix semicolon lint

* Remove TODOOOO

* Revert "Use mutable isIntersection in checkTypeRelatedTo"

This reverts commit b8dccff2a25495867cff070b94601015e689b8ff.
2019-08-06 15:03:24 -07:00
Wesley Wigham
d00056f096
Support extended unicode escapes in identifiers, per es6 spec (#32725) 2019-08-06 14:43:41 -07:00
Ron Buckton
d75740280f
Resolve module specifier relative to moduleFile.originalFileName (#32722)
* Resolve module specifier relative to moduleFile.originalFileName

* Use baseline testing for outputs

* Added skipLibCheck to test

* Switch to using vfs.formatPatch for output
2019-08-06 13:48:58 -07:00
TypeScript Bot
024193fd43 Update user baselines (#32732) 2019-08-06 13:42:07 -07:00
Andrew Casey
01e1b1bb27
Merge pull request #32612 from mrcrane/etw-logger
Use optional module "@microsoft/typescript-etw" for ETW logging
2019-08-06 12:44:48 -07:00
Michael Crane
47e77c976b Remove unnecessary 'commandSucceeded' variable 2019-08-06 11:48:31 -07:00
Nathan Shively-Sanders
269c3d3a56
Suggestions now use diagnosticCollection (#32740)
Previously they used multiMaps, unlike all the other diagnostics. This
prevents duplicate suggestions, like other kinds diagnostics.

Fixes #28710
2019-08-06 11:15:06 -07:00
Ron Buckton
cc3db8f448 Merge branch 'Saulzi-master' 2019-08-06 10:48:47 -07:00
Ron Buckton
3ff0a249d2 Update based on PR feedback 2019-08-06 10:46:17 -07:00
Wesley Wigham
7adc175dfc
Adjust isIdentifierText to skip multiple characters when a code point is multiple chars long (#32720)
* Adjust isIdentifierText to skip multiple characters when a code point is multiple chars long

* Add a few examples with mixed unicode characters

* for posterity, add some unicode cursive script characters

* Test some more planes more explicitly
2019-08-05 23:37:26 -07:00
Ron Buckton
624d1cad93
Fix inferred TNext of generator to use TNext of contextual return type (#32719) 2019-08-05 17:55:28 -07:00
Ron Buckton
e3f4979736
Fix emit for object rest on a module export (#32699)
* Fix emit for object rest on a module export

* Add tests for exports of empty object/array binding patterns

* Add delay for exec to ensure diff tool has enough time to start
2019-08-05 16:53:21 -07:00
Wesley Wigham
3b54ffcf0e
Preserve const enums should keep import refs (#28498)
* Preserve const enums should keep import refs

for exported const enums exported via export default

Move some functionality around, small cleanup

Remove unneeded const enum check

* Only mark const enums as references with preserveConstEnums on in export assignments

* Limit change to declarations and preserveConstEnums mode
2019-08-05 16:47:29 -07:00
Ron Buckton
4df2fc663c
Do not include built/local/enu when producing LKG (#32723) 2019-08-05 16:19:38 -07:00
Michael Crane
f6fb130530 Add 'readFileWorker' instead of modifying 'readFile' 2019-08-05 15:19:25 -07:00
sisisin
33a6509751 Fixes export destructured variables reference (#32007)
* Add basic test for current behavior

* Fixes getting destructured variables references(#31922)

* Add test case that renames destructured property

* Fixes missing nested object destrucuturing variable references
2019-08-05 12:00:06 -07:00
Ron Buckton
5710f7d5ff Merge branch 'master' of https://github.com/Saulzi/TypeScript into Saulzi-master 2019-08-05 11:17:32 -07:00
Andrew Branch
c1e0db7953
Escape apparent substitution in synthesized NoSubstitutionTemplateLiterals (#32580)
* Add failing test

* Escape apparent substitution in synthesized NoSubstitutionTemplateLiterals
2019-08-05 09:31:59 -07:00
Alexander T
012bacc415 Define interface for TSConfig. Change compilerOnSave to compileOnSave (#32481) 2019-08-05 09:24:09 -07:00
Ron Buckton
3c690f1264
Move const enums and typeof facts maps out of createTypeChecker (#32691) 2019-08-03 13:09:11 -07:00
Andrew Branch
e82d0af554
Fix readonly occurrences highlighting (#32583)
* Fix readonly occurrences highlighting

* Rename function

* Rename again

* Apply suggestions from code review

Remove unused function
2019-08-02 18:24:46 -07:00
Michael Crane
cca32f079c Remove more try-finally blocks 2019-08-02 16:49:50 -07:00
Michael Crane
7d44a4592e Remove try-finally blocks 2019-08-02 16:39:33 -07:00
Wesley Wigham
6b4f730535
Fix binding of jsdoc typedefs with no in-comment name attached to an expression statement (#32610)
* Fix binding of jsdoc typedefs with no in-comment name attached to an expression statement

* Check toplevel flag before bind

* Small renames
2019-08-02 16:14:19 -07:00
Andrew Branch
62f65a7884
Make auto-imports more likely to be valid for the file (including JS) & project settings (#32684)
* Add failing tests

* Use default import or namespace import for import fixes when compiler options allow

* Don’t do import * for export=, ever

* Only do import default for export equals if nothing else will work

* Never do import/require in a JavaScript file

* Update tests for changes in master

* Add const/require fix for JS and select based on usage heuristic

* Fix JS UMD import
2019-08-02 15:58:10 -07:00
Andrew Branch
725321f08c
Prioritize “property names” over punctuation in smart select (#32687)
* Prioritize “property names” over punctuation in smart select

* Update doc comment
2019-08-02 15:57:44 -07:00
TypeScript Bot
e75972cbad Update user baselines (#32683) 2019-08-02 13:36:34 -07:00
Wesley Wigham
acdbd10626
Amend scanner to support astral characters in identifiers when parsing es6+ (#32096)
* Amend scanner to support astral characters in identifiers when parsing es6+

* Use charSize helper rather than one-off maybe advance helper

* Update script to emit informative comment, run in unicode 12.1 environment

* Add suggested change
2019-08-02 13:15:51 -07:00
Sheetal Nandi
bf903eb48f
Merge pull request #32613 from microsoft/singleHostFsWatchFile
Create only single StatFileWatcher through node
2019-08-02 11:03:28 -07:00
Michael Crane
5e19753979 Update browser table 2019-08-02 10:50:49 -07:00
Michael Crane
d34cf52576 Use 'noop' for NullLogger 2019-08-02 10:20:17 -07:00
Orta
9243415ead
Merge pull request #32626 from orta/fix-31312
Fixes making changes on JS imports
2019-08-02 11:15:38 -04:00
Orta
4a26271b63
Merge pull request #32663 from orta/fix_31195
Ensure that the comma is removed when all named imports are removed via moveToFile
2019-08-02 10:29:51 -04:00
Orta
78e03848a4
Merge pull request #31946 from orta/30246
Don't let the additional property setting on an object show up as a definition to tsserver
2019-08-02 10:29:34 -04:00
TypeScript Bot
9d404b49ff Update user baselines (#32658) 2019-08-01 15:14:05 -07:00
Orta
8235bb8e90
Merge pull request #32661 from orta/fix_32655
Fix a typo in the error message around language service plugins
2019-08-01 17:24:30 -04:00
Wesley Wigham
00a75c4283
Retarget to es6 and fix the resulting bugs (#32221)
* Retarget to es6 and fix the resulting bugs

* Set target back to es5

* Fix typos in declaration emitter
2019-08-01 14:23:57 -07:00
Michael Crane
fa3e9c86db Add PerfLogger and NullLogger to simplify conditional logic 2019-08-01 12:46:33 -07:00
Orta Therox
c337f046fb Ensure that the comma is removed when all named imports are removed via moveToFile - fixes #31195 2019-08-01 15:01:52 -04:00
Andrew Branch
33f362abaf
Don’t issue used-before-initialization errors in declaration files (#32579) 2019-08-01 11:24:04 -07:00
Andrew Branch
73bef22f0b
A merged interface with an inherited member should satisfy an abstract base class member (#32539)
* A merged interface with an inherited member should satisfy an abstract base class member

* Tighten up comments and names
2019-08-01 09:34:11 -07:00
Orta Therox
777d504580 Fix a typo in the error message around language service plugins 2019-08-01 12:12:26 -04:00
Andrew Branch
b377e99958
Prevent infinite recursion resolving nested conditional types with import types in them (#32097)
* Prevent infinite recursion resolving conditional types

* Use push/popTypeResolution and issue error

* Add failing test

* Fix the actual problem

* Revert unnecessary changes
2019-08-01 08:37:43 -07:00
Sheetal Nandi
3f75d2c879
Merge pull request #32640 from microsoft/parsingDeepParenthesizedExpression
Store already known not parenthesized arrow expression positions for faster exit in case of deep parsing
2019-07-31 14:16:30 -07:00
Orta Therox
3145656f6a Merge branch 'master' of https://github.com/microsoft/typescript into 30246 2019-07-31 17:08:45 -04:00