microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-04-12 23:36:28 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Use indexOfAnyCharCode in, uh, one other place.

Browse Source
This commit is contained in:
Daniel Rosenwasser
2024-07-02 01:14:28 +00:00
parent 8c822293ba
commit ef5dd3416f
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/compiler/commandLineParser.ts
View File

@@ -66,6 +66,7 @@ import {
hasExtension,
hasProperty,
ImportsNotUsedAsValues,
indexOfAnyCharCode,
isArray,
isArrayLiteralExpression,
isComputedNonLiteralName,
@@ -121,6 +122,7 @@ import {
WatchDirectoryKind,
WatchFileKind,
WatchOptions,
wildcardCharCodes,
} from "./_namespaces/ts.js";
const compileOnSaveCommandLineOption: CommandLineOption = {
@@ -4010,18 +4012,16 @@ function toCanonicalKey(path: string, useCaseSensitiveFileNames: boolean): Canon
function getWildcardDirectoryFromSpec(spec: string, useCaseSensitiveFileNames: boolean): { key: CanonicalKey; path: string; flags: WatchDirectoryFlags; } | undefined {
const match = wildcardDirectoryPattern.exec(spec);
if (match) {
// We check this with a few `indexOf` calls because 3 `indexOf`/`lastIndexOf` calls is
// less algorithmically complex (roughly O(3n) worst-case) than the regex we used to use,
// We check this with a few `indexOf` calls because 2 `indexOf`/`lastIndexOf` calls is
// less algorithmically complex (roughly O(2n) worst-case) than the regex we used to use,
// \/[^/]*?[*?][^/]*\/ which was polynominal in v8, since arbitrary sequences of wildcard
// characters could match any of the central patterns, resulting in bad backtracking.
const questionWildcardIndex = spec.indexOf("?");
const starWildcardIndex = spec.indexOf("*");
const wildcardIndex = indexOfAnyCharCode(spec, wildcardCharCodes);
const lastDirectorySeperatorIndex = spec.lastIndexOf(directorySeparator);
return {
key: toCanonicalKey(match[0], useCaseSensitiveFileNames),
path: match[0],
flags: (questionWildcardIndex !== -1 && questionWildcardIndex < lastDirectorySeperatorIndex)
|| (starWildcardIndex !== -1 && starWildcardIndex < lastDirectorySeperatorIndex)
flags: wildcardIndex !== -1 && wildcardIndex < lastDirectorySeperatorIndex
? WatchDirectoryFlags.Recursive : WatchDirectoryFlags.None,
};
}

3
src/compiler/utilities.ts
View File

@@ -9261,7 +9261,8 @@ function escapeRegExpCharacter(match: string) {
return "\\" + match;
}
const wildcardCharCodes = [CharacterCodes.asterisk, CharacterCodes.question];
/** @internal */
export const wildcardCharCodes = [CharacterCodes.asterisk, CharacterCodes.question];
const commonPackageFolders: readonly string[] = ["node_modules", "bower_components", "jspm_packages"];