microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Disallow Infinity, -Infinity and NaN as an enum key name (#56161)

Browse Source
This commit is contained in:
magic-akari 2023-12-07 07:30:06 +08:00 committed by GitHub
parent 7e1c297730
commit ecc10241c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@ -45022,7 +45022,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}
else {
const text = getTextOfPropertyName(member.name);
if (isNumericLiteralName(text) && !isInfinityOrNaNString(text)) {
if (isNumericLiteralName(text)) {
error(member.name, Diagnostics.An_enum_member_cannot_have_a_numeric_name);
}
}

10
tests/baselines/reference/enumWithInfinityProperty.errors.txt Normal file
View File

@ -0,0 +1,10 @@
enumWithInfinityProperty.ts(2,5): error TS2452: An enum member cannot have a numeric name.
==== enumWithInfinityProperty.ts (1 errors) ====
enum A {
Infinity = 1
~~~~~~~~
!!! error TS2452: An enum member cannot have a numeric name.
}

10
tests/baselines/reference/enumWithNaNProperty.errors.txt Normal file
View File

@ -0,0 +1,10 @@
enumWithNaNProperty.ts(2,5): error TS2452: An enum member cannot have a numeric name.
==== enumWithNaNProperty.ts (1 errors) ====
enum A {
NaN = 1
~~~
!!! error TS2452: An enum member cannot have a numeric name.
}

10
tests/baselines/reference/enumWithNegativeInfinityProperty.errors.txt Normal file
View File

@ -0,0 +1,10 @@
enumWithNegativeInfinityProperty.ts(2,5): error TS2452: An enum member cannot have a numeric name.
==== enumWithNegativeInfinityProperty.ts (1 errors) ====
enum A {
"-Infinity" = 1
~~~~~~~~~~~
!!! error TS2452: An enum member cannot have a numeric name.
}